Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/efs_file_system - support transition to primary storage class #20874

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Sep 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20773

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEFSFileSystem_'
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (39.57s)
--- PASS: TestAccAWSEFSFileSystem_disappears (71.82s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (87.75s)
--- PASS: TestAccAWSEFSFileSystem_availabilityZoneName (104.74s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (114.76s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (138.76s)
--- PASS: TestAccAWSEFSFileSystem_basic (139.38s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (145.72s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (186.05s)
--- PASS: TestAccAWSEFSFileSystem_tags (229.45s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/efs Issues and PRs that pertain to the efs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 10, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 10, 2021
@ewbankkit ewbankkit force-pushed the r/efs_fs_transition_to_primary_storage_class branch from 5dc21ba to ea92c95 Compare September 11, 2021 21:01
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSEFSFileSystem_'                    
TestAccAWSEFSFileSystem_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEFSFileSystem_ -timeout 180m
=== RUN   TestAccAWSEFSFileSystem_basic
=== PAUSE TestAccAWSEFSFileSystem_basic
=== RUN   TestAccAWSEFSFileSystem_availabilityZoneName
=== PAUSE TestAccAWSEFSFileSystem_availabilityZoneName
=== RUN   TestAccAWSEFSFileSystem_tags
=== PAUSE TestAccAWSEFSFileSystem_tags
=== RUN   TestAccAWSEFSFileSystem_pagedTags
=== PAUSE TestAccAWSEFSFileSystem_pagedTags
=== RUN   TestAccAWSEFSFileSystem_kmsKey
=== PAUSE TestAccAWSEFSFileSystem_kmsKey
=== RUN   TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== PAUSE TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== RUN   TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== PAUSE TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== RUN   TestAccAWSEFSFileSystem_ThroughputMode
=== PAUSE TestAccAWSEFSFileSystem_ThroughputMode
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy
=== RUN   TestAccAWSEFSFileSystem_disappears
=== PAUSE TestAccAWSEFSFileSystem_disappears
=== CONT  TestAccAWSEFSFileSystem_basic
=== CONT  TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== CONT  TestAccAWSEFSFileSystem_disappears
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy
=== CONT  TestAccAWSEFSFileSystem_ThroughputMode
=== CONT  TestAccAWSEFSFileSystem_kmsKey
=== CONT  TestAccAWSEFSFileSystem_tags
=== CONT  TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== CONT  TestAccAWSEFSFileSystem_availabilityZoneName
=== CONT  TestAccAWSEFSFileSystem_pagedTags
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (17.11s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (42.29s)
--- PASS: TestAccAWSEFSFileSystem_availabilityZoneName (53.58s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (68.78s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (72.09s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (75.60s)
--- PASS: TestAccAWSEFSFileSystem_basic (89.22s)
--- PASS: TestAccAWSEFSFileSystem_disappears (90.09s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (95.37s)
--- PASS: TestAccAWSEFSFileSystem_tags (148.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	152.959s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSEFSFileSystem_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEFSFileSystem_ -timeout 180m
=== RUN   TestAccAWSEFSFileSystem_basic
=== PAUSE TestAccAWSEFSFileSystem_basic
=== RUN   TestAccAWSEFSFileSystem_availabilityZoneName
=== PAUSE TestAccAWSEFSFileSystem_availabilityZoneName
=== RUN   TestAccAWSEFSFileSystem_tags
=== PAUSE TestAccAWSEFSFileSystem_tags
=== RUN   TestAccAWSEFSFileSystem_pagedTags
=== PAUSE TestAccAWSEFSFileSystem_pagedTags
=== RUN   TestAccAWSEFSFileSystem_kmsKey
=== PAUSE TestAccAWSEFSFileSystem_kmsKey
=== RUN   TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== PAUSE TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== RUN   TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== PAUSE TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== RUN   TestAccAWSEFSFileSystem_ThroughputMode
=== PAUSE TestAccAWSEFSFileSystem_ThroughputMode
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy
=== RUN   TestAccAWSEFSFileSystem_disappears
=== PAUSE TestAccAWSEFSFileSystem_disappears
=== CONT  TestAccAWSEFSFileSystem_basic
=== CONT  TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy
=== CONT  TestAccAWSEFSFileSystem_kmsKey
=== CONT  TestAccAWSEFSFileSystem_tags
=== CONT  TestAccAWSEFSFileSystem_ThroughputMode
=== CONT  TestAccAWSEFSFileSystem_pagedTags
=== CONT  TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== CONT  TestAccAWSEFSFileSystem_availabilityZoneName
=== CONT  TestAccAWSEFSFileSystem_disappears
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (16.95s)
--- PASS: TestAccAWSEFSFileSystem_disappears (39.93s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (52.48s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (76.57s)
--- PASS: TestAccAWSEFSFileSystem_basic (80.20s)
--- PASS: TestAccAWSEFSFileSystem_availabilityZoneName (99.56s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (104.47s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (106.22s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (107.23s)
--- PASS: TestAccAWSEFSFileSystem_tags (119.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	127.156s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9b0205d into hashicorp:main Sep 13, 2021
@DrFaust92 DrFaust92 deleted the r/efs_fs_transition_to_primary_storage_class branch September 13, 2021 14:02
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/efs Issues and PRs that pertain to the efs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EFS: support for Transition out of IA
3 participants