Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/aws chime voice connector logging #20863

Merged
merged 9 commits into from
Sep 15, 2021
Merged

F/aws chime voice connector logging #20863

merged 9 commits into from
Sep 15, 2021

Conversation

aleks1001
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSChimeVoiceConnectorLogging_ -timeout 180m
=== RUN   TestAccAWSChimeVoiceConnectorLogging_basic
=== PAUSE TestAccAWSChimeVoiceConnectorLogging_basic
=== RUN   TestAccAWSChimeVoiceConnectorLogging_disappears
=== PAUSE TestAccAWSChimeVoiceConnectorLogging_disappears
=== RUN   TestAccAWSChimeVoiceConnectorLogging_update
=== PAUSE TestAccAWSChimeVoiceConnectorLogging_update
=== CONT  TestAccAWSChimeVoiceConnectorLogging_basic
=== CONT  TestAccAWSChimeVoiceConnectorLogging_update
=== CONT  TestAccAWSChimeVoiceConnectorLogging_disappears
--- PASS: TestAccAWSChimeVoiceConnectorLogging_basic (29.75s)
--- PASS: TestAccAWSChimeVoiceConnectorLogging_disappears (37.73s)
--- PASS: TestAccAWSChimeVoiceConnectorLogging_update (49.12s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       52.293s
...

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. labels Sep 10, 2021
@ewbankkit ewbankkit added the service/chime Issues and PRs that pertain to the chime service. label Sep 13, 2021
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 13, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. labels Sep 13, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 14, 2021
bill-rich
bill-rich suggested changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lokks great. Just a couple small changes.

aws/resource_aws_chime_voice_connector_logging.go Outdated

resp, err := conn.GetVoiceConnectorLoggingConfigurationWithContext(ctx, input)
if !d.IsNewResource() && isAWSErr(err, chime.ErrCodeNotFoundException, "") {
log.Printf("[WARN]Chime Voice Connector logging configuration %s not found", d.Id())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space between [WARN] and the message.

aws/resource_aws_chime_voice_connector_logging.go Outdated

if _, err := conn.PutVoiceConnectorLoggingConfigurationWithContext(ctx, input); err != nil {
if isAWSErr(err, chime.ErrCodeNotFoundException, "") {
log.Printf("[WARN]Chime Voice Connector logging configuration %s not found", d.Id())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space between [WARN] and the message.

aws/resource_aws_chime_voice_connector_logging.go Outdated
},
}

if _, err := conn.PutVoiceConnectorLoggingConfigurationWithContext(ctx, input); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this returns a not found error, the delete should not return an error.

@aleks1001
Address comments
e0a38bb
@aleks1001
Merge remote-tracking branch 'origin/f/aws_chime_voice_connector_logg…
7f435fa 
…ing' into f/aws_chime_voice_connector_logging

# Conflicts:
#	aws/resource_aws_chime_voice_connector_logging.go
#	aws/resource_aws_chime_voice_connector_logging_test.go
@aleks1001 aleks1001 requested a review from bill-rich September 15, 2021 15:37
bill-rich
bill-rich approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bill-rich bill-rich merged commit f25a3cf into hashicorp:main Sep 15, 2021
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bill-rich bill-rich bill-rich approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.59.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aleks1001 @bill-rich @breathingdust @ewbankkit @justinretzolk