-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/route53_health_check - allow updating ip_address
+ sweeper
#20795
r/route53_health_check - allow updating ip_address
+ sweeper
#20795
Conversation
lint error unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSRoute53HealthCheck_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53HealthCheck_ -timeout 180m
=== RUN TestAccAWSRoute53HealthCheck_basic
=== PAUSE TestAccAWSRoute53HealthCheck_basic
=== RUN TestAccAWSRoute53HealthCheck_tags
=== PAUSE TestAccAWSRoute53HealthCheck_tags
=== RUN TestAccAWSRoute53HealthCheck_withSearchString
=== PAUSE TestAccAWSRoute53HealthCheck_withSearchString
=== RUN TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== PAUSE TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== RUN TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== PAUSE TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== RUN TestAccAWSRoute53HealthCheck_IpConfig
=== PAUSE TestAccAWSRoute53HealthCheck_IpConfig
=== RUN TestAccAWSRoute53HealthCheck_Ipv6Config
=== PAUSE TestAccAWSRoute53HealthCheck_Ipv6Config
=== RUN TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== PAUSE TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== RUN TestAccAWSRoute53HealthCheck_withSNI
=== PAUSE TestAccAWSRoute53HealthCheck_withSNI
=== RUN TestAccAWSRoute53HealthCheck_Disabled
=== PAUSE TestAccAWSRoute53HealthCheck_Disabled
=== RUN TestAccAWSRoute53HealthCheck_withRoutingControlArn
=== PAUSE TestAccAWSRoute53HealthCheck_withRoutingControlArn
=== RUN TestAccAWSRoute53HealthCheck_disappears
=== PAUSE TestAccAWSRoute53HealthCheck_disappears
=== CONT TestAccAWSRoute53HealthCheck_basic
=== CONT TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== CONT TestAccAWSRoute53HealthCheck_Disabled
=== CONT TestAccAWSRoute53HealthCheck_withSNI
=== CONT TestAccAWSRoute53HealthCheck_disappears
=== CONT TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== CONT TestAccAWSRoute53HealthCheck_Ipv6Config
=== CONT TestAccAWSRoute53HealthCheck_IpConfig
=== CONT TestAccAWSRoute53HealthCheck_withRoutingControlArn
=== CONT TestAccAWSRoute53HealthCheck_withSearchString
=== CONT TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== CONT TestAccAWSRoute53HealthCheck_tags
--- PASS: TestAccAWSRoute53HealthCheck_disappears (46.99s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (53.05s)
--- PASS: TestAccAWSRoute53HealthCheck_Ipv6Config (55.86s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (59.13s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (63.61s)
--- PASS: TestAccAWSRoute53HealthCheck_tags (68.91s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (71.61s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (78.96s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (79.66s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (85.33s)
--- PASS: TestAccAWSRoute53HealthCheck_Disabled (90.19s)
--- PASS: TestAccAWSRoute53HealthCheck_withRoutingControlArn (101.46s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 106.874s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSRoute53HealthCheck_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53HealthCheck_ -timeout 180m
=== RUN TestAccAWSRoute53HealthCheck_basic
=== PAUSE TestAccAWSRoute53HealthCheck_basic
=== RUN TestAccAWSRoute53HealthCheck_tags
=== PAUSE TestAccAWSRoute53HealthCheck_tags
=== RUN TestAccAWSRoute53HealthCheck_withSearchString
=== PAUSE TestAccAWSRoute53HealthCheck_withSearchString
=== RUN TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== PAUSE TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== RUN TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== PAUSE TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== RUN TestAccAWSRoute53HealthCheck_IpConfig
=== PAUSE TestAccAWSRoute53HealthCheck_IpConfig
=== RUN TestAccAWSRoute53HealthCheck_Ipv6Config
=== PAUSE TestAccAWSRoute53HealthCheck_Ipv6Config
=== RUN TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== PAUSE TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== RUN TestAccAWSRoute53HealthCheck_withSNI
=== PAUSE TestAccAWSRoute53HealthCheck_withSNI
=== RUN TestAccAWSRoute53HealthCheck_Disabled
=== PAUSE TestAccAWSRoute53HealthCheck_Disabled
=== RUN TestAccAWSRoute53HealthCheck_withRoutingControlArn
=== PAUSE TestAccAWSRoute53HealthCheck_withRoutingControlArn
=== RUN TestAccAWSRoute53HealthCheck_disappears
=== PAUSE TestAccAWSRoute53HealthCheck_disappears
=== CONT TestAccAWSRoute53HealthCheck_basic
=== CONT TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== CONT TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== CONT TestAccAWSRoute53HealthCheck_Ipv6Config
=== CONT TestAccAWSRoute53HealthCheck_withSearchString
=== CONT TestAccAWSRoute53HealthCheck_Disabled
=== CONT TestAccAWSRoute53HealthCheck_withRoutingControlArn
=== CONT TestAccAWSRoute53HealthCheck_withSNI
=== CONT TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== CONT TestAccAWSRoute53HealthCheck_disappears
=== CONT TestAccAWSRoute53HealthCheck_tags
=== CONT TestAccAWSRoute53HealthCheck_IpConfig
=== CONT TestAccAWSRoute53HealthCheck_withHealthCheckRegions
provider_test.go:780: skipping tests; current partition (aws-us-gov) does not equal aws
--- SKIP: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (1.40s)
=== CONT TestAccAWSRoute53HealthCheck_withRoutingControlArn
provider_test.go:735: skipping tests; partition aws-us-gov does not support route53-recovery-control-config service
--- SKIP: TestAccAWSRoute53HealthCheck_withRoutingControlArn (1.40s)
=== CONT TestAccAWSRoute53HealthCheck_withSNI
provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating Route53 Health Check (): InvalidInput: Regional control plane current does not support latency health check
status code: 400, request id: 33ac9654-f4b9-40b9-9878-8bff7ee005dd
with aws_route53_health_check.test,
on terraform_plugin_test.tf line 2, in resource "aws_route53_health_check" "test":
2: resource "aws_route53_health_check" "test" {
=== CONT TestAccAWSRoute53HealthCheck_withSearchString
provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating Route53 Health Check (): InvalidInput: Regional control plane current does not support latency health check
status code: 400, request id: 22b20c57-741e-40cf-8c70-f29193ff6eb4
with aws_route53_health_check.test,
on terraform_plugin_test.tf line 2, in resource "aws_route53_health_check" "test":
2: resource "aws_route53_health_check" "test" {
=== CONT TestAccAWSRoute53HealthCheck_tags
provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating Route53 Health Check (): InvalidInput: Regional control plane current does not support latency health check
status code: 400, request id: 19b2bce6-6ac8-4af3-afd1-6bcfec9293db
with aws_route53_health_check.test,
on terraform_plugin_test.tf line 2, in resource "aws_route53_health_check" "test":
2: resource "aws_route53_health_check" "test" {
=== CONT TestAccAWSRoute53HealthCheck_disappears
provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating Route53 Health Check (): InvalidInput: Regional control plane current does not support latency health check
status code: 400, request id: dcc77e4c-d2a3-4923-80a9-c4255b2eb087
with aws_route53_health_check.test,
on terraform_plugin_test.tf line 2, in resource "aws_route53_health_check" "test":
2: resource "aws_route53_health_check" "test" {
=== CONT TestAccAWSRoute53HealthCheck_basic
provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating Route53 Health Check (): InvalidInput: Regional control plane current does not support latency health check
status code: 400, request id: 4dc90bdb-1db8-48bf-9379-9b3eeb6c81d8
with aws_route53_health_check.test,
on terraform_plugin_test.tf line 2, in resource "aws_route53_health_check" "test":
2: resource "aws_route53_health_check" "test" {
--- SKIP: TestAccAWSRoute53HealthCheck_withSNI (12.64s)
--- SKIP: TestAccAWSRoute53HealthCheck_disappears (12.66s)
--- SKIP: TestAccAWSRoute53HealthCheck_withSearchString (12.67s)
--- SKIP: TestAccAWSRoute53HealthCheck_tags (12.75s)
--- SKIP: TestAccAWSRoute53HealthCheck_basic (12.79s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (34.72s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (35.65s)
--- PASS: TestAccAWSRoute53HealthCheck_Ipv6Config (42.14s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (48.64s)
--- PASS: TestAccAWSRoute53HealthCheck_Disabled (64.93s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 70.447s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing: