-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support timeouts block for resource aws_ec2_client_vpn_authorization_rule #20688
support timeouts block for resource aws_ec2_client_vpn_authorization_rule #20688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @joeperks 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
115cc7d
to
fde92dd
Compare
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
Is this PR still active? We'd love to see this functionality added |
… not exists" This reverts commit 4ffbdea.
This reverts commit 8876e88.
This reverts commit 3de43c6.
…idClientVpnEndpointId.NotFound` in `FindClientVPNAuthorizationRules` (hashicorp#15699). Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule' PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule -timeout 180m === RUN TestAccEC2ClientVPNEndpoint_serial === PAUSE TestAccEC2ClientVPNEndpoint_serial === CONT TestAccEC2ClientVPNEndpoint_serial === RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets === PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets === RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears === PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears === RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint === PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint === RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic === PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic === RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups === PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups === CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets === CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic === CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint === CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups === CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears --- PASS: TestAccEC2ClientVPNEndpoint_serial (1.11s) --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (57.33s) --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears (61.52s) --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic (68.40s) --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets (99.99s) --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups (125.74s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 130.096s
… timeouts. Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic' PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic -timeout 180m === RUN TestAccEC2ClientVPNEndpoint_serial === PAUSE TestAccEC2ClientVPNEndpoint_serial === CONT TestAccEC2ClientVPNEndpoint_serial === RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic === PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic === CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic --- PASS: TestAccEC2ClientVPNEndpoint_serial (0.10s) --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic (61.90s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule -timeout 180m
=== RUN TestAccEC2ClientVPNEndpoint_serial
=== PAUSE TestAccEC2ClientVPNEndpoint_serial
=== CONT TestAccEC2ClientVPNEndpoint_serial
=== RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets
=== RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears
=== RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== RUN TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups
=== CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets
=== CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups
=== CONT TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears
--- PASS: TestAccEC2ClientVPNEndpoint_serial (1.10s)
--- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (56.79s)
--- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears (65.63s)
--- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic (68.35s)
--- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets (92.68s)
--- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups (116.70s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 120.997s
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #16890.
Supersedes #15699.
Output from acceptance testing: