Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new aws_chime_voice_connector_group resource #20565

Merged
merged 5 commits into from
Aug 19, 2021
Merged

Add new aws_chime_voice_connector_group resource #20565

merged 5 commits into from
Aug 19, 2021

Conversation

aleks1001
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSChimeVoiceConnectorGroup_ -timeout 180m
=== RUN   TestAccAWSChimeVoiceConnectorGroup_basic
=== PAUSE TestAccAWSChimeVoiceConnectorGroup_basic
=== RUN   TestAccAWSChimeVoiceConnectorGroup_disappears
=== PAUSE TestAccAWSChimeVoiceConnectorGroup_disappears
=== RUN   TestAccAWSChimeVoiceConnectorGroup_update
=== PAUSE TestAccAWSChimeVoiceConnectorGroup_update
=== CONT  TestAccAWSChimeVoiceConnectorGroup_basic
=== CONT  TestAccAWSChimeVoiceConnectorGroup_update
=== CONT  TestAccAWSChimeVoiceConnectorGroup_disappears
--- PASS: TestAccAWSChimeVoiceConnectorGroup_basic (41.41s)
--- PASS: TestAccAWSChimeVoiceConnectorGroup_disappears (44.36s)
--- PASS: TestAccAWSChimeVoiceConnectorGroup_update (72.81s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       75.660s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Aug 13, 2021
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a few minor changes requested.

aws/resource_aws_chime_voice_connector_group.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector_group.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector_group.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector_group.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector_group.go Outdated Show resolved Hide resolved
website/docs/r/chime_voice_connector_group.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSChimeVoiceConnectorGroup_ -timeout 180m
=== RUN   TestAccAWSChimeVoiceConnectorGroup_basic
=== PAUSE TestAccAWSChimeVoiceConnectorGroup_basic
=== RUN   TestAccAWSChimeVoiceConnectorGroup_disappears
=== PAUSE TestAccAWSChimeVoiceConnectorGroup_disappears
=== RUN   TestAccAWSChimeVoiceConnectorGroup_update
=== PAUSE TestAccAWSChimeVoiceConnectorGroup_update
=== CONT  TestAccAWSChimeVoiceConnectorGroup_basic
=== CONT  TestAccAWSChimeVoiceConnectorGroup_update
=== CONT  TestAccAWSChimeVoiceConnectorGroup_disappears
--- PASS: TestAccAWSChimeVoiceConnectorGroup_disappears (18.68s)
--- PASS: TestAccAWSChimeVoiceConnectorGroup_basic (20.95s)
--- PASS: TestAccAWSChimeVoiceConnectorGroup_update (33.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.539s

@bill-rich bill-rich merged commit 74b5e12 into hashicorp:main Aug 19, 2021
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 19, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 19, 2021
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants