Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f athena request pays enabled #20457

Merged
merged 4 commits into from
Aug 9, 2021
Merged

f athena request pays enabled #20457

merged 4 commits into from
Aug 9, 2021

Conversation

drewmullen
Copy link
Collaborator

@drewmullen drewmullen commented Aug 6, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #14776

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAthenaWorkGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAthenaWorkGroup -timeout 180m
=== RUN   TestAccAWSAthenaWorkGroup_basic
=== PAUSE TestAccAWSAthenaWorkGroup_basic
=== RUN   TestAccAWSAthenaWorkGroup_disappears
=== PAUSE TestAccAWSAthenaWorkGroup_disappears
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy
=== RUN   TestAccAWSAthenaWorkGroup_Description
=== PAUSE TestAccAWSAthenaWorkGroup_Description
=== RUN   TestAccAWSAthenaWorkGroup_State
=== PAUSE TestAccAWSAthenaWorkGroup_State
=== RUN   TestAccAWSAthenaWorkGroup_ForceDestroy
=== PAUSE TestAccAWSAthenaWorkGroup_ForceDestroy
=== RUN   TestAccAWSAthenaWorkGroup_Tags
=== PAUSE TestAccAWSAthenaWorkGroup_Tags
=== CONT  TestAccAWSAthenaWorkGroup_basic
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled
=== CONT  TestAccAWSAthenaWorkGroup_Description
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms
=== CONT  TestAccAWSAthenaWorkGroup_State
=== CONT  TestAccAWSAthenaWorkGroup_ForceDestroy
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery
=== CONT  TestAccAWSAthenaWorkGroup_Tags
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration
=== CONT  TestAccAWSAthenaWorkGroup_disappears
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3
--- PASS: TestAccAWSAthenaWorkGroup_disappears (31.45s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3 (44.16s)
--- PASS: TestAccAWSAthenaWorkGroup_basic (44.22s)
--- PASS: TestAccAWSAthenaWorkGroup_ForceDestroy (67.01s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration (67.99s)
--- PASS: TestAccAWSAthenaWorkGroup_Description (68.07s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery (68.12s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled (68.18s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled (68.19s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms (68.71s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation (78.41s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy (79.72s)
--- PASS: TestAccAWSAthenaWorkGroup_State (81.56s)
--- PASS: TestAccAWSAthenaWorkGroup_Tags (81.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	86.110s
...

@github-actions github-actions bot added service/athena Issues and PRs that pertain to the athena service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Aug 6, 2021
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Aug 6, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 8, 2021
ewbankkit
ewbankkit approved these changes Aug 8, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSAthenaWorkGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAthenaWorkGroup_ -timeout 180m
=== RUN   TestAccAWSAthenaWorkGroup_basic
=== PAUSE TestAccAWSAthenaWorkGroup_basic
=== RUN   TestAccAWSAthenaWorkGroup_disappears
=== PAUSE TestAccAWSAthenaWorkGroup_disappears
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy
=== RUN   TestAccAWSAthenaWorkGroup_Description
=== PAUSE TestAccAWSAthenaWorkGroup_Description
=== RUN   TestAccAWSAthenaWorkGroup_State
=== PAUSE TestAccAWSAthenaWorkGroup_State
=== RUN   TestAccAWSAthenaWorkGroup_ForceDestroy
=== PAUSE TestAccAWSAthenaWorkGroup_ForceDestroy
=== RUN   TestAccAWSAthenaWorkGroup_Tags
=== PAUSE TestAccAWSAthenaWorkGroup_Tags
=== CONT  TestAccAWSAthenaWorkGroup_basic
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled
=== CONT  TestAccAWSAthenaWorkGroup_State
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration
=== CONT  TestAccAWSAthenaWorkGroup_ForceDestroy
=== CONT  TestAccAWSAthenaWorkGroup_disappears
=== CONT  TestAccAWSAthenaWorkGroup_Tags
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery
=== CONT  TestAccAWSAthenaWorkGroup_Description
--- PASS: TestAccAWSAthenaWorkGroup_disappears (42.44s)
--- PASS: TestAccAWSAthenaWorkGroup_basic (58.65s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3 (58.99s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled (86.59s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled (91.07s)
--- PASS: TestAccAWSAthenaWorkGroup_ForceDestroy (91.42s)
--- PASS: TestAccAWSAthenaWorkGroup_Description (91.90s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration (91.94s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery (92.03s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms (93.52s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation (107.33s)
--- PASS: TestAccAWSAthenaWorkGroup_Tags (107.90s)
--- PASS: TestAccAWSAthenaWorkGroup_State (108.58s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy (112.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	116.407s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSAthenaWorkGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAthenaWorkGroup_ -timeout 180m
=== RUN   TestAccAWSAthenaWorkGroup_basic
=== PAUSE TestAccAWSAthenaWorkGroup_basic
=== RUN   TestAccAWSAthenaWorkGroup_disappears
=== PAUSE TestAccAWSAthenaWorkGroup_disappears
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled
=== RUN   TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy
=== PAUSE TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy
=== RUN   TestAccAWSAthenaWorkGroup_Description
=== PAUSE TestAccAWSAthenaWorkGroup_Description
=== RUN   TestAccAWSAthenaWorkGroup_State
=== PAUSE TestAccAWSAthenaWorkGroup_State
=== RUN   TestAccAWSAthenaWorkGroup_ForceDestroy
=== PAUSE TestAccAWSAthenaWorkGroup_ForceDestroy
=== RUN   TestAccAWSAthenaWorkGroup_Tags
=== PAUSE TestAccAWSAthenaWorkGroup_Tags
=== CONT  TestAccAWSAthenaWorkGroup_basic
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled
=== CONT  TestAccAWSAthenaWorkGroup_ForceDestroy
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy
=== CONT  TestAccAWSAthenaWorkGroup_Tags
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration
=== CONT  TestAccAWSAthenaWorkGroup_disappears
=== CONT  TestAccAWSAthenaWorkGroup_State
=== CONT  TestAccAWSAthenaWorkGroup_Description
=== CONT  TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled
--- PASS: TestAccAWSAthenaWorkGroup_disappears (50.60s)
--- PASS: TestAccAWSAthenaWorkGroup_basic (69.84s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3 (70.13s)
--- PASS: TestAccAWSAthenaWorkGroup_ForceDestroy (95.81s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_RequesterPaysEnabled (97.88s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration (98.86s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled (98.98s)
--- PASS: TestAccAWSAthenaWorkGroup_Description (99.01s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery (99.31s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms (100.48s)
--- PASS: TestAccAWSAthenaWorkGroup_Tags (113.38s)
--- PASS: TestAccAWSAthenaWorkGroup_State (115.26s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation_ForceDestroy (115.90s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation (116.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	125.648s

@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 50f31ec into hashicorp:main Aug 9, 2021
@github-actions github-actions bot added this to the v3.54.0 milestone Aug 9, 2021
@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/athena Issues and PRs that pertain to the athena service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.54.0
Development

Successfully merging this pull request may close these issues.

Support for RequesterPaysEnabled option in Athena work groups
3 participants
@drewmullen @ewbankkit @justinretzolk