Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_group argument to aws_elasticache_replication_group #20328

Closed
jamesglennan opened this issue Jul 27, 2021 · 4 comments · Fixed by #20406
Closed

Add user_group argument to aws_elasticache_replication_group #20328

jamesglennan opened this issue Jul 27, 2021 · 4 comments · Fixed by #20406
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service.
Milestone

Comments

@jamesglennan
Copy link

jamesglennan commented Jul 27, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Recently user and user group resources for elasticache were added to the terraform provider. However there is not currently a way to associate a user group with a replication group.

New or Affected Resource(s)

Impacted Existing Data Sources

  • aws_elasticache_replication_group: will have a new list of user_group_ids to associate user groups with the relevant replication group

Potential Terraform Configuration

resource "aws_elasticache_replication_group" "test" {
  replication_group_id          = test_replication_group
  replication_group_description = "test description"
  node_type                     = "cache.t3.small"
  port                          = 6379
  apply_immediately             = true
  auto_minor_version_upgrade    = false
  maintenance_window            = "tue:06:30-tue:07:30"
  snapshot_window               = "01:00-02:00"
  user_group_ids                = [aws_elasticache_user_group.test.id]
}

resource "aws_elasticache_user" "test" {
  user_id       = test_user_group
  user_name     = "default"
  access_string = "on ~app::* -@all +@read +@hash +@bitmap +@geo -setbit -bitfield -hset -hsetnx -hmset -hincrby -hincrbyfloat -hdel -bitop -geoadd -georadius -georadiusbymember"
  engine        = "REDIS"
  passwords     = ["password123456789"]
}
resource "aws_elasticache_user_group" "test" {
  user_group_id = test_user_group
  engine        = "REDIS"
  user_ids      = [aws_elasticache_user.test.user_id]
}

References

https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/Clusters.RBAC.html
https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_CreateReplicationGroup.html#API_CreateReplicationGroup_RequestParameters

@jamesglennan jamesglennan added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 27, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/elasticache Issues and PRs that pertain to the elasticache service. labels Jul 27, 2021
@jamesglennan
Copy link
Author

I currently have some code that I've been working on for this, so happy to take this on

@edbighead
Copy link

was very surprised we can add aws_elasticache_user_group but can not associate it, waiting for the PR to be merged

@YakDriver YakDriver self-assigned this Jan 26, 2022
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 26, 2022
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants