aws_storagegateway_smb_file_share: Add `bucket_region`, `oplocks_enabled` and `vpc_endpoint_dns_name` arguments #20234

sylr · 2021-07-19T13:12:51Z

Signed-off-by: Sylvain Rabot [email protected]

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Signed-off-by: Sylvain Rabot <[email protected]>

github-actions

Welcome @sylr 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

…dns_name'.

…lues to Create and Update APIs.

…ncrypted is true.

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_'        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewaySmbFileShare_ -timeout 180m
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== RUN   TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== RUN   TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== RUN   TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Tags
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Tags
=== RUN   TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== RUN   TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== RUN   TestAccAWSStorageGatewaySmbFileShare_audit
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_audit
=== RUN   TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== RUN   TestAccAWSStorageGatewaySmbFileShare_disappears
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_disappears
=== RUN   TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== CONT  TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_disappears
=== CONT  TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== CONT  TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== CONT  TestAccAWSStorageGatewaySmbFileShare_audit
=== CONT  TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Tags
=== CONT  TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== CONT  TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== CONT  TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== CONT  TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== CONT  TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== CONT  TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== CONT  TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
--- PASS: TestAccAWSStorageGatewaySmbFileShare_disappears (290.38s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (295.71s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (355.19s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled (394.93s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (403.38s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (405.57s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (411.19s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (414.45s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_audit (416.87s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_caseSensitivity (452.02s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_notificationPolicy (454.43s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (388.46s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_FileShareName (464.43s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_cacheAttributes (504.74s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration (508.07s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (299.05s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (337.63s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (964.80s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (1104.85s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_smb_acl (1131.78s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (1138.58s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (1238.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1244.543s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewaySmbFileShare_ -timeout 180m
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== RUN   TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== RUN   TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== RUN   TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Tags
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Tags
=== RUN   TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== RUN   TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== RUN   TestAccAWSStorageGatewaySmbFileShare_audit
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_audit
=== RUN   TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== RUN   TestAccAWSStorageGatewaySmbFileShare_disappears
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_disappears
=== RUN   TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== CONT  TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== CONT  TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== CONT  TestAccAWSStorageGatewaySmbFileShare_disappears
=== CONT  TestAccAWSStorageGatewaySmbFileShare_audit
=== CONT  TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== CONT  TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== CONT  TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== CONT  TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== CONT  TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== CONT  TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== CONT  TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Tags
=== CONT  TestAccAWSStorageGatewaySmbFileShare_AdminUserList
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/07/20 11:44:34 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 3003ef4c-9fe8-45e3-9a70-0daa65528a0a : RequestId: 3003ef4c-9fe8-45e3-9a70-0daa65528a0a
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "3003ef4c-9fe8-45e3-9a70-0daa65528a0a"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 3003ef4c-9fe8-45e3-9a70-0daa65528a0a : RequestId: 3003ef4c-9fe8-45e3-9a70-0daa65528a0a",
          RequestId: "3003ef4c-9fe8-45e3-9a70-0daa65528a0a"
        }
        
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/07/20 11:44:33 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 0a818014-9276-4a9a-8856-7e606bcc5109 : RequestId: 0a818014-9276-4a9a-8856-7e606bcc5109
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "0a818014-9276-4a9a-8856-7e606bcc5109"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 0a818014-9276-4a9a-8856-7e606bcc5109 : RequestId: 0a818014-9276-4a9a-8856-7e606bcc5109",
          RequestId: "0a818014-9276-4a9a-8856-7e606bcc5109"
        }
        
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ValidUserList
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/07/20 11:44:35 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 73cfd064-35c1-4caa-b9be-6d576d8e262c : RequestId: 73cfd064-35c1-4caa-b9be-6d576d8e262c
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "73cfd064-35c1-4caa-b9be-6d576d8e262c"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 73cfd064-35c1-4caa-b9be-6d576d8e262c : RequestId: 73cfd064-35c1-4caa-b9be-6d576d8e262c",
          RequestId: "73cfd064-35c1-4caa-b9be-6d576d8e262c"
        }
        
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/07/20 11:44:33 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 055fba3a-c448-4fc3-800d-2b4990a0e34f : RequestId: 055fba3a-c448-4fc3-800d-2b4990a0e34f
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "055fba3a-c448-4fc3-800d-2b4990a0e34f"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 055fba3a-c448-4fc3-800d-2b4990a0e34f : RequestId: 055fba3a-c448-4fc3-800d-2b4990a0e34f",
          RequestId: "055fba3a-c448-4fc3-800d-2b4990a0e34f"
        }
        
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_smb_acl
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/07/20 11:44:34 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 3ab94f33-bfd2-46b9-a9e6-4d08be793121 : RequestId: 3ab94f33-bfd2-46b9-a9e6-4d08be793121
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "3ab94f33-bfd2-46b9-a9e6-4d08be793121"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 3ab94f33-bfd2-46b9-a9e6-4d08be793121 : RequestId: 3ab94f33-bfd2-46b9-a9e6-4d08be793121",
          RequestId: "3ab94f33-bfd2-46b9-a9e6-4d08be793121"
        }
        
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
        
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (52.20s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (52.75s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (57.29s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (58.68s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_smb_acl (58.87s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_disappears (313.52s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (333.27s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (362.82s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (371.30s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (377.80s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (387.97s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (394.34s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (357.50s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_FileShareName (413.26s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_audit (417.83s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (423.80s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled (380.65s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration (441.59s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (447.01s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_notificationPolicy (451.45s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_caseSensitivity (467.84s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_cacheAttributes (472.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	476.226s

ewbankkit · 2021-07-20T17:10:40Z

@sylr Thanks for the contribution 🎉 👏.
I went ahead and changed vpc_endpoint to vpc_endpoint_dns_name to match the underlying AWS API field name.

sylr · 2021-07-20T18:09:54Z

Thank you @ewbankkit. It's really nice to have a responsive maintainer in front of you. Keep up the good work 👍

github-actions · 2021-07-22T22:51:54Z

This functionality has been released in v3.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2021-08-22T02:05:32Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Improve aws_storagegateway_smb_file_share

1c90d45

Signed-off-by: Sylvain Rabot <[email protected]>

github-actions bot reviewed Jul 19, 2021

View reviewed changes

ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 19, 2021

ewbankkit added 2 commits July 19, 2021 17:14

Add CHANGELOG entry.

40e6299

r/aws_storagegateway_smb_file_share: 'vpc_endpoint' -> 'vpc_endpoint_…

a1f6249

…dns_name'.

sylr force-pushed the improve-storagegateway-smb-file-share branch from 1c90d45 to e0f5030 Compare July 20, 2021 07:08

ewbankkit added 4 commits July 20, 2021 10:42

r/aws_storagegateway_smb_file_share: Use internal 'finder' package.

e91505d

r/aws_storagegateway_smb_file_share: Use 'composeConfig'.

ccf9abe

r/aws_storagegateway_smb_file_share: Always pass boolean attribute va…

00e8e8e

…lues to Create and Update APIs.

r/aws_storagegateway_smb_file_share: KMSKey can only be set when KMSE…

e2e2771

…ncrypted is true.

ewbankkit force-pushed the improve-storagegateway-smb-file-share branch from e0f5030 to e2e2771 Compare July 20, 2021 16:58

github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 20, 2021

ewbankkit approved these changes Jul 20, 2021

View reviewed changes

Fix terrafmt error.

51e4c95

ewbankkit changed the title ~~Improve aws_storagegateway_smb_file_share~~ aws_storagegateway_smb_file_share: Add bucket_region, oplocks_enabled and vpc_endpoint_dns_name arguments Jul 20, 2021

ewbankkit merged commit 60a86a2 into hashicorp:main Jul 20, 2021

github-actions bot added this to the v3.51.0 milestone Jul 20, 2021

This was referenced Aug 16, 2021

r/aws_glue_dev_endpoint: Acceptance test failure - TestAccGlueDevEndpoint_Basic #20563

Closed

r/aws_storagegateway_smb_file_share: Acceptance tests failing - 'InvalidGatewayRequestException: The specified gateway is out of date' #20557

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021

sylr deleted the improve-storagegateway-smb-file-share branch November 16, 2021 12:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

aws_storagegateway_smb_file_share: Add `bucket_region`, `oplocks_enabled` and `vpc_endpoint_dns_name` arguments #20234

aws_storagegateway_smb_file_share: Add `bucket_region`, `oplocks_enabled` and `vpc_endpoint_dns_name` arguments #20234

sylr commented Jul 19, 2021

github-actions bot left a comment

ewbankkit left a comment

ewbankkit commented Jul 20, 2021

sylr commented Jul 20, 2021

github-actions bot commented Jul 22, 2021

github-actions bot commented Aug 22, 2021

aws_storagegateway_smb_file_share: Add bucket_region, oplocks_enabled and vpc_endpoint_dns_name arguments #20234

aws_storagegateway_smb_file_share: Add bucket_region, oplocks_enabled and vpc_endpoint_dns_name arguments #20234

Conversation

sylr commented Jul 19, 2021

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Jul 20, 2021

sylr commented Jul 20, 2021

github-actions bot commented Jul 22, 2021

github-actions bot commented Aug 22, 2021

aws_storagegateway_smb_file_share: Add `bucket_region`, `oplocks_enabled` and `vpc_endpoint_dns_name` arguments #20234

aws_storagegateway_smb_file_share: Add `bucket_region`, `oplocks_enabled` and `vpc_endpoint_dns_name` arguments #20234