Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F data source aws appmesh virtualservice #19774

Merged
merged 8 commits into from
Jun 14, 2021
Merged

F data source aws appmesh virtualservice #19774

merged 8 commits into from
Jun 14, 2021

Conversation

philnichol
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17590

Output from acceptance testing:

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 10 -run=TestAccAWSAppmeshVirtualServiceDataSource_ -timeout=30m
=== RUN   TestAccAWSAppmeshVirtualServiceDataSource_virtualNode
=== PAUSE TestAccAWSAppmeshVirtualServiceDataSource_virtualNode
=== RUN   TestAccAWSAppmeshVirtualServiceDataSource_virtualRouter
=== PAUSE TestAccAWSAppmeshVirtualServiceDataSource_virtualRouter
=== CONT  TestAccAWSAppmeshVirtualServiceDataSource_virtualNode
=== CONT  TestAccAWSAppmeshVirtualServiceDataSource_virtualRouter
--- PASS: TestAccAWSAppmeshVirtualServiceDataSource_virtualNode (15.69s)
--- PASS: TestAccAWSAppmeshVirtualServiceDataSource_virtualRouter (16.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.608s

Thanks in advance for the review!

@philnichol philnichol requested review from ewbankkit and a team as code owners June 11, 2021 14:50
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jun 11, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 14, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSAppmesh'   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSAppmesh -timeout 180m
=== RUN   TestAccDataSourceAWSAppmeshMesh_basic
=== PAUSE TestAccDataSourceAWSAppmeshMesh_basic
=== RUN   TestAccDataSourceAWSAppmeshMesh_meshOwner
=== PAUSE TestAccDataSourceAWSAppmeshMesh_meshOwner
=== RUN   TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== PAUSE TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== RUN   TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== PAUSE TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== RUN   TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== PAUSE TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== CONT  TestAccDataSourceAWSAppmeshMesh_basic
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== CONT  TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== CONT  TestAccDataSourceAWSAppmeshMesh_meshOwner
--- PASS: TestAccDataSourceAWSAppmeshMesh_basic (15.74s)
--- PASS: TestAccDataSourceAWSAppmeshMesh_meshOwner (15.76s)
--- PASS: TestAccDataSourceAWSAppmeshMesh_specAndTagsSet (15.94s)
--- PASS: TestAccDataSourceAWSAppmeshVirtualService_virtualRouter (20.17s)
--- PASS: TestAccDataSourceAWSAppmeshVirtualService_virtualNode (21.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.400s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSAppmesh' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSAppmesh -timeout 180m
=== RUN   TestAccDataSourceAWSAppmeshMesh_basic
=== PAUSE TestAccDataSourceAWSAppmeshMesh_basic
=== RUN   TestAccDataSourceAWSAppmeshMesh_meshOwner
=== PAUSE TestAccDataSourceAWSAppmeshMesh_meshOwner
=== RUN   TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== PAUSE TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== RUN   TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== PAUSE TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== RUN   TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== PAUSE TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== CONT  TestAccDataSourceAWSAppmeshMesh_basic
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== CONT  TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== CONT  TestAccDataSourceAWSAppmeshMesh_meshOwner
=== CONT  TestAccDataSourceAWSAppmeshMesh_basic
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccDataSourceAWSAppmeshMesh_basic (1.41s)
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualNode
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccDataSourceAWSAppmeshVirtualService_virtualNode (1.41s)
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccDataSourceAWSAppmeshVirtualService_virtualRouter (1.41s)
=== CONT  TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccDataSourceAWSAppmeshMesh_specAndTagsSet (1.41s)
=== CONT  TestAccDataSourceAWSAppmeshMesh_meshOwner
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccDataSourceAWSAppmeshMesh_meshOwner (1.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.685s

@ewbankkit
Copy link
Contributor

@philnichol Thanks for the contribution 🎉 👏.
All looks great.
I tweaked the acceptance tests names slightly (#17847).

@ewbankkit ewbankkit merged commit fa94556 into hashicorp:main Jun 14, 2021
@github-actions github-actions bot added this to the v3.46.0 milestone Jun 14, 2021
@philnichol philnichol deleted the f-data-source-aws-appmesh-virtualservice branch June 15, 2021 19:07
@github-actions
Copy link

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appmesh Issues and PRs that pertain to the appmesh service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants