Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/glue_catalog_database - set location_uri to computed #19743

Merged

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 9, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19585

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (23.16s)
--- PASS: TestAccAWSGlueCatalogDatabase_targetDatabase (62.40s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (77.78s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner June 9, 2021 22:43
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Jun 9, 2021
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 9, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogDatabase_ -timeout 180m
=== RUN   TestAccAWSGlueCatalogDatabase_full
=== PAUSE TestAccAWSGlueCatalogDatabase_full
=== RUN   TestAccAWSGlueCatalogDatabase_targetDatabase
=== PAUSE TestAccAWSGlueCatalogDatabase_targetDatabase
=== RUN   TestAccAWSGlueCatalogDatabase_disappears
=== PAUSE TestAccAWSGlueCatalogDatabase_disappears
=== CONT  TestAccAWSGlueCatalogDatabase_full
=== CONT  TestAccAWSGlueCatalogDatabase_disappears
=== CONT  TestAccAWSGlueCatalogDatabase_targetDatabase
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (10.19s)
--- PASS: TestAccAWSGlueCatalogDatabase_targetDatabase (26.29s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (30.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.179s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogDatabase_ -timeout 180m
=== RUN   TestAccAWSGlueCatalogDatabase_full
=== PAUSE TestAccAWSGlueCatalogDatabase_full
=== RUN   TestAccAWSGlueCatalogDatabase_targetDatabase
=== PAUSE TestAccAWSGlueCatalogDatabase_targetDatabase
=== RUN   TestAccAWSGlueCatalogDatabase_disappears
=== PAUSE TestAccAWSGlueCatalogDatabase_disappears
=== CONT  TestAccAWSGlueCatalogDatabase_full
=== CONT  TestAccAWSGlueCatalogDatabase_disappears
=== CONT  TestAccAWSGlueCatalogDatabase_targetDatabase
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (13.08s)
--- PASS: TestAccAWSGlueCatalogDatabase_targetDatabase (32.19s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (40.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.668s

@ewbankkit ewbankkit merged commit 72df092 into hashicorp:main Jun 22, 2021
@github-actions github-actions bot added this to the v3.47.0 milestone Jun 22, 2021
@DrFaust92 DrFaust92 deleted the r/glue_catalog_database_target_uri branch June 22, 2021 19:03
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_glue_catalog_database with target_database but without location_uri stays permanently out of sync
2 participants