Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_globalaccelerator_accelerator: Add data globalaccelerator accelerator #19647

Merged
merged 8 commits into from
Jun 9, 2021
Merged

d/aws_globalaccelerator_accelerator: Add data globalaccelerator accelerator #19647

merged 8 commits into from
Jun 9, 2021

Conversation

kumadee
Copy link
Contributor

@kumadee kumadee commented Jun 3, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13202

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSDataGlobalAcceleratorAccelerator_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataGlobalAcceleratorAccelerator_basic -timeout 180m
=== RUN   TestAccAWSDataGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccAWSDataGlobalAcceleratorAccelerator_basic
=== CONT  TestAccAWSDataGlobalAcceleratorAccelerator_basic
--- PASS: TestAccAWSDataGlobalAcceleratorAccelerator_basic (147.01s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       147.095s

* d/aws_globalaccelerator_accelerator: Add new datasource and add documentation
@kumadee kumadee requested review from ewbankkit and a team as code owners June 3, 2021 16:17
@ghost ghost added size/L Managed by automation to categorize the size of a PR. labels Jun 3, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 3, 2021
@kumadee kumadee changed the title Add data globalaccelerator accelerator d/aws_globalaccelerator_accelerator: Add data globalaccelerator accelerator Jun 3, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 9, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataGlobalAcceleratorAccelerator_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataGlobalAcceleratorAccelerator_ -timeout 180m
=== RUN   TestAccAWSDataGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccAWSDataGlobalAcceleratorAccelerator_basic
=== CONT  TestAccAWSDataGlobalAcceleratorAccelerator_basic
--- PASS: TestAccAWSDataGlobalAcceleratorAccelerator_basic (193.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	197.167s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataGlobalAcceleratorAccelerator_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataGlobalAcceleratorAccelerator_ -timeout 180m
=== RUN   TestAccAWSDataGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccAWSDataGlobalAcceleratorAccelerator_basic
=== CONT  TestAccAWSDataGlobalAcceleratorAccelerator_basic
    resource_aws_globalaccelerator_accelerator_test.go:372: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://globalaccelerator.us-gov-west-1.amazonaws.com/": dial tcp: lookup globalaccelerator.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSDataGlobalAcceleratorAccelerator_basic (24.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	27.518s

@ewbankkit
Copy link
Contributor

@kumadee Thanks for the contribution 🎉 👏.
I pushed a couple of minor additions:

  • Added a PreCheck function to ensure that the acceptance test is correctly skipped in AWS GovCloud
  • Renamed the Global Accelerator resource documentation pages from *.markdown to *.html.markdown to fix the link check error

@ewbankkit ewbankkit merged commit 3e886e7 into hashicorp:main Jun 9, 2021
@github-actions github-actions bot added this to the v3.45.0 milestone Jun 9, 2021
@kumadee kumadee deleted the add-data-globalaccelerator-accelerator branch June 9, 2021 16:39
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Global Accelerator data source
2 participants