Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data source to list MSK nodes for OpenMonitoring #19638

Closed
shousper opened this issue Jun 3, 2021 · 3 comments · Fixed by #20615
Closed

Data source to list MSK nodes for OpenMonitoring #19638

shousper opened this issue Jun 3, 2021 · 3 comments · Fixed by #20615
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/kafka Issues and PRs that pertain to the kafka service.
Milestone

Comments

@shousper
Copy link

shousper commented Jun 3, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In order to create a Prometheus scrape configuration for the MSK nodes, we need to be able to get a list of all the broker nodes (not just the bootstrap set). This could be done via the ListNodes API from the AWS SDK, per the AWS docs

New or Affected Resource(s)

  • aws_msk_nodes - to provide complete node list.

Potential Terraform Configuration

data "aws_msk_nodes" "example" {
  cluster_name = "example"
}

References

@shousper shousper added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 3, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/kafka Issues and PRs that pertain to the kafka service. labels Jun 3, 2021
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 3, 2021
@AlbertoPeon
Copy link

This would be great to have!

Basically, changes that are required for each Kafka broker (e.g. open monitoring, network rules, etc) cannot be done through Terraform.

Additionally, the fact that BoostrapServers yield a different list of brokers each time (when # of brokers > 3) causes Terraform to make pointless changes in each run.

@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/kafka Issues and PRs that pertain to the kafka service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants