Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Amazon Location Service #19629

Closed
pocket7878 opened this issue Jun 2, 2021 · 5 comments · Fixed by #26526
Closed

Add Support for Amazon Location Service #19629

pocket7878 opened this issue Jun 2, 2021 · 5 comments · Fixed by #26526
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS.
Milestone

Comments

@pocket7878
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Amazon Location Service provides affordable data, tracking and geofencing capabilities, and native integrations with AWS services, so you can create sophisticated location-enabled applications quickly, without the high cost of custom development. You retain control of your location data with Amazon Location, and you can combine proprietary data with data from the service. Amazon Location provides cost-effective location-based services (LBS) using high-quality data from global, trusted providers Esri and HERE.

New or Affected Resource(s)

  • aws_location_tracker
  • aws_location_tracker_association
  • aws_location_map
  • aws_location_place_index
  • aws_location_route_calculator
  • aws_location_geofence_collection

Potential Terraform Configuration

/* Geofence */
resource "aws_location_geofence_collection" "geofence_collection" {
  name = "sample_geofence_collection"
  description = "just a sample"
  kms_key_id = "xxxxxxxxxxxxxxxx:yyyyyyyyyyyy:zzzzzz"
  pricing_plan {
    plan = "RequestBasedUsage"
    data_source = "Esri"
  }
  tags = {
    Name = "Sample Amazon Location Geofence Collection"
  }
}

/* Tracker */
resource "aws_location_tracker" "tracker" {
  name = "sample_tracker"
  description = "just a sample"
  pricing_plan "RequestBasedUsage"
  pricing_data_source = "Ersi"
  kms_key_id = "xxxxxxxxxxxxxxxx:yyyyyyyyyyyy:zzzzzz"
  tags = {
    Name = "Sample Amazon Location Tracker"
  }
}

resource "aws_location_tracker_association" "tracker_association" {
  tracker_name = "sample_tracker"
  consumer_arn = amazon_location_geofence_collection.geofence_collection.arn
}

/* Map */
resource "aws_location_map" "sample_map" {
  name = "sample"
  description = "just a sample"
  pricing_plan "RequestBasedUsage"
  map_configuration {
    style = "RasterEsriImagery"
  }
  tags = {
    Name = "Sample Amazon Location Map"
  }
}

/* Places */
resource "aws_location_place_index" "sample_place_index" {
  name = "sample place index"
  description = "just a sample"
  pricing_plan "RequestBasedUsage"
  data_source = "Esri"
  data_source_configuration {
    intended_use = "SingleUse"
  }
  map_configuration {
    style = "RasterEsriImagery"
  }
  tags = {
    Name = "Sample Amazon Location Place Index"
  }
}

/* Route */
resource "aws_location_route_calculator" "sample_route_calculator" {
  name = "sample place index"
  description = "just a sample"
  pricing_plan "RequestBasedUsage"
  data_source = "Esri"
  tags = {
    Name = "Sample Amazon Location Route Calculator"
  }
}

References

@pocket7878 pocket7878 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 2, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 2, 2021
@gdavison gdavison added new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 5, 2021
@kamilturek
Copy link
Collaborator

I'll give it a try soon.

@kamilturek
Copy link
Collaborator

kamilturek commented May 7, 2022

Progress Checklist

Resources

  • aws_location_map
  • aws_location_tracker
  • aws_location_tracker_association
  • aws_location_place_index
  • aws_location_route_calculator
  • aws_location_geofence_collection
  • aws_location_geofence (skipped for now)

Data Sources

  • aws_location_map
  • aws_location_tracker
  • aws_location_tracker_association
  • aws_location_tracker_associations
  • aws_location_place_index
  • aws_location_route_calculator
  • aws_location_geofence_collection
  • aws_location_geofence (skipped for now)
  • aws_location_geofences (skipped for now)

Sweepers

  • aws_location_map
  • aws_location_tracker
  • aws_location_tracker_association
  • aws_location_place_index
  • aws_location_route_calculator
  • aws_location_geofence_collection
  • aws_location_geofence (skipped for now)

@kamilturek
Copy link
Collaborator

kamilturek commented Aug 6, 2022

The Geofence resource has a quite specific form.
https://docs.aws.amazon.com/location/latest/APIReference/API_PutGeofence.html

I might come up with a schema for that but I'd rather hear an opinion/proposal from a person that actively uses geofences on how the schema should look like. Therefore, I vote to skip these resources/data sources for now. We can come back to that when there is such a need.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants