Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_synthetics_canary: fix minimum timeout_in_seconds #19515

Merged
merged 1 commit into from
May 25, 2021
Merged

resource/aws_synthetics_canary: fix minimum timeout_in_seconds #19515

merged 1 commit into from
May 25, 2021

Conversation

Kostavro
Copy link
Contributor

@Kostavro Kostavro commented May 25, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19289

Output from acceptance testing:

-

@Kostavro Kostavro requested a review from a team as a code owner May 25, 2021 14:54
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label May 25, 2021
@github-actions github-actions bot added service/synthetics Issues and PRs that pertain to the synthetics service. needs-triage Waiting for first response or review from a maintainer. labels May 25, 2021
@Kostavro Kostavro changed the title [WIP] fix minimum timeout_in_seconds fix minimum timeout_in_seconds May 25, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Kostavro 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@Kostavro Kostavro changed the title fix minimum timeout_in_seconds resource/aws_synthetics_canary: fix minimum timeout_in_seconds May 25, 2021
.changelog/19515.txt Outdated Show resolved Hide resolved
@ewbankkit
Copy link
Contributor

@Kostavro Thanks for the contribution 🎉 👏.
Everything looks to be in great shape - I just made a minor suggestion on the CHANGELOG entry.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 25, 2021
@Kostavro
Copy link
Contributor Author

Thanks @ewbankkit . I changed the changelog text as per your suggestion.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit merged commit 5e82a52 into hashicorp:main May 25, 2021
@github-actions github-actions bot added this to the v3.43.0 milestone May 25, 2021
@Kostavro Kostavro deleted the b-synthetics-canary-minimum-timeout branch May 25, 2021 17:58
@Kostavro Kostavro restored the b-synthetics-canary-minimum-timeout branch May 25, 2021 17:58
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/synthetics Issues and PRs that pertain to the synthetics service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Cloudwatch Synthetic canary minimum timeout value incorrect
2 participants