Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reapplying same change rds-instance.aws_db_parameter_group #1927

Closed
hashibot opened this issue Oct 17, 2017 · 5 comments
Closed

reapplying same change rds-instance.aws_db_parameter_group #1927

hashibot opened this issue Oct 17, 2017 · 5 comments
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@hashibot
Copy link

This issue was originally opened by @apremalal as hashicorp/terraform#16307. It was migrated here as a result of the provider split. The original body of the issue is below.


Terraform Version

v0.10.6

Terraform Configuration Files

resource "aws_db_parameter_group" "mysql" {
  provider = "aws.worker"
  name   = "mydb"
  family = "mysql5.7"

  parameter {
    name  = "explicit_defaults_for_timestamp"
    value = false
    apply_method = "pending-reboot"
  }
}

Debug Output

~ module.sg.module.rds-instance.aws_db_parameter_group.mysql
      parameter.#:                       "2" => "1"
      parameter.2072808627.apply_method: "pending-reboot" => "pending-reboot"
      parameter.2072808627.name:         "explicit_defaults_for_timestamp" => "explicit_defaults_for_timestamp"
      parameter.2072808627.value:        "0" => "0"
      parameter.4289290085.apply_method: "immediate" => ""
      parameter.4289290085.name:         "autocommit" => ""
      parameter.4289290085.value:        "1" => ""

Expected Behavior

resource modification should be prompted only once

Actual Behavior

Modification plan in debug output always prompted

Steps to Reproduce

Please list the full steps required to reproduce the issue, for example:

  1. terraform init
  2. terraform apply
@hashibot hashibot added the bug Addresses a defect in current functionality. label Oct 17, 2017
@koooge
Copy link
Contributor

koooge commented Nov 28, 2017

It seems log_output causes same issue. (Terraform v0.11.0 + provider.aws v1.3.1)

my setting

resource "aws_db_parameter_group" "foo" {
  name = "bar"
  family = "mysql5.7"

  parameter {
    name = "log_output"
    value = "TABLE"
    apply_method = "immediate"
  }

output: terraform (re)apply shows diff

parameter.2564018806.apply_method: "" => "immediate"
parameter.2564018806.name:         "" => "log_output"
parameter.2564018806.value:        "" => "TABLE"

related? #1617, #593

@kendrickm
Copy link

I'm having the same issue on several db_parameter_group objects all for the same option, "checkpoint_completion_target"

It doens't store it in the state file so every run it attempts to set it again.

@radeksimko radeksimko added the service/rds Issues and PRs that pertain to the rds service. label Jan 28, 2018
@apremalal
Copy link

Is there any update on this issues?

@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Aug 24, 2020
@ghost
Copy link

ghost commented Oct 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

5 participants