Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/resource aws datasync location s3 storage class #19190

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented May 1, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19191.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDataSyncLocationS3_'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationS3_ -timeout 180m
=== RUN   TestAccAWSDataSyncLocationS3_basic
=== PAUSE TestAccAWSDataSyncLocationS3_basic
=== RUN   TestAccAWSDataSyncLocationS3_storageclass
=== PAUSE TestAccAWSDataSyncLocationS3_storageclass
=== RUN   TestAccAWSDataSyncLocationS3_disappears
=== PAUSE TestAccAWSDataSyncLocationS3_disappears
=== RUN   TestAccAWSDataSyncLocationS3_Tags
=== PAUSE TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_basic
=== CONT  TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_storageclass
=== CONT  TestAccAWSDataSyncLocationS3_disappears
--- PASS: TestAccAWSDataSyncLocationS3_storageclass (79.54s)
--- PASS: TestAccAWSDataSyncLocationS3_disappears (84.24s)
--- PASS: TestAccAWSDataSyncLocationS3_basic (98.31s)
--- PASS: TestAccAWSDataSyncLocationS3_Tags (214.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	217.450s
...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner May 1, 2021 12:52
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/datasync Issues and PRs that pertain to the datasync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 1, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 1, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 3, 2021
@nikhil-goenka
Copy link
Contributor Author

make testacc TESTARGS='-run=TestAccAWSDataSyncLocationS3_'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationS3_ -timeout 180m
=== RUN TestAccAWSDataSyncLocationS3_basic
=== PAUSE TestAccAWSDataSyncLocationS3_basic
=== RUN TestAccAWSDataSyncLocationS3_storageclass
=== PAUSE TestAccAWSDataSyncLocationS3_storageclass
=== RUN TestAccAWSDataSyncLocationS3_disappears
=== PAUSE TestAccAWSDataSyncLocationS3_disappears
=== RUN TestAccAWSDataSyncLocationS3_Tags
=== PAUSE TestAccAWSDataSyncLocationS3_Tags
=== CONT TestAccAWSDataSyncLocationS3_basic
=== CONT TestAccAWSDataSyncLocationS3_Tags
=== CONT TestAccAWSDataSyncLocationS3_storageclass
=== CONT TestAccAWSDataSyncLocationS3_disappears
--- PASS: TestAccAWSDataSyncLocationS3_storageclass (83.56s)
--- PASS: TestAccAWSDataSyncLocationS3_disappears (84.30s)
--- PASS: TestAccAWSDataSyncLocationS3_basic (91.46s)
--- PASS: TestAccAWSDataSyncLocationS3_Tags (225.12s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 231.204s

@ewbankkit ewbankkit self-assigned this May 4, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncLocationS3_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationS3_ -timeout 180m
=== RUN   TestAccAWSDataSyncLocationS3_basic
=== PAUSE TestAccAWSDataSyncLocationS3_basic
=== RUN   TestAccAWSDataSyncLocationS3_storageclass
=== PAUSE TestAccAWSDataSyncLocationS3_storageclass
=== RUN   TestAccAWSDataSyncLocationS3_disappears
=== PAUSE TestAccAWSDataSyncLocationS3_disappears
=== RUN   TestAccAWSDataSyncLocationS3_Tags
=== PAUSE TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_basic
=== CONT  TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_disappears
=== CONT  TestAccAWSDataSyncLocationS3_storageclass
--- PASS: TestAccAWSDataSyncLocationS3_storageclass (28.78s)
--- PASS: TestAccAWSDataSyncLocationS3_disappears (37.82s)
--- PASS: TestAccAWSDataSyncLocationS3_basic (45.48s)
--- PASS: TestAccAWSDataSyncLocationS3_Tags (76.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	80.471s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncLocationS3_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationS3_ -timeout 180m
=== RUN   TestAccAWSDataSyncLocationS3_basic
=== PAUSE TestAccAWSDataSyncLocationS3_basic
=== RUN   TestAccAWSDataSyncLocationS3_storageclass
=== PAUSE TestAccAWSDataSyncLocationS3_storageclass
=== RUN   TestAccAWSDataSyncLocationS3_disappears
=== PAUSE TestAccAWSDataSyncLocationS3_disappears
=== RUN   TestAccAWSDataSyncLocationS3_Tags
=== PAUSE TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_basic
=== CONT  TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_disappears
=== CONT  TestAccAWSDataSyncLocationS3_storageclass
--- PASS: TestAccAWSDataSyncLocationS3_storageclass (33.34s)
--- PASS: TestAccAWSDataSyncLocationS3_disappears (37.04s)
--- PASS: TestAccAWSDataSyncLocationS3_basic (49.82s)
--- PASS: TestAccAWSDataSyncLocationS3_Tags (89.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	91.949s

@ewbankkit ewbankkit merged commit e97a6cd into hashicorp:main May 4, 2021
@github-actions github-actions bot added this to the v3.39.0 milestone May 4, 2021
@nikhil-goenka nikhil-goenka deleted the f/resource_aws_datasync_location_s3_storage_class branch May 4, 2021 16:40
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/datasync Issues and PRs that pertain to the datasync service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage class support for aws_datasync_location_s3
2 participants