New resource for Macie2 Classification Job

[coderGo93]

Added a new resource, docs and tests for Macie Classification Job called aws_macie2_classification_job

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13432

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsMacie2ClassificationJob_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsMacie2ClassificationJob_ -timeout 180m
=== RUN   TestAccAwsMacie2ClassificationJob_Name_Generated
--- PASS: TestAccAwsMacie2ClassificationJob_Name_Generated (23.45s)
=== RUN   TestAccAwsMacie2ClassificationJob_NamePrefix
--- PASS: TestAccAwsMacie2ClassificationJob_NamePrefix (21.99s)
=== RUN   TestAccAwsMacie2ClassificationJob_complete
--- PASS: TestAccAwsMacie2ClassificationJob_complete (36.43s)
=== RUN   TestAccAwsMacie2ClassificationJob_WithTags
--- PASS: TestAccAwsMacie2ClassificationJob_WithTags (37.08s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       119.004s

...

[gdavison]

I have a number of suggestions, @coderGo93. Please also include a CHANGELOG entry file.

[gdavison]

A few more changes to make and some left from the previous review

[gdavison]

We're getting there. I have a few additional changes and a few left over from previous reviews.

Also, take a look at https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/running-and-writing-acceptance-tests.md#acceptance-test-concurrency. Because Macie can be either enabled or disabled, we can only run one Macie test at a time. Take a look at, e.g. https://github.com/hashicorp/terraform-provider-aws/blob/main/aws/resource_aws_guardduty_test.go for examples.

[gdavison]

Looking good. One last change for the acceptance tests.

[gdavison]

Looks good to me 🚀

--- PASS: TestAccAWSMacie2_serial (257.93s)
--- PASS: TestAccAWSMacie2_serial/Account (91.46s)
--- PASS: TestAccAWSMacie2_serial/Account/finding_and_status (24.43s)
--- PASS: TestAccAWSMacie2_serial/Account/disappears (9.26s)
--- PASS: TestAccAWSMacie2_serial/Account/basic (12.62s)
--- PASS: TestAccAWSMacie2_serial/Account/finding_publishing_frequency (22.90s)
--- PASS: TestAccAWSMacie2_serial/Account/status (22.25s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob (166.48s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/basic (19.51s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/name_generated (18.82s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/name_prefix (17.74s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/disappears (16.34s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/status (31.40s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/complete (31.99s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/tags (30.68s)

[ghost]

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.