CloudTrail support for Advanced Event Selectors

[luisrussi]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

From the documentation, I can see how to deploy a CloudTrail with basic data event selector, but I was not able to deploy an advanced data event selector.
Is this a valid request? If not, can you point me to the documentation, please?

New or Affected Resource(s)

• aws_cloudtrail

Potential Terraform Configuration

resource "aws_cloudtrail" "event-trail" {
  # ... trail configuration ...

  advanced_event_selector {
    name      = var.name
    field_selectors = [ 
        'Field': 'string',
        'Equals': [
            'string',
        ],
        'StartsWith': [
            'string',
        ],
        'EndsWith': [
            'string',
        ],
        'NotEquals': [
            'string',
        ],
        'NotStartsWith': [
            'string',
        ],
        'NotEndsWith': [
            'string',
        ]
    ]
    }
}

References

I haven't found a related issue here (maybe I missed it, sorry for that!), but I can add:
AWS docs
Boto3 docs

[YakDriver]

@luisrussi Thanks for raising this enhancement! I personally think that given the importance of security, this feature would be very useful. I don't see another related issue or PR. I've also verified nothing in the code refers to AdvancedEventSelector or AdvancedFieldSelector. If the capability existed, both of these would be required.

If enough people express interest, we will be able to take this on. Or, if someone from the community wants to create a PR, we can take a look.

Docs for future travelers:

• https://docs.aws.amazon.com/sdk-for-go/api/service/cloudtrail/#AdvancedEventSelector
• https://docs.aws.amazon.com/sdk-for-go/api/service/cloudtrail/#AdvancedFieldSelector
• https://docs.aws.amazon.com/sdk-for-go/api/service/cloudtrail/#CloudTrail.PutEventSelectors
• https://docs.aws.amazon.com/sdk-for-go/api/service/cloudtrail/#PutEventSelectorsInput
• https://docs.aws.amazon.com/sdk-for-go/api/service/cloudtrail/#PutEventSelectorsOutput
• https://docs.aws.amazon.com/sdk-for-go/api/service/cloudtrail/#InvalidEventSelectorsException
• https://docs.aws.amazon.com/sdk-for-go/api/service/cloudtrail/#GetEventSelectorsInput
• https://docs.aws.amazon.com/sdk-for-go/api/service/cloudtrail/#GetEventSelectorsOutput
• https://docs.aws.amazon.com/sdk-for-go/api/service/cloudtrail/#DataResource
• https://docs.aws.amazon.com/awscloudtrail/latest/userguide/logging-data-events-with-cloudtrail.html

[luisrussi]

Hi @YakDriver , how are you doing?
I will take the opportunity to understand the Terraform provider code (and also Go) and adventure myself with this addition. I hope I can create a PR soon :D

[github-actions]

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.