Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/db_parameter_group: Allow mixed case parameter values #18818

Merged
merged 13 commits into from
Aug 18, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Apr 13, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18815
Closes #18035
Closes #14970

Output from acceptance testing (commercial):

--- PASS: TestAccAWSDBClusterParameterGroup_disappears (24.57s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (30.10s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (34.03s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (35.44s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (39.03s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (39.24s)
--- PASS: TestAccAWSDBClusterParameterGroup_only (43.86s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (61.00s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (65.69s)
--- PASS: TestAccAWSDBParameterGroup_caseWithMixedParameters (41.65s)
--- PASS: TestAccAWSDBClusterParameterGroup_updateParameters (69.36s)
--- PASS: TestAccAWSDBParameterGroup_caseParameters (75.95s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (86.63s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (89.44s)
--- PASS: TestAccAWSDBParameterGroup_Only (89.52s)
--- PASS: TestAccAWSDBParameterGroup_updateParameters (92.44s)
--- PASS: TestAccAWSDBParameterGroup_limit (100.61s)
--- PASS: TestAccAWSDBParameterGroup_basic (106.13s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (131.37s)
--- PASS: TestAccAWSDBParameterGroup_Disappears (137.29s)
--- PASS: TestAccAWSDBClusterParameterGroup_caseParameters (150.17s)

GovCloud testing:

--- PASS: TestAccAWSDBParameterGroup_Only (24.39s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (36.61s)
--- PASS: TestAccAWSDBClusterParameterGroup_disappears (43.71s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (52.04s)
--- PASS: TestAccAWSDBClusterParameterGroup_caseParameters (52.81s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (58.08s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (61.52s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (62.22s)
--- PASS: TestAccAWSDBParameterGroup_caseWithMixedParameters (64.79s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (68.31s)
--- PASS: TestAccAWSDBParameterGroup_Disappears (69.34s)
--- PASS: TestAccAWSDBClusterParameterGroup_updateParameters (72.36s)
--- PASS: TestAccAWSDBClusterParameterGroup_only (74.65s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (51.50s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (80.03s)
--- PASS: TestAccAWSDBParameterGroup_caseParameters (85.01s)
--- PASS: TestAccAWSDBParameterGroup_limit (90.26s)
--- PASS: TestAccAWSDBParameterGroup_basic (92.20s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (98.36s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (111.28s)
--- PASS: TestAccAWSDBParameterGroup_updateParameters (116.00s)

@YakDriver YakDriver requested a review from a team as a code owner April 13, 2021 13:54
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 13, 2021
@YakDriver YakDriver changed the title r/db_parameter_group: Allow mixes case parameter values r/db_parameter_group: Allow mixed case parameter values Apr 13, 2021
@ewbankkit
Copy link
Contributor

As parameter.name is now stored in state as lowercase, do you want to add a test with an upper (or mixed) case parameter name?
There's no risk of existing configurations that had the parameter.value persisted in state as lowercase and parameter.name in original case now showing a diff, correct?

@YakDriver YakDriver force-pushed the b-rds-cluster-param-group-case branch from fa29a06 to c840197 Compare August 17, 2021 16:32
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Aug 17, 2021
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 17, 2021
@YakDriver
Copy link
Member Author

Acceptance tests on GovCloud:

--- PASS: TestAccAWSDBParameterGroup_Disappears (18.94s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (23.01s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (23.13s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (27.10s)
--- PASS: TestAccAWSDBParameterGroup_caseWithMixedParameters (35.29s)
--- PASS: TestAccAWSDBParameterGroup_Only (37.17s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (38.01s)
--- PASS: TestAccAWSDBParameterGroup_caseParameters (44.69s)
--- PASS: TestAccAWSDBParameterGroup_updateParameters (52.25s)
--- PASS: TestAccAWSDBParameterGroup_limit (60.44s)
--- PASS: TestAccAWSDBParameterGroup_basic (66.52s)

Acceptance tests on us-west-2:

--- PASS: TestAccAWSDBParameterGroup_Disappears (15.79s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (21.92s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (24.27s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (25.82s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (26.50s)
--- PASS: TestAccAWSDBParameterGroup_Only (28.42s)
--- PASS: TestAccAWSDBParameterGroup_caseWithMixedParameters (37.80s)
--- PASS: TestAccAWSDBParameterGroup_caseParameters (39.85s)
--- PASS: TestAccAWSDBParameterGroup_updateParameters (49.48s)
--- PASS: TestAccAWSDBParameterGroup_limit (59.64s)
--- PASS: TestAccAWSDBParameterGroup_basic (61.86s)

@YakDriver YakDriver added this to the v3.55.0 milestone Aug 18, 2021
@YakDriver YakDriver merged commit 552ec3b into main Aug 18, 2021
@YakDriver YakDriver deleted the b-rds-cluster-param-group-case branch August 18, 2021 01:17
github-actions bot pushed a commit that referenced this pull request Aug 18, 2021
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants