r/codepipeline - add validations

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodePipeline_'
--- PASS: TestAccAWSCodePipeline_disappears (75.33s)
--- PASS: TestAccAWSCodePipeline_WithNamespace (82.47s)
--- PASS: TestAccAWSCodePipeline_emptyStageArtifacts (86.13s)
--- PASS: TestAccAWSCodePipeline_multiregion_basic (91.90s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (95.76s)
--- PASS: TestAccAWSCodePipeline_multiregion_Update (144.19s)
--- PASS: TestAccAWSCodePipeline_basic (162.54s)
--- PASS: TestAccAWSCodePipeline_tags (203.20s)
--- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (213.84s)

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccCodePipeline_ PKG=codepipeline
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codepipeline/... -v -count 1 -parallel 20 -run='TestAccCodePipeline_' -timeout 180m
=== RUN   TestAccCodePipeline_basic
=== PAUSE TestAccCodePipeline_basic
=== RUN   TestAccCodePipeline_disappears
=== PAUSE TestAccCodePipeline_disappears
=== RUN   TestAccCodePipeline_emptyStageArtifacts
=== PAUSE TestAccCodePipeline_emptyStageArtifacts
=== RUN   TestAccCodePipeline_deployWithServiceRole
=== PAUSE TestAccCodePipeline_deployWithServiceRole
=== RUN   TestAccCodePipeline_tags
=== PAUSE TestAccCodePipeline_tags
=== RUN   TestAccCodePipeline_MultiRegion_basic
=== PAUSE TestAccCodePipeline_MultiRegion_basic
=== RUN   TestAccCodePipeline_MultiRegion_update
=== PAUSE TestAccCodePipeline_MultiRegion_update
=== RUN   TestAccCodePipeline_MultiRegion_convertSingleRegion
=== PAUSE TestAccCodePipeline_MultiRegion_convertSingleRegion
=== RUN   TestAccCodePipeline_withNamespace
=== PAUSE TestAccCodePipeline_withNamespace
=== RUN   TestAccCodePipeline_withGitHubV1SourceAction
=== PAUSE TestAccCodePipeline_withGitHubV1SourceAction
=== CONT  TestAccCodePipeline_basic
=== CONT  TestAccCodePipeline_MultiRegion_update
=== CONT  TestAccCodePipeline_emptyStageArtifacts
=== CONT  TestAccCodePipeline_deployWithServiceRole
=== CONT  TestAccCodePipeline_tags
=== CONT  TestAccCodePipeline_withGitHubV1SourceAction
=== CONT  TestAccCodePipeline_disappears
=== CONT  TestAccCodePipeline_MultiRegion_basic
=== CONT  TestAccCodePipeline_MultiRegion_convertSingleRegion
=== CONT  TestAccCodePipeline_withNamespace
--- PASS: TestAccCodePipeline_withNamespace (44.13s)
--- PASS: TestAccCodePipeline_disappears (49.81s)
--- PASS: TestAccCodePipeline_emptyStageArtifacts (51.42s)
--- PASS: TestAccCodePipeline_deployWithServiceRole (53.63s)
--- PASS: TestAccCodePipeline_MultiRegion_basic (59.36s)
--- PASS: TestAccCodePipeline_MultiRegion_update (69.07s)
--- PASS: TestAccCodePipeline_withGitHubV1SourceAction (71.37s)
--- PASS: TestAccCodePipeline_basic (78.24s)
=== CONT  TestAccCodePipeline_MultiRegion_convertSingleRegion
    codepipeline_test.go:390: Step 3/4 error: Error running apply: exit status 1
        
        Error: region cannot be set for a single-region CodePipeline
        
          with aws_codepipeline.test,
          on terraform_plugin_test.tf line 63, in resource "aws_codepipeline" "test":
          63: resource "aws_codepipeline" "test" {
        
--- FAIL: TestAccCodePipeline_MultiRegion_convertSingleRegion (89.52s)
--- PASS: TestAccCodePipeline_tags (98.75s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline	102.837s

Failure is unrelated to this change, it's also happening on main:

% make testacc TESTS=TestAccCodePipeline_MultiRegion_convertSingleRegion PKG=codepipeline
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codepipeline/... -v -count 1 -parallel 20 -run='TestAccCodePipeline_MultiRegion_convertSingleRegion' -timeout 180m
=== RUN   TestAccCodePipeline_MultiRegion_convertSingleRegion
=== PAUSE TestAccCodePipeline_MultiRegion_convertSingleRegion
=== CONT  TestAccCodePipeline_MultiRegion_convertSingleRegion
    codepipeline_test.go:390: Step 3/4 error: Error running apply: exit status 1
        
        Error: region cannot be set for a single-region CodePipeline
        
          with aws_codepipeline.test,
          on terraform_plugin_test.tf line 63, in resource "aws_codepipeline" "test":
          63: resource "aws_codepipeline" "test" {
        
--- FAIL: TestAccCodePipeline_MultiRegion_convertSingleRegion (130.72s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline	136.587s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.