Submodules in AWS CodeBuild projects are not working

[ghost]

This issue was originally opened by @aichholzer as hashicorp/terraform#28062. It was migrated here as a result of the provider split. The original body of the issue is below.

---

Trying to enable git_submodules_config for a aws_codebuild_project does not work.

My repository's type is BITBUCKET, the terraform documentation states:

git_submodules_config - (Optional) Information about the Git submodules configuration for an AWS CodeBuild build project. Git submodules config blocks are documented below. This option is only valid when the type is CODECOMMIT, GITHUB or GITHUB_ENTERPRISE.

However, it is possible to manually set enable this on the AWS CodeBuild project's source page.

Why does terraform not apply this change for type = BITBUCKET repositories while it still being possible through the AWS CodeBuild dashboard?

In my particular case, I have some sub-modules and when I run the build with Use Git submodules = false they are not pulled as expected. Once I manually set this in the project's source, it works; they are pulled as they should when the repository is cloned.

I'd like to be able to set this directly through terraform:

source {
  type = "BITBUCKET"
  location = "..."
  git_clone_depth = 1
  report_build_status = true

  git_submodules_config {
    fetch_submodules = true
  }
}

Terraform Version

Terraform v0.14.3
+ provider registry.terraform.io/hashicorp/aws v3.22.0

Terraform Configuration Files

resource aws_codebuild_project build {
  name = "..."
  description = "Image builder."
  build_timeout = "10"
  service_role  = "..."
  badge_enabled = true

  source {
    type = "BITBUCKET"
    location = "..."
    git_clone_depth = 1
    report_build_status = true

    git_submodules_config {
      fetch_submodules = true
    }
}

Expected Behavior

It should enable the Use Git submodules option (checkbox) in the AWS CodeBuild project's source settings.

Actual Behavior

Running terraform apply acknowledges the change but does not perform it (on yes). Consecutive runs of terraform apply will show the same change again as pending...

[DrFaust92]

seem that the issue stems from this:

terraform-provider-aws/aws/resource_aws_codebuild_project.go

Lines 1049 to 1065 in b4205b9

	// Only valid for CODECOMMIT, GITHUB, GITHUB_ENTERPRISE source types.
	if sourceType == codebuild.SourceTypeCodecommit || sourceType == codebuild.SourceTypeGithub || sourceType == codebuild.SourceTypeGithubEnterprise {
	if v, ok := data["git_submodules_config"]; ok && len(v.([]interface{})) > 0 {
	config := v.([]interface{})[0].(map[string]interface{})
	gitSubmodulesConfig := &codebuild.GitSubmodulesConfig{}
	if v, ok := config["fetch_submodules"]; ok {
	gitSubmodulesConfig.FetchSubmodules = aws.Bool(v.(bool))
	}
	projectSource.GitSubmodulesConfig = gitSubmodulesConfig
	}
	}
	return projectSource
	}

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.