Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/glue_partition - fix ordering #17344

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 28, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16718

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGluePartition_'
--- PASS: TestAccAWSGluePartition_disappears (37.83s)
--- PASS: TestAccAWSGluePartition_multipleValues (42.82s)
--- PASS: TestAccAWSGluePartition_basic (44.56s)
--- PASS: TestAccAWSGluePartition_parameters (109.03s)

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 28, 2021
@DrFaust92 DrFaust92 changed the title r/glue_parition - fix ordering r/glue_partition - fix ordering Jan 29, 2021
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Jan 29, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review January 29, 2021 16:07
@DrFaust92 DrFaust92 requested a review from a team as a code owner January 29, 2021 16:07
@DrFaust92 DrFaust92 force-pushed the r/glue_partition_order branch from 96f43fe to 701abad Compare January 29, 2021 16:07
@ewbankkit ewbankkit self-assigned this Jan 29, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGluePartition_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSGluePartition_ -timeout 120m
go: downloading github.com/hashicorp/terraform-plugin-sdk/v2 v2.4.2
=== RUN   TestAccAWSGluePartition_basic
=== PAUSE TestAccAWSGluePartition_basic
=== RUN   TestAccAWSGluePartition_multipleValues
=== PAUSE TestAccAWSGluePartition_multipleValues
=== RUN   TestAccAWSGluePartition_parameters
=== PAUSE TestAccAWSGluePartition_parameters
=== RUN   TestAccAWSGluePartition_disappears
=== PAUSE TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_basic
=== CONT  TestAccAWSGluePartition_disappears
--- PASS: TestAccAWSGluePartition_disappears (16.51s)
=== CONT  TestAccAWSGluePartition_parameters
--- PASS: TestAccAWSGluePartition_basic (18.84s)
=== CONT  TestAccAWSGluePartition_multipleValues
--- PASS: TestAccAWSGluePartition_multipleValues (16.65s)
--- PASS: TestAccAWSGluePartition_parameters (40.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.588s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSGluePartition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGluePartition_ -timeout 120m
=== RUN   TestAccAWSGluePartition_basic
=== PAUSE TestAccAWSGluePartition_basic
=== RUN   TestAccAWSGluePartition_multipleValues
=== PAUSE TestAccAWSGluePartition_multipleValues
=== RUN   TestAccAWSGluePartition_parameters
=== PAUSE TestAccAWSGluePartition_parameters
=== RUN   TestAccAWSGluePartition_disappears
=== PAUSE TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_basic
=== CONT  TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_parameters
=== CONT  TestAccAWSGluePartition_multipleValues
--- PASS: TestAccAWSGluePartition_disappears (14.37s)
--- PASS: TestAccAWSGluePartition_multipleValues (16.68s)
--- PASS: TestAccAWSGluePartition_basic (16.85s)
--- PASS: TestAccAWSGluePartition_parameters (37.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.141s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccAWSGluePartition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGluePartition_ -timeout 120m
=== RUN   TestAccAWSGluePartition_basic
=== PAUSE TestAccAWSGluePartition_basic
=== RUN   TestAccAWSGluePartition_multipleValues
=== PAUSE TestAccAWSGluePartition_multipleValues
=== RUN   TestAccAWSGluePartition_parameters
=== PAUSE TestAccAWSGluePartition_parameters
=== RUN   TestAccAWSGluePartition_disappears
=== PAUSE TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_basic
=== CONT  TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_parameters
=== CONT  TestAccAWSGluePartition_multipleValues
--- PASS: TestAccAWSGluePartition_disappears (12.02s)
--- PASS: TestAccAWSGluePartition_basic (13.57s)
--- PASS: TestAccAWSGluePartition_multipleValues (13.92s)
--- PASS: TestAccAWSGluePartition_parameters (28.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.806s

@breathingdust breathingdust merged commit d6389c1 into hashicorp:main Feb 4, 2021
@github-actions github-actions bot added this to the v3.27.0 milestone Feb 4, 2021
bflad added a commit that referenced this pull request Feb 4, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 6, 2021
@DrFaust92 DrFaust92 deleted the r/glue_partition_order branch April 15, 2021 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_glue_partition partition_values reordered during terraform apply
3 participants