Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sns_topic_subscription support firehose protocol #17303

Closed
chammock opened this issue Jan 27, 2021 · 2 comments · Fixed by #14923
Closed

sns_topic_subscription support firehose protocol #17303

chammock opened this issue Jan 27, 2021 · 2 comments · Fixed by #14923
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service.
Milestone

Comments

@chammock
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS recently released the ability to subscribe kinesis firehose to an SNS topic. Please add the ability to subscribe firehose protocol to SNS topic.

New or Affected Resource(s)

  • sns_topic_subscription

Potential Terraform Configuration

resource "aws_sns_topic_subscription" "example" {
  topic_arn = aws_sns_topic.example.arn
  protocol  = "firehose"
  endpoint  = "arn:aws:firehose:us-west-2:123456789012:deliverystream/MyStream"
  subscription_role_arn = "arn:aws:iam::123456789012:role/FirehoseRoleArn"
}

References

https://docs.aws.amazon.com/sns/latest/api/API_Subscribe.html#API_Subscribe_RequestParameters

  • #0000
@chammock chammock added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 27, 2021
@ghost ghost added the service/sns Issues and PRs that pertain to the sns service. label Jan 27, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 27, 2021
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 27, 2021
@github-actions github-actions bot added this to the v3.30.0 milestone Feb 25, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service.
Projects
None yet
2 participants