feat: add support for event archive in EventBridge resource

[heitorlessa]

Intro

This PR adds support to create Archives in EventBridge.

Release note for CHANGELOG:

resource_aws_cloudwatch_event_archive - add new resource

Tasks

• Initial CRUD implementation
• Acceptance test
• Update docs
• Investigate answers to open questions

Open questions as a first time contributor

Q: How do I add support for import?

Update: Fix available in 5ab7d94

Tried following other resources that do support but it seems there's something wrongly parametrized:

// ...archive.go
	return &schema.Resource{
                ...
		Importer: &schema.ResourceImporter{
			State: schema.ImportStatePassthrough,
		},

// ...archive_test.go
....
{
    // also tried without Config key
    Config:            testAccAWSCloudWatchArchiveConfig(archiveName),
    ResourceName:      resourceName,
    ImportState:       true,
    ImportStateVerify: true,
},

Error

    resource_aws_cloudwatch_event_archive_test.go:78: Step 2/2 error running import: 
        Error: Error reading CloudWatch Events archive: InvalidParameter: 1 validation error(s) found.
        - minimum field size of 1, DescribeArchiveInput.ArchiveName.

Q: How do I fix acceptance test lint error in CI?

Can't see what's wrong by just looking at GH Actions logs. Maybe I missed that in the contrib checklist docs.

A: Running terrafmt diff --check --fmtcompat aws/resource_aws_cloudwatch_event_archive_test.go locally showed the error.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #16067

Output from acceptance testing: WIP

$ make fmt && make testacc TESTARGS='-run=TestAccAWSCloudWatchArchive'       
==> Fixing source code with gofmt...
gofmt -s -w ./aws ./awsproviderlint/helper ./awsproviderlint/main.go ./awsproviderlint/passes
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchArchive -timeout 120m
=== RUN   TestAccAWSCloudWatchArchive_basic
=== PAUSE TestAccAWSCloudWatchArchive_basic
=== RUN   TestAccAWSCloudWatchArchive_update
=== PAUSE TestAccAWSCloudWatchArchive_update
=== CONT  TestAccAWSCloudWatchArchive_basic
=== CONT  TestAccAWSCloudWatchArchive_update
--- PASS: TestAccAWSCloudWatchArchive_basic (33.35s)
--- PASS: TestAccAWSCloudWatchArchive_update (55.17s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       57.862s

[github-actions]

Welcome @heitorlessa 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[heitorlessa]

All linting issues fixed - Ready for review

[bill-rich]

Looks good! Just a few minor suggestions and questions. Also please add a .changelog file.

[heitorlessa]

Addressed all comments: Changelog entry, Test remaining attributes can be updated, ForceNew attribute, and Doc chars -> characters.

CI is failing due to Security Hub test file (non-existent) formatting unrelated to this PR, though Fixed it

[bill-rich]

LGTM. Thanks for taking a look at the comments.

[ghost]

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!