resource/aws_s3_bucket_object: Retry read after creation for 404 status code

[shuheiktgw]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9725

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccAWSS3BucketObject_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3BucketObject_ -timeout 120m
=== RUN   TestAccAWSS3BucketObject_noNameNoKey
=== PAUSE TestAccAWSS3BucketObject_noNameNoKey
=== RUN   TestAccAWSS3BucketObject_empty
=== PAUSE TestAccAWSS3BucketObject_empty
=== RUN   TestAccAWSS3BucketObject_source
=== PAUSE TestAccAWSS3BucketObject_source
=== RUN   TestAccAWSS3BucketObject_content
=== PAUSE TestAccAWSS3BucketObject_content
=== RUN   TestAccAWSS3BucketObject_etagEncryption
=== PAUSE TestAccAWSS3BucketObject_etagEncryption
=== RUN   TestAccAWSS3BucketObject_contentBase64
=== PAUSE TestAccAWSS3BucketObject_contentBase64
=== RUN   TestAccAWSS3BucketObject_withContentCharacteristics
=== PAUSE TestAccAWSS3BucketObject_withContentCharacteristics
=== RUN   TestAccAWSS3BucketObject_NonVersioned
=== PAUSE TestAccAWSS3BucketObject_NonVersioned
=== RUN   TestAccAWSS3BucketObject_updates
=== PAUSE TestAccAWSS3BucketObject_updates
=== RUN   TestAccAWSS3BucketObject_updateSameFile
=== PAUSE TestAccAWSS3BucketObject_updateSameFile
=== RUN   TestAccAWSS3BucketObject_updatesWithVersioning
=== PAUSE TestAccAWSS3BucketObject_updatesWithVersioning
=== RUN   TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint
=== PAUSE TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint
=== RUN   TestAccAWSS3BucketObject_kms
=== PAUSE TestAccAWSS3BucketObject_kms
=== RUN   TestAccAWSS3BucketObject_sse
=== PAUSE TestAccAWSS3BucketObject_sse
=== RUN   TestAccAWSS3BucketObject_acl
=== PAUSE TestAccAWSS3BucketObject_acl
=== RUN   TestAccAWSS3BucketObject_metadata
=== PAUSE TestAccAWSS3BucketObject_metadata
=== RUN   TestAccAWSS3BucketObject_storageClass
=== PAUSE TestAccAWSS3BucketObject_storageClass
=== RUN   TestAccAWSS3BucketObject_tags
=== PAUSE TestAccAWSS3BucketObject_tags
=== RUN   TestAccAWSS3BucketObject_tagsLeadingSlash
=== PAUSE TestAccAWSS3BucketObject_tagsLeadingSlash
=== RUN   TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone
=== PAUSE TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone
=== RUN   TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn
=== PAUSE TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn
=== RUN   TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone
=== PAUSE TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone
=== RUN   TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet
=== PAUSE TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet
=== RUN   TestAccAWSS3BucketObject_defaultBucketSSE
=== PAUSE TestAccAWSS3BucketObject_defaultBucketSSE
=== RUN   TestAccAWSS3BucketObject_ignoreTags
=== PAUSE TestAccAWSS3BucketObject_ignoreTags
=== CONT  TestAccAWSS3BucketObject_noNameNoKey
=== CONT  TestAccAWSS3BucketObject_sse
=== CONT  TestAccAWSS3BucketObject_NonVersioned
=== CONT  TestAccAWSS3BucketObject_tagsLeadingSlash
=== CONT  TestAccAWSS3BucketObject_tags
=== CONT  TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn
=== CONT  TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone
=== CONT  TestAccAWSS3BucketObject_metadata
=== CONT  TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet
=== CONT  TestAccAWSS3BucketObject_storageClass
=== CONT  TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone
=== CONT  TestAccAWSS3BucketObject_acl
=== CONT  TestAccAWSS3BucketObject_etagEncryption
=== CONT  TestAccAWSS3BucketObject_withContentCharacteristics
=== CONT  TestAccAWSS3BucketObject_ignoreTags
=== CONT  TestAccAWSS3BucketObject_updatesWithVersioning
=== CONT  TestAccAWSS3BucketObject_kms
=== CONT  TestAccAWSS3BucketObject_contentBase64
=== CONT  TestAccAWSS3BucketObject_defaultBucketSSE
=== CONT  TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint
=== CONT  TestAccAWSS3BucketObject_NonVersioned
    provider_test.go:1819: skipping tests; TF_ACC_ASSUME_ROLE_ARN must be set
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (1.80s)
=== CONT  TestAccAWSS3BucketObject_source
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (48.07s)
=== CONT  TestAccAWSS3BucketObject_content
=== CONT  TestAccAWSS3BucketObject_ignoreTags
    resource_aws_s3_bucket_object_test.go:986: Step 1/2 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout


        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # aws_s3_bucket_object.object will be updated in-place
          ~ resource "aws_s3_bucket_object" "object" {
                id            = "test-key"
              ~ tags          = {
                  - "ignorekey1" = "ignorevalue1" -> null
                }
                # (10 unchanged attributes hidden)
            }

        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAWSS3BucketObject_ignoreTags (134.43s)
=== CONT  TestAccAWSS3BucketObject_empty
--- PASS: TestAccAWSS3BucketObject_contentBase64 (134.84s)
=== CONT  TestAccAWSS3BucketObject_updateSameFile
--- PASS: TestAccAWSS3BucketObject_source (133.31s)
=== CONT  TestAccAWSS3BucketObject_updates
--- PASS: TestAccAWSS3BucketObject_kms (135.71s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (136.06s)
--- PASS: TestAccAWSS3BucketObject_sse (136.31s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (136.66s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (137.25s)
--- PASS: TestAccAWSS3BucketObject_content (106.49s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (203.97s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (208.76s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (209.92s)
--- PASS: TestAccAWSS3BucketObject_empty (81.51s)
--- PASS: TestAccAWSS3BucketObject_metadata (254.73s)
--- PASS: TestAccAWSS3BucketObject_acl (254.93s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (256.57s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (258.79s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (129.40s)
--- PASS: TestAccAWSS3BucketObject_updates (129.18s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (287.59s)
--- PASS: TestAccAWSS3BucketObject_tags (288.28s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (288.44s)
--- PASS: TestAccAWSS3BucketObject_storageClass (313.48s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	316.843s
FAIL
make: *** [testacc] Error 1

There might be other eventual consistency problems and if I run TestAccAWSS3BucketObject_ignoreTags separately it succeeds.

make testacc TESTARGS='-run=TestAccAWSS3BucketObject_ignoreTags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3BucketObject_ignoreTags -timeout 120m
=== RUN   TestAccAWSS3BucketObject_ignoreTags
=== PAUSE TestAccAWSS3BucketObject_ignoreTags
=== CONT  TestAccAWSS3BucketObject_ignoreTags
--- PASS: TestAccAWSS3BucketObject_ignoreTags (67.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.218s

Also, the same problem happens without this change so I think it does not relate to the changes on this PR.

Thank you for your review! 👍

[bflad]

Thank you, @shuheiktgw 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSS3BucketObject_acl (149.28s)
--- PASS: TestAccAWSS3BucketObject_content (55.47s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (56.32s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (59.92s)
--- PASS: TestAccAWSS3BucketObject_empty (43.51s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (55.44s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (49.17s)
--- PASS: TestAccAWSS3BucketObject_kms (56.66s)
--- PASS: TestAccAWSS3BucketObject_metadata (117.12s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (13.28s)
--- PASS: TestAccAWSS3BucketObject_NonVersioned (55.95s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (150.69s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (94.45s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (138.35s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (173.42s)
--- PASS: TestAccAWSS3BucketObject_source (40.22s)
--- PASS: TestAccAWSS3BucketObject_sse (40.00s)
--- PASS: TestAccAWSS3BucketObject_storageClass (185.50s)
--- PASS: TestAccAWSS3BucketObject_tags (146.46s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (162.23s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (163.67s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (164.13s)
--- PASS: TestAccAWSS3BucketObject_updates (92.91s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (98.47s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (91.82s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (115.35s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (39.88s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSS3BucketObject_acl (133.53s)
--- PASS: TestAccAWSS3BucketObject_content (72.98s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (55.80s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (79.15s)
--- PASS: TestAccAWSS3BucketObject_empty (56.26s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (73.86s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (113.53s)
--- PASS: TestAccAWSS3BucketObject_kms (73.81s)
--- PASS: TestAccAWSS3BucketObject_metadata (96.90s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (13.58s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (134.48s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (82.00s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (97.82s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (124.65s)
--- PASS: TestAccAWSS3BucketObject_source (56.30s)
--- PASS: TestAccAWSS3BucketObject_sse (64.91s)
--- PASS: TestAccAWSS3BucketObject_storageClass (170.44s)
--- PASS: TestAccAWSS3BucketObject_tags (126.19s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (155.33s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (161.70s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (156.13s)
--- PASS: TestAccAWSS3BucketObject_updates (106.26s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (106.70s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (112.11s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (114.20s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (56.20s)
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (1.53s)

[ghost]

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!