PoolArn attribute support in Data Source: aws_ec2_coip_pool

[sumitmenaria]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16426

Release note for CHANGELOG:

DataSource/aws_ec2_coip_pool pool_arn attribute support

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsEc2CoipPool_Id'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEc2CoipPool_Id -timeout 120m
=== RUN   TestAccDataSourceAwsEc2CoipPool_Id
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
--- PASS: TestAccDataSourceAwsEc2CoipPool_Id (34.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.272s

...

[github-actions]

Welcome @sumitmenaria 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

@sumitmenaria Thanks for the contribution 👏. Could you please rename the new attribute to plan arn?
Although we usually prefer that the attribute name matches the property name in the underlying AWS API, for the property that contains the resource's ARN we always try and stick with arn - Guidelines here.
Other than that (and the comment above) this looks great.

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsEc2CoipPool_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEc2CoipPool_ -timeout 120m
=== RUN   TestAccDataSourceAwsEc2CoipPool_Filter
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Filter
=== RUN   TestAccDataSourceAwsEc2CoipPool_Id
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Filter (1.90s)
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Id (1.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.067s

[sumitmenaria]

@ewbankkit Pardom me for my ignorance, is there any tentative timeline when this request is going to be merged?

[FireballDWF]

@ewbankkit What is the next step to move this forward?

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDataSourceAwsEc2CoipPool_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEc2CoipPool_ -timeout 120m
=== RUN   TestAccDataSourceAwsEc2CoipPool_Filter
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Filter
=== RUN   TestAccDataSourceAwsEc2CoipPool_Id
=== PAUSE TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
=== CONT  TestAccDataSourceAwsEc2CoipPool_Filter
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Filter (1.43s)
=== CONT  TestAccDataSourceAwsEc2CoipPool_Id
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccDataSourceAwsEc2CoipPool_Id (1.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.156s

[ewbankkit]

@sumitmenaria Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.