resource/aws_route53_zone_association: Prevent deletion errors for missing Hosted Zone or VPC association #17023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing Hosted Zone or VPC association Reference: #15945 Reference: #17016 Reference: https://docs.aws.amazon.com/Route53/latest/APIReference/API_DisassociateVPCFromHostedZone.html#API_DisassociateVPCFromHostedZone_Errors This is a best effort fix for the errors returned by the Route 53 `DisassociateVPCFromHostedZone` API, which are unrelated to the potential errors during the `Read` function that uses the `ListHostedZonesByVPC` API. The acceptance testing framework does not lend itself well to testing this situation and this highlights a case where #15945 would need special handling. Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSRoute53ZoneAssociation_disappears_Zone (146.44s) --- PASS: TestAccAWSRoute53ZoneAssociation_disappears (147.22s) --- PASS: TestAccAWSRoute53ZoneAssociation_disappears_VPC (147.31s) --- PASS: TestAccAWSRoute53ZoneAssociation_CrossRegion (149.84s) --- PASS: TestAccAWSRoute53ZoneAssociation_basic (150.01s) --- PASS: TestAccAWSRoute53ZoneAssociation_CrossAccount (507.91s) ```
ghost
added
size/XS
|
This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: https://docs.aws.amazon.com/Route53/latest/APIReference/API_DisassociateVPCFromHostedZone.html#API_DisassociateVPCFromHostedZone_Errors
Reference: #15945
Closes #17016
Release note for CHANGELOG:
This is a best effort fix for the errors returned by the Route 53
DisassociateVPCFromHostedZoneAPI, which are unrelated to the potential errors during theReadfunction that uses theListHostedZonesByVPCAPI. The acceptance testing framework does not lend itself well to testing this situation and this highlights a case where #15945 would need special handling.Output from acceptance testing in AWS Commercial: