Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ecs_capacity_provider: Add support for ECS capacity provider update #16943

Closed
shuheiktgw opened this issue Jan 3, 2021 · 3 comments · Fixed by #16942
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.

Comments

@shuheiktgw
Copy link
Collaborator

shuheiktgw commented Jan 3, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As described in aws/containers-roadmap#633, the ECS capacity provider now supports updating its parameters. It would be nice if terraform-aws-provider supports it too.

New or Affected Resource(s)

  • aws_ecs_capacity_provider

Potential Terraform Configuration

N/A

References

@shuheiktgw shuheiktgw added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 3, 2021
@ghost ghost added the service/ecs Issues and PRs that pertain to the ecs service. label Jan 3, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 3, 2021
@shuheiktgw shuheiktgw changed the title resource/aws_ecs_service: Add support for ECS capacity provider update resource/aws_ecs_capacity_provider: Add support for ECS capacity provider update Jan 3, 2021
@eddgrant
Copy link

I'm not literate in golang but I think the AWS SDK that Terraform uses already has support for the updating of capacity providers here. Unlocking in-place (rather than replacing) updates to the managed_scaling properties would make capacity providers a viable prospect to use with Terraform.

@shuheiktgw
Copy link
Collaborator Author

Yes, I've already created a PR to add an update function to ecs_capacity_provider. It's been waiting for a review now!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
3 participants