resource aws_msk_cluster enhanced_monitoring does not allow setting to PER_TOPIC_PER_PARTITION

[cemeyer2]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

• Terraform 0.12.28
• AWS provider 3.22.0

Affected Resource(s)

• aws_msk_cluster

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

resource "aws_msk_cluster" "kafka_cluster" {
...
enhanced_monitoring = "PER_TOPIC_PER_PARTITION"
...
}

Expected Behavior

The provider should provision MSK with the correct monitoring level specified.

Actual Behavior

Error: expected enhanced_monitoring to be one of [DEFAULT PER_BROKER PER_TOPIC_PER_BROKER], got PER_TOPIC_PER_PARTITION

Steps to Reproduce

1. terraform apply

Important Factoids

https://docs.aws.amazon.com/msk/latest/developerguide/metrics-details.html indicates PER_TOPIC_PER_PARTITION is a valid setting now, but https://github.com/hashicorp/terraform-provider-aws/blob/master/aws/resource_aws_msk_cluster.go#L219-L223 seems to need to be updated to support this new value as one of the allowed parameters.

[anGie44]

Thank you for raising this issue @cemeyer2 , adding support should be a straightforward fix 👍 Just noting that we're moving in the direction of using the AWS Go SDK _Values() funcs to retrieve the possible list of values if available (for reference: #14601)

[gunadhya]

Hi @anGie44, I'd like to work on this issue. So I'm thinking the change would be something like this right?

Before:

"enhanced_monitoring": {
				Type:     schema.TypeString,
				Optional: true,
				Default:  kafka.EnhancedMonitoringDefault,
				ValidateFunc: validation.StringInSlice([]string{
					kafka.EnhancedMonitoringDefault,
					kafka.EnhancedMonitoringPerBroker,
					kafka.EnhancedMonitoringPerTopicPerBroker,
				}, true),
			}

After:

"enhanced_monitoring": {
   			Type:     schema.TypeString,
   			Optional: true,
   			Default:  kafka.EnhancedMonitoringDefault,
   			ValidateFunc: validation.StringInSlice(kafka.EnhancedMonitoring_Values(), true),
   		}

[anGie44]

PER_TOPIC_PER_PARTITION support has been merged and will release with v3.23.0 of the Terraform AWS Provider, likely out this Thursday.

[ghost]

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!