Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/api_gateway_authorizer: set authorizer_credentials via PatchOperation on create for COGNITO_USER_POOLS type #16614

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Dec 6, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16613

Release note for CHANGELOG:

resource/api_gateway_authorizer: ensure authorizer_credentials are set and read from API for "COGNITO_USER_POOLS" type

Output from acceptance testing before code change:

    TestAccAWSAPIGatewayAuthorizer_cognito_authorizerCredentials: resource_aws_api_gateway_authorizer_test.go:106: Step 1/2 error: Check failed: Check 1/4 error: aws_api_gateway_authorizer.test: Attribute 'authorizer_credentials' expected "arn:aws:iam::xxxxxxxxx:role/tf-acc-test-1110847447754337420-lambda", got ""
--- FAIL: TestAccAWSAPIGatewayAuthorizer_cognito_authorizerCredentials (11.45s)

Output from acceptance testing after code change:

--- PASS: TestAccAWSAPIGatewayAuthorizer_cognito_authorizerCredentials (18.99s)

@anGie44 anGie44 requested a review from a team as a code owner December 6, 2020 14:49
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 6, 2020
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Dec 6, 2020
@anGie44 anGie44 changed the title r/api_gateway_authorizer: set authorizer_credentials via PatchOperation for COGNITO_USER_POOLS type r/api_gateway_authorizer: set authorizer_credentials via PatchOperation on create for COGNITO_USER_POOLS type Dec 6, 2020
@gdavison gdavison self-assigned this Jan 7, 2021
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayAuthorizer_cognito (25.70s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_authTypeValidation (57.67s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_basic (58.51s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_cognito_authorizerCredentials (124.54s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_switchAuthorizerTTL (154.58s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_switchAuthType (188.49s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_disappears (236.62s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_zero_ttl (412.29s)

@anGie44 anGie44 added this to the v3.25.0 milestone Jan 19, 2021
@anGie44 anGie44 merged commit d7b060d into master Jan 19, 2021
@anGie44 anGie44 deleted the b-apigateway-authorizer-authcred branch January 19, 2021 20:56
anGie44 added a commit that referenced this pull request Jan 19, 2021
@ghost
Copy link

ghost commented Jan 22, 2021

This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Gateway Authorizer: Authorizer Credentials not set when type = "COGNITO_USER_POOLS"
2 participants