provider/aws: Invalid protocol aws_network_acl_rule: Invalid Protocol 47

[certnew]

Hi there,

Terraform Version

Terraform v0.10.3

Affected Resource(s)

aws_network_acl_rule

Terraform Configuration Files

resource "aws_network_acl_rule" "260" {
  network_acl_id = "${aws_network_acl.NACL-PUBLIC.id}"
  rule_number    = 260
  egress         = false
  protocol       = 47
  rule_action    = "allow"
  cidr_block     = "0.0.0.0/0"
}

Debug Output

Error applying plan:
1 error(s) occurred:

• aws_network_acl_rule.260: 1 error(s) occurred:
• aws_network_acl_rule.260: Invalid Protocol 47 for rule 260

Expected Behavior

That the terraform plan completes without giving any errors.

Actual Behavior

Rule actually created and there is in state file

Steps to Reproduce

1. terraform apply

References

Similar to hashicorp/terraform#12103

[jrwilk01]

Similar issues have been fixed by adding to this method:

https://github.com/terraform-providers/terraform-provider-aws/blob/b8d4e1570fc43a2acee6b6e47f63c9db6b067fa2/aws/network_acl_entry.go#L98

Seems like hard coding magic values in the source will lead to more problems.

[bflad]

The full list of protocol names/numbers has been added now via #4956 and will release with version 1.25.0 of the AWS provider, likely middle of this week. While it may not be ideal when new protocol names are assigned, it was a simple change to add support for the above case.

[bflad]

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!