Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Code Signing For AWS Lambda #16384

Merged
merged 9 commits into from
Nov 23, 2020
Merged

Support for Code Signing For AWS Lambda #16384

merged 9 commits into from
Nov 23, 2020

Conversation

santiagocardenas
Copy link
Contributor

@santiagocardenas santiagocardenas commented Nov 23, 2020 •
edited by anGie44
Loading

Add support in Lambda Layers for Code Signing for AWS Lambda
Add new Code Signing Config data source/resource and support in Functions for Code Signing for AWS Lambda.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

FEATURES

    New Data Source: aws_lambda_code_signing_config
    New Resource: aws_lambda_code_signing_config

ENHANCEMENTS

    data-source/aws_lambda_function: Add `signing_profile_version_arn` and `signing_job_arn` attributes
    data-source/aws_lambda_layer_version: Add `signing_profile_version_arn` and `signing_job_arn` attributes
    resource/aws_lambda_function: Add `signing_profile_version_arn` and `signing_job_arn` attributes
    resource/aws_lambda_function: Add `code_signing_config_arn` argument
    resource/aws_lambda_function: Add error checking / handling on the Set() calls
    resource/aws_lambda_layer_version: Add `signing_profile_version_arn` and `signing_job_arn` attributes

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAWSLambdaCodeSigningConfig*'

--- PASS: TestAccDataSourceAWSLambdaCodeSigningConfig_basic (14.49s)
--- PASS: TestAccDataSourceAWSLambdaCodeSigningConfig_Description (14.51s)
--- PASS: TestAccDataSourceAWSLambdaCodeSigningConfig_PolicyConfigId (14.53s)


$ make testacc TESTARGS='-run=TestAccAWSLambdaCodeSigningConfig*'

--- PASS: TestAccAWSLambdaCodeSigningConfig_basic (14.13s)
--- PASS: TestAccAWSLambdaCodeSigningConfig_UpdatePublishers (23.27s)
--- PASS: TestAccAWSLambdaCodeSigningConfig_UpdatePolicy (24.93s)


$ make testacc TESTARGS='-run=TestAccAWSLambdaFunction_codeSigningConfig'

--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (62.95s)

$ make testacc TESTARGS='-run=TestAccDataSourceAWSLambdaFunction*'

...

$ make testacc TESTARGS='-run=TestAccAWSLambdaFunction*'

...

$ make testacc TESTARGS='-run=TestAccDataSourceAWSLambdaLayerVersion*'

...

$ make testacc TESTARGS='-run=TestAccAWSLambdaLayerVersion*'

...

santiagocardenas and others added 3 commits November 18, 2020 20:08
@santiagocardenas @sfallahadl
Code Signing for AWS Lambda Support (Lambda Layers)
3c5b3b1 
Add support in Lambda Layers for Code Signing for AWS Lambda

Co-authored-by: Sarah Fallah-adl <[email protected]>
@santiagocardenas @vedashreevinay
@youngjeong46 @anGie44
Code Signing for AWS Lambda (Code Signing Config and Function)
4ead7e7 
Add new Code Signing Config resource and support in Functions for Code Signing for AWS Lambda.

Co-authored-by: Veda Raman <[email protected]>
Co-authored-by: Young Jeong <[email protected]>
Co-authored-by: angie pinilla <[email protected]>
@santiagocardenas @youngjeong46
@anGie44 @bflad
Code Signing for AWS Lambda (Code Signing Config and Function) Follow-up
badb4b0 
Update Code Signing Config data source/resource and support in Functions for Code Signing for AWS Lambda.

Co-authored-by: Young Jeong <[email protected]>
Co-authored-by: angie pinilla <[email protected]>
Co-authored-by: Brian Flad <[email protected]>
@santiagocardenas santiagocardenas requested a review from a team as a code owner November 23, 2020 19:58
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 23, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 23, 2020
@anGie44 anGie44 added new-data-source Introduces a new data source. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 23, 2020
anGie44
anGie44 approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice, let's get this pup in @santiagocardenas et al. 🚀 🚀

bflad
bflad approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from me too, minor stuff we can handle later.

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccDataSourceAWSLambdaCodeSigningConfig_PolicyConfigId (12.24s)
--- PASS: TestAccDataSourceAWSLambdaCodeSigningConfig_basic (12.34s)
--- PASS: TestAccDataSourceAWSLambdaCodeSigningConfig_Description (12.50s)

--- PASS: TestAccDataSourceAWSLambdaFunction_environment (36.94s)
--- PASS: TestAccDataSourceAWSLambdaFunction_alias (47.40s)
--- PASS: TestAccDataSourceAWSLambdaFunction_basic (50.94s)
--- PASS: TestAccDataSourceAWSLambdaFunction_version (57.76s)
--- PASS: TestAccDataSourceAWSLambdaFunction_layers (67.52s)

--- PASS: TestAccDataSourceAWSLambdaLayerVersion_version (14.99s)
--- PASS: TestAccDataSourceAWSLambdaLayerVersion_basic (19.91s)
--- PASS: TestAccDataSourceAWSLambdaLayerVersion_runtime (28.28s)

--- PASS: TestAccAWSLambdaCodeSigningConfig_basic (15.36s)
--- PASS: TestAccAWSLambdaCodeSigningConfig_UpdatePolicy (23.63s)
--- PASS: TestAccAWSLambdaCodeSigningConfig_UpdatePublishers (24.60s)

--- PASS: TestAccAWSLambdaFunction_basic (71.96s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (1046.52s)
--- PASS: TestAccAWSLambdaFunction_concurrency (1040.52s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (120.33s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (1040.64s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (122.58s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (1025.85s)
--- PASS: TestAccAWSLambdaFunction_disappears (1003.11s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (57.58s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (1217.32s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (135.35s)
--- PASS: TestAccAWSLambdaFunction_envVariables (161.05s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (19.21s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (1903.63s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (108.09s)
--- PASS: TestAccAWSLambdaFunction_Layers (924.06s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (1050.35s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (1052.39s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (1053.93s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (1150.88s)
--- PASS: TestAccAWSLambdaFunction_runtimes (405.97s)
--- PASS: TestAccAWSLambdaFunction_s3 (39.31s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (64.29s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (64.31s)
--- PASS: TestAccAWSLambdaFunction_tags (84.06s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (1032.25s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (1211.68s)
--- PASS: TestAccAWSLambdaFunction_versioned (65.28s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (1234.96s)
--- PASS: TestAccAWSLambdaFunction_VPC (788.22s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (966.94s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (962.36s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (1375.17s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (2505.36s)

--- PASS: TestAccAWSLambdaLayerVersion_basic (14.36s)
--- PASS: TestAccAWSLambdaLayerVersion_compatibleRuntimes (19.15s)
--- PASS: TestAccAWSLambdaLayerVersion_licenseInfo (25.70s)
--- PASS: TestAccAWSLambdaLayerVersion_description (29.40s)
--- PASS: TestAccAWSLambdaLayerVersion_s3 (29.94s)
--- PASS: TestAccAWSLambdaLayerVersion_update (30.76s)

aws/data_source_aws_lambda_code_signing_config_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_lambda_code_signing_config_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_lambda_code_signing_config_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_lambda_code_signing_config_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_lambda_code_signing_config_test.go
dataSourceName := "data.aws_lambda_code_signing_config.test"
resourceName := "aws_lambda_code_signing_config.test"
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup note: GovCloud (US) support is not present for initial release, will need to skip testing in that environment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am on gov cloud and am not using this data source however i am getting errors on all my pipelines after release. ref #16398

aws/data_source_aws_lambda_function.go Outdated Show resolved Hide resolved
@bflad bflad added this to the v3.17.0 milestone Nov 23, 2020
@bflad bflad merged commit d9e7b9a into hashicorp:master Nov 23, 2020
bflad added a commit that referenced this pull request Nov 23, 2020
@bflad
Update CHANGELOG for #16384
71ca835
@ghost
Copy link

ghost commented Nov 24, 2020

This has been released in version 3.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@pjaudiomv pjaudiomv mentioned this pull request Nov 24, 2020
Closed
@rayjlinden
Copy link

I'm trying to track down what broke our development environment. I am seeing this errors in the logs:

2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: ---[ REQUEST POST-SIGN ]-----------------------------
2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: GET /2020-06-30/functions/webhook_lambda/code-signing-config HTTP/1.1
2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Host: localstack:4566
2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: User-Agent: aws-sdk-go/1.35.34 (go1.14.5; linux; amd64) APN/1.0 HashiCorp/1.0 Terraform/0.13.5 (+https://www.terraform.io)
2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Authorization: AWS4-HMAC-SHA256 Credential=fake/20201124/us-west-2/lambda/aws4_request, SignedHeaders=content-type;host;x-amz-date, Signature=a971821d4b5c934174283626eaa12a1b49756a05d68e57183af680f7099e424c
2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Content-Type: application/json
2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: X-Amz-Date: 20201124T054630Z
2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Accept-Encoding: gzip
2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5:
2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5:
2020-11-24T05:46:30.489Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: -----------------------------------------------------
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: 2020/11/24 05:46:30 [DEBUG] [aws-sdk-go] DEBUG: Response lambda/GetFunctionCodeSigningConfig Details:
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: ---[ RESPONSE ]--------------------------------------
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: HTTP/1.1 404
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Connection: close
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Content-Length: 232
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Access-Control-Allow-Headers: authorization,content-type,content-md5,cache-control,x-amz-content-sha256,x-amz-date,x-amz-security-token,x-amz-user-agent,x-amz-target,x-amz-acl,x-amz-version-id,x-localstack-target,x-amz-tagging
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Access-Control-Allow-Methods: HEAD,GET,PUT,POST,DELETE,OPTIONS,PATCH
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Access-Control-Allow-Origin: *
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Access-Control-Expose-Headers: x-amz-version-id
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Content-Type: text/html; charset=utf-8
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Date: Tue, 24 Nov 2020 05:46:30 GMT
2020-11-24T05:46:30.620Z [DEBUG] plugin.terraform-provider-aws_v3.17.0_x5: Server: hypercorn-h11

The key thing in our dev environment is that I am using localstack. Was this tested against localstack?

It appears Localstack does not implement these new endpoints. Is there a way to disable the checks for code signing configs?

The following already exist:
skip_credentials_validation = true
skip_metadata_api_check = true
skip_requesting_account_id = true

Is there a
skip_code_signing_checks = true

Or something like it?

bflad added a commit that referenced this pull request Nov 24, 2020
@bflad
provider: Followup items from initial Code Signing release
919b888 
Reference: #16383 (review)
Reference: #16384 (review)
Reference: #16398

Changes:

```
* data-source/aws_lambda_function: Prevent Lambda GetFunctionCodeSigningConfig API call error outside AWS Commercial regions
* resource/aws_lambda_function: Prevent Lambda GetFunctionCodeSigningConfig API call error outside AWS Commercial regions
```

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSLambdaFunction_basic (660.06s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (1207.31s)
--- PASS: TestAccAWSLambdaFunction_concurrency (1032.30s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (1057.54s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (132.39s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (138.81s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (88.73s)
--- PASS: TestAccAWSLambdaFunction_disappears (1220.09s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (86.77s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (129.99s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (145.89s)
--- PASS: TestAccAWSLambdaFunction_envVariables (718.17s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (14.86s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (1370.29s)
--- PASS: TestAccAWSLambdaFunction_Layers (1016.49s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (160.26s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (505.56s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (503.80s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (48.16s)
--- PASS: TestAccAWSLambdaFunction_runtimes (1695.07s)
--- PASS: TestAccAWSLambdaFunction_s3 (40.08s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (64.03s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (64.88s)
--- PASS: TestAccAWSLambdaFunction_tags (1238.40s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (89.38s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (737.76s)
--- PASS: TestAccAWSLambdaFunction_versioned (101.60s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (1113.10s)
--- PASS: TestAccAWSLambdaFunction_VPC (1412.53s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (989.01s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (623.72s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (1977.57s)
--- PASS: TestAccDataSourceAWSLambdaFunction_alias (1211.85s)
--- PASS: TestAccDataSourceAWSLambdaFunction_basic (54.11s)
--- PASS: TestAccDataSourceAWSLambdaFunction_environment (1182.31s)
--- PASS: TestAccDataSourceAWSLambdaFunction_fileSystemConfig (1941.83s)
--- PASS: TestAccDataSourceAWSLambdaFunction_layers (1106.50s)
--- PASS: TestAccDataSourceAWSLambdaFunction_version (966.75s)
--- PASS: TestAccDataSourceAWSLambdaFunction_vpc (1697.94s)

--- PASS: TestAccAWSSignerSigningJob_basic (35.73s)

--- PASS: TestAccAWSSignerSigningProfile_basic (18.48s)
--- PASS: TestAccAWSSignerSigningProfile_GenerateName (18.16s)
--- PASS: TestAccAWSSignerSigningProfile_GenerateNameWithNamePrefix (18.17s)
--- PASS: TestAccAWSSignerSigningProfile_SignatureValidityPeriod (25.69s)
--- PASS: TestAccAWSSignerSigningProfile_tags (30.83s)

--- PASS: TestAccAWSSignerSigningProfilePermission_basic (23.93s)
--- PASS: TestAccAWSSignerSigningProfilePermission_GetSigningProfile (39.86s)
--- PASS: TestAccAWSSignerSigningProfilePermission_StartSigningJob_GetSP (25.33s)
--- PASS: TestAccAWSSignerSigningProfilePermission_StatementPrefix (28.76s)

--- PASS: TestAccDataSourceAWSSignerSigningJob_basic (30.06s)

--- PASS: TestAccDataSourceAWSSignerSigningProfile_basic (12.39s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSLambdaFunction_basic (60.15s)
--- PASS: TestAccAWSLambdaFunction_concurrency (86.67s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (138.48s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (152.23s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (138.97s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (72.75s)
--- PASS: TestAccAWSLambdaFunction_disappears (104.35s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (918.89s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (111.27s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (156.43s)
--- PASS: TestAccAWSLambdaFunction_envVariables (168.64s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (25.56s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (1546.53s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (891.68s)
--- PASS: TestAccAWSLambdaFunction_Layers (916.74s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (401.14s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (1074.54s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (1062.94s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (888.61s)
--- PASS: TestAccAWSLambdaFunction_runtimes (1187.08s)
--- PASS: TestAccAWSLambdaFunction_s3 (35.88s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (64.64s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (62.12s)
--- PASS: TestAccAWSLambdaFunction_tags (859.06s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (541.36s)
--- PASS: TestAccAWSLambdaFunction_versioned (148.92s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (692.93s)
--- PASS: TestAccAWSLambdaFunction_VPC (1181.39s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (703.33s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (455.69s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (994.78s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (1224.48s)
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (2.22s)

--- SKIP: TestAccAWSSignerSigningJob_basic (7.57s)

--- SKIP: TestAccAWSSignerSigningProfile_basic (7.52s)
--- SKIP: TestAccAWSSignerSigningProfile_GenerateName (7.44s)
--- SKIP: TestAccAWSSignerSigningProfile_GenerateNameWithNamePrefix (1.85s)
--- SKIP: TestAccAWSSignerSigningProfile_SignatureValidityPeriod (7.35s)
--- SKIP: TestAccAWSSignerSigningProfile_tags (7.87s)

--- SKIP: TestAccAWSSignerSigningProfilePermission_basic (7.66s)
--- SKIP: TestAccAWSSignerSigningProfilePermission_GetSigningProfile (7.65s)
--- SKIP: TestAccAWSSignerSigningProfilePermission_StartSigningJob_GetSP (1.84s)
--- SKIP: TestAccAWSSignerSigningProfilePermission_StatementPrefix (1.86s)

--- PASS: TestAccDataSourceAWSLambdaFunction_alias (42.58s)
--- PASS: TestAccDataSourceAWSLambdaFunction_basic (34.49s)
--- PASS: TestAccDataSourceAWSLambdaFunction_environment (113.95s)
--- PASS: TestAccDataSourceAWSLambdaFunction_fileSystemConfig (961.20s)
--- PASS: TestAccDataSourceAWSLambdaFunction_layers (136.12s)
--- PASS: TestAccDataSourceAWSLambdaFunction_version (248.84s)
--- PASS: TestAccDataSourceAWSLambdaFunction_vpc (598.98s)

--- SKIP: TestAccDataSourceAWSSignerSigningJob_basic (7.44s)

--- SKIP: TestAccDataSourceAWSSignerSigningProfile_basic (7.37s)
```
@bflad bflad mentioned this pull request Nov 24, 2020
Merged
bflad added a commit that referenced this pull request Nov 24, 2020
@bflad
provider: Followup items from initial Code Signing release (#16412)
61d7e93 
* provider: Followup items from initial Code Signing release

Reference: #16383 (review)
Reference: #16384 (review)
Reference: #16398

Changes:

```
* data-source/aws_lambda_function: Prevent Lambda GetFunctionCodeSigningConfig API call error outside AWS Commercial regions
* resource/aws_lambda_function: Prevent Lambda GetFunctionCodeSigningConfig API call error outside AWS Commercial regions
```

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSLambdaFunction_basic (660.06s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (1207.31s)
--- PASS: TestAccAWSLambdaFunction_concurrency (1032.30s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (1057.54s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (132.39s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (138.81s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (88.73s)
--- PASS: TestAccAWSLambdaFunction_disappears (1220.09s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (86.77s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (129.99s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (145.89s)
--- PASS: TestAccAWSLambdaFunction_envVariables (718.17s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (14.86s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (1370.29s)
--- PASS: TestAccAWSLambdaFunction_Layers (1016.49s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (160.26s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (505.56s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (503.80s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (48.16s)
--- PASS: TestAccAWSLambdaFunction_runtimes (1695.07s)
--- PASS: TestAccAWSLambdaFunction_s3 (40.08s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (64.03s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (64.88s)
--- PASS: TestAccAWSLambdaFunction_tags (1238.40s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (89.38s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (737.76s)
--- PASS: TestAccAWSLambdaFunction_versioned (101.60s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (1113.10s)
--- PASS: TestAccAWSLambdaFunction_VPC (1412.53s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (989.01s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (623.72s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (1977.57s)
--- PASS: TestAccDataSourceAWSLambdaFunction_alias (1211.85s)
--- PASS: TestAccDataSourceAWSLambdaFunction_basic (54.11s)
--- PASS: TestAccDataSourceAWSLambdaFunction_environment (1182.31s)
--- PASS: TestAccDataSourceAWSLambdaFunction_fileSystemConfig (1941.83s)
--- PASS: TestAccDataSourceAWSLambdaFunction_layers (1106.50s)
--- PASS: TestAccDataSourceAWSLambdaFunction_version (966.75s)
--- PASS: TestAccDataSourceAWSLambdaFunction_vpc (1697.94s)

--- PASS: TestAccAWSSignerSigningJob_basic (35.73s)

--- PASS: TestAccAWSSignerSigningProfile_basic (18.48s)
--- PASS: TestAccAWSSignerSigningProfile_GenerateName (18.16s)
--- PASS: TestAccAWSSignerSigningProfile_GenerateNameWithNamePrefix (18.17s)
--- PASS: TestAccAWSSignerSigningProfile_SignatureValidityPeriod (25.69s)
--- PASS: TestAccAWSSignerSigningProfile_tags (30.83s)

--- PASS: TestAccAWSSignerSigningProfilePermission_basic (23.93s)
--- PASS: TestAccAWSSignerSigningProfilePermission_GetSigningProfile (39.86s)
--- PASS: TestAccAWSSignerSigningProfilePermission_StartSigningJob_GetSP (25.33s)
--- PASS: TestAccAWSSignerSigningProfilePermission_StatementPrefix (28.76s)

--- PASS: TestAccDataSourceAWSSignerSigningJob_basic (30.06s)

--- PASS: TestAccDataSourceAWSSignerSigningProfile_basic (12.39s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSLambdaFunction_basic (60.15s)
--- PASS: TestAccAWSLambdaFunction_concurrency (86.67s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (138.48s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (152.23s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (138.97s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (72.75s)
--- PASS: TestAccAWSLambdaFunction_disappears (104.35s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (918.89s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (111.27s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (156.43s)
--- PASS: TestAccAWSLambdaFunction_envVariables (168.64s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (25.56s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (1546.53s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (891.68s)
--- PASS: TestAccAWSLambdaFunction_Layers (916.74s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (401.14s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (1074.54s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (1062.94s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (888.61s)
--- PASS: TestAccAWSLambdaFunction_runtimes (1187.08s)
--- PASS: TestAccAWSLambdaFunction_s3 (35.88s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (64.64s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (62.12s)
--- PASS: TestAccAWSLambdaFunction_tags (859.06s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (541.36s)
--- PASS: TestAccAWSLambdaFunction_versioned (148.92s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (692.93s)
--- PASS: TestAccAWSLambdaFunction_VPC (1181.39s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (703.33s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (455.69s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (994.78s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (1224.48s)
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (2.22s)

--- SKIP: TestAccAWSSignerSigningJob_basic (7.57s)

--- SKIP: TestAccAWSSignerSigningProfile_basic (7.52s)
--- SKIP: TestAccAWSSignerSigningProfile_GenerateName (7.44s)
--- SKIP: TestAccAWSSignerSigningProfile_GenerateNameWithNamePrefix (1.85s)
--- SKIP: TestAccAWSSignerSigningProfile_SignatureValidityPeriod (7.35s)
--- SKIP: TestAccAWSSignerSigningProfile_tags (7.87s)

--- SKIP: TestAccAWSSignerSigningProfilePermission_basic (7.66s)
--- SKIP: TestAccAWSSignerSigningProfilePermission_GetSigningProfile (7.65s)
--- SKIP: TestAccAWSSignerSigningProfilePermission_StartSigningJob_GetSP (1.84s)
--- SKIP: TestAccAWSSignerSigningProfilePermission_StatementPrefix (1.86s)

--- PASS: TestAccDataSourceAWSLambdaFunction_alias (42.58s)
--- PASS: TestAccDataSourceAWSLambdaFunction_basic (34.49s)
--- PASS: TestAccDataSourceAWSLambdaFunction_environment (113.95s)
--- PASS: TestAccDataSourceAWSLambdaFunction_fileSystemConfig (961.20s)
--- PASS: TestAccDataSourceAWSLambdaFunction_layers (136.12s)
--- PASS: TestAccDataSourceAWSLambdaFunction_version (248.84s)
--- PASS: TestAccDataSourceAWSLambdaFunction_vpc (598.98s)

--- SKIP: TestAccDataSourceAWSSignerSigningJob_basic (7.44s)

--- SKIP: TestAccDataSourceAWSSignerSigningProfile_basic (7.37s)
```

* tests/service/signer: Fix terrafmt issue

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccDataSourceAWSSignerSigningJob_basic (29.41s)

--- PASS: TestAccAWSSignerSigningJob_basic (31.16s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- SKIP: TestAccDataSourceAWSSignerSigningJob_basic (2.08s)

--- SKIP: TestAccAWSSignerSigningJob_basic (2.09s)
```
@ghost
Copy link

ghost commented Dec 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pjaudiomv pjaudiomv pjaudiomv left review comments

@anGie44 anGie44 anGie44 approved these changes

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@santiagocardenas @rayjlinden @bflad @anGie44 @pjaudiomv