Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS AppFlow #16253

Closed
jasonstitt opened this issue Nov 17, 2020 · 13 comments
Closed

Support AWS AppFlow #16253

jasonstitt opened this issue Nov 17, 2020 · 13 comments
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/appflow Issues and PRs that pertain to the appflow service.

Comments

@jasonstitt
Copy link

jasonstitt commented Nov 17, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS AppFlow allows setting up integration points with various SaaS tools and AWS locations such as S3. This would be great to have in Terraform because of the repetitive and boilerplate nature of some of these setups - e.g. Salesforce connector setup is on a per-object (type) basis so there could be a ton of these.

New or Affected Resource(s)

  • aws_appflow_flow
  • aws_appflow_connector_profile

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

https://aws.amazon.com/blogs/aws/new-announcing-amazon-appflow/

https://docs.aws.amazon.com/appflow/1.0/APIReference/Welcome.html

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appflow-flow.html

@jasonstitt jasonstitt added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 17, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 17, 2020
@gdavison gdavison added new-resource Introduces a new resource. service/appflow Issues and PRs that pertain to the appflow service. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 17, 2020
@jverhoeks
Copy link
Contributor

Is there any progress on this?

@mrampf
Copy link

mrampf commented Feb 25, 2021

Any updates on this? Do you need any help for this since we have various customers asking for this support.

@ClemensSelbach
Copy link

ClemensSelbach commented Aug 4, 2021

are there any news on this topic... we need this asap!
we've also placed this demand an AWS appflow product owner side as well

@kaukiran
Copy link

Please help on the planned timeline/roadmap for the appflow release ?
We are waiting on this for a long time now

@ksharlandjiev
Copy link

Hi all.
I'm an AppFlow SME.
I speak with lots of customers daily, who wants to see amazon AppFlow support .

Is there anything I can help to speed up the process?
Please get in touch.

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@szemek
Copy link
Contributor

szemek commented Mar 27, 2022

Hi @breathingdust @zhelding
I'm trying to refresh a code from my old pull request #19543
New pull request is here #23892, but acceptance tests stopped working properly. Could you take a look and give me some hints? I appreciate any guidance on that.
Something is wrong with an implementation of GetConnectorProfile used by resourceConnectorProfileRead.

@ksharlandjiev
Copy link

Hey any update on this? Thanks

@AdamTylerLynch
Copy link
Collaborator

Nice job @zhelding ! 👏👏👏

@zhelding
Copy link
Contributor

Hi folks. With #24017 adding support for appflow_flow resources and #23892 adding support for appflow_connector_profile resources, we now have basic support for Amazon AppFlow!

Huge thanks to @szemek for his contributions.

Rendered docs for both appflow_flow and appflow_connector_profile are available on the Terraform Registry.

If any issues arise when using these resources, or if any additional AppFlow coverage / functionality is needed -- please open an additional issue describing the desired behavior.

@dalareo
Copy link

dalareo commented May 19, 2022

There is a bug in flow.go file, line 1119:

"task_properties": {
							Type:         schema.TypeMap,
							Optional:     true,
							ValidateFunc: validation.StringInSlice(appflow.OperatorPropertiesKeys_Values(), false),
							Elem: &schema.Schema{
								Type:         schema.TypeString,
								ValidateFunc: validation.All(validation.StringMatch(regexp.MustCompile(`\S+`), "must not contain any whitespace characters"), validation.StringLenBetween(0, 2048)),
							},

Map is validated against a string (OperatorPropertiesKeys_values()) so neither a map of strings or a string is accepted here. We are working in a PR for this.

@zhelding
Copy link
Contributor

Hi @dalareo: nice catch! Tracking bug with issue #24888.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/appflow Issues and PRs that pertain to the appflow service.
Projects
None yet
Development

No branches or pull requests