-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_datasync_agent: Add support for VPC Endpoints #16207
Conversation
d31a060
to
60ef8d4
Compare
60ef8d4
to
c69ff24
Compare
c69ff24
to
760488c
Compare
bf91ab4
to
d75f644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncAgent_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncAgent_ -timeout 180m
=== RUN TestAccAWSDataSyncAgent_basic
=== PAUSE TestAccAWSDataSyncAgent_basic
=== RUN TestAccAWSDataSyncAgent_disappears
=== PAUSE TestAccAWSDataSyncAgent_disappears
=== RUN TestAccAWSDataSyncAgent_AgentName
=== PAUSE TestAccAWSDataSyncAgent_AgentName
=== RUN TestAccAWSDataSyncAgent_Tags
=== PAUSE TestAccAWSDataSyncAgent_Tags
=== RUN TestAccAWSDataSyncAgent_VpcEndpointId
=== PAUSE TestAccAWSDataSyncAgent_VpcEndpointId
=== CONT TestAccAWSDataSyncAgent_basic
=== CONT TestAccAWSDataSyncAgent_Tags
=== CONT TestAccAWSDataSyncAgent_VpcEndpointId
=== CONT TestAccAWSDataSyncAgent_AgentName
=== CONT TestAccAWSDataSyncAgent_disappears
--- PASS: TestAccAWSDataSyncAgent_disappears (133.55s)
--- PASS: TestAccAWSDataSyncAgent_basic (161.01s)
--- PASS: TestAccAWSDataSyncAgent_Tags (188.41s)
--- PASS: TestAccAWSDataSyncAgent_AgentName (224.94s)
--- PASS: TestAccAWSDataSyncAgent_VpcEndpointId (328.06s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 331.019s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncAgent_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncAgent_ -timeout 180m
=== RUN TestAccAWSDataSyncAgent_basic
=== PAUSE TestAccAWSDataSyncAgent_basic
=== RUN TestAccAWSDataSyncAgent_disappears
=== PAUSE TestAccAWSDataSyncAgent_disappears
=== RUN TestAccAWSDataSyncAgent_AgentName
=== PAUSE TestAccAWSDataSyncAgent_AgentName
=== RUN TestAccAWSDataSyncAgent_Tags
=== PAUSE TestAccAWSDataSyncAgent_Tags
=== RUN TestAccAWSDataSyncAgent_VpcEndpointId
=== PAUSE TestAccAWSDataSyncAgent_VpcEndpointId
=== CONT TestAccAWSDataSyncAgent_basic
=== CONT TestAccAWSDataSyncAgent_Tags
=== CONT TestAccAWSDataSyncAgent_AgentName
=== CONT TestAccAWSDataSyncAgent_VpcEndpointId
=== CONT TestAccAWSDataSyncAgent_disappears
--- PASS: TestAccAWSDataSyncAgent_disappears (138.23s)
--- PASS: TestAccAWSDataSyncAgent_AgentName (156.87s)
--- PASS: TestAccAWSDataSyncAgent_basic (184.51s)
--- PASS: TestAccAWSDataSyncAgent_VpcEndpointId (204.57s)
--- PASS: TestAccAWSDataSyncAgent_Tags (207.91s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 210.851s
This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #9755
Release note for CHANGELOG:
Output from acceptance testing: