Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_catalog_table - add partition index support #16194

Merged
merged 3 commits into from
Nov 19, 2020
Merged

r/glue_catalog_table - add partition index support #16194

merged 3 commits into from
Nov 19, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16177

Release note for CHANGELOG:

resource_aws_glue_catalog_table - add partition index support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueCatalogTable_'
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (37.78s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (37.95s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (38.26s)
--- PASS: TestAccAWSGlueCatalogTable_basic (43.51s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (43.87s)
--- PASS: TestAccAWSGlueCatalogTable_disappears (44.23s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (44.54s)
--- PASS: TestAccAWSGlueCatalogTable_full (44.70s)
--- PASS: TestAccAWSGlueCatalogTable_recreates (51.15s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (72.68s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (73.56s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (75.05s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner November 14, 2020 12:25
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 14, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 14, 2020
ewbankkit
ewbankkit approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCatalogTable_partitionIndexes\|TestAccAWSGlueCatalogTable_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_partitionIndexes\|TestAccAWSGlueCatalogTable_basic -timeout 120m
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesSingle
--- PASS: TestAccAWSGlueCatalogTable_basic (20.78s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (20.91s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (20.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.997s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCatalogTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_ -timeout 120m
=== RUN   TestAccAWSGlueCatalogTable_recreates
=== PAUSE TestAccAWSGlueCatalogTable_recreates
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_recreates
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_disappears
2020/11/19 15:46:33 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/11/19 15:46:33 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/11/19 15:46:38 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/11/19 15:46:39 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSGlueCatalogTable_disappears (17.14s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (17.95s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (17.99s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (17.99s)
--- PASS: TestAccAWSGlueCatalogTable_basic (18.92s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (20.28s)
--- PASS: TestAccAWSGlueCatalogTable_full (20.58s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (20.86s)
--- PASS: TestAccAWSGlueCatalogTable_recreates (23.90s)
2020/11/19 15:46:51 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (30.19s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (31.30s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (32.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.035s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCatalogTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_ -timeout 120m
=== RUN   TestAccAWSGlueCatalogTable_recreates
=== PAUSE TestAccAWSGlueCatalogTable_recreates
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_recreates
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
2020/11/19 15:47:41 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSGlueCatalogTable_disappears (13.52s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (13.70s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (13.84s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (14.21s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (15.52s)
--- PASS: TestAccAWSGlueCatalogTable_full (15.63s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (15.63s)
--- PASS: TestAccAWSGlueCatalogTable_basic (15.66s)
--- PASS: TestAccAWSGlueCatalogTable_recreates (17.76s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (23.01s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (23.22s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (23.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.054s

@breathingdust breathingdust added this to the v3.17.0 milestone Nov 19, 2020
@breathingdust breathingdust merged commit 9e93f9b into hashicorp:master Nov 19, 2020
breathingdust added a commit that referenced this pull request Nov 19, 2020
@breathingdust
Update CHANGELOG.md for #16194
f161b4c
@ghost
Copy link

ghost commented Nov 24, 2020

This has been released in version 3.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
@DrFaust92 DrFaust92 deleted the r/glue_catalog_table_partition_index branch April 15, 2021 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.17.0
Development

Successfully merging this pull request may close these issues.

Partition indexes are not implemented in aws_glue_catalog_table
3 participants
@DrFaust92 @breathingdust @ewbankkit