aws_iot_topic rule update not adding error action

[shanmud]

Problem Description
We have a topic rule created without error action. We are trying to update the topic rule with error action. Terraform apply shown that the resource is successfully updated but in AWS console, the changes were not reflected. During the next plan, we could see the old stage(without error action)

Note: The error action added successfully when the resource deleted and recreated with terraform taint command. This needs to be done every time for the update in error action

[ewbankkit]

error_action changes are not correctly handled:

terraform-provider-aws/aws/resource_aws_iot_topic_rule.go

Lines 1201 to 1224 in 3d30951

	func resourceAwsIotTopicRuleUpdate(d *schema.ResourceData, meta interface{}) error {
	conn := meta.(*AWSClient).iotconn
	if d.HasChanges(
	"cloudwatch_alarm",
	"cloudwatch_metric",
	"description",
	"dynamodb",
	"dynamodbv2",
	"elasticsearch",
	"enabled",
	"firehose",
	"iot_analytics",
	"iot_events",
	"kinesis",
	"lambda",
	"republish",
	"s3",
	"step_functions",
	"sns",
	"sql",
	"sql_version",
	"sqs",
	) {

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.