Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EC2 rebalancing #16033

Closed
scalp42 opened this issue Nov 5, 2020 · 7 comments · Fixed by #16127
Closed

Support EC2 rebalancing #16033

scalp42 opened this issue Nov 5, 2020 · 7 comments · Fixed by #16127
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@scalp42
Copy link
Contributor

scalp42 commented Nov 5, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS introduced EC2 rebalancing for ASG, EC2 Fleet and Spot Fleet.

New or Affected Resource(s)

  • aws_autoscaling_group
  • aws_spot_fleet

References

See: https://aws.amazon.com/about-aws/whats-new/2020/11/introducing-ec2-instance-rebalance-recommendation-for-ec2-spot-instances/

Flag: https://docs.aws.amazon.com/autoscaling/ec2/userguide/capacity-rebalance.html

@scalp42 scalp42 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 5, 2020
@ghost ghost added service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. labels Nov 5, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 5, 2020
@ewbankkit
Copy link
Contributor

Requires AWS SDK v1.35.21:

@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 5, 2020

aws_autoscaling_group
resource "aws_autoscaling_group" "example" {
  capacity_rebalance = true
}
aws_ec2_fleet
resource "aws_ec2_fleet" "example" {
  spot_options {
    maintenance_strategies {
      capacity_rebalance {
        replacement_strategy = "launch"
      }
    }
  }
}
aws_spot_fleet_request
resource "aws_spot_fleet_request" "example" {
  spot_maintenance_strategies {
    capacity_rebalance {
      replacement_strategy = "launch"
    }
  }
}

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 5, 2020
@isaac88
Copy link

isaac88 commented Nov 9, 2020

Hello @ewbankkit,
Any updates regarding that ?

Thanks

@grigorov
Copy link

grigorov commented Nov 9, 2020

@ewbankkit #16085 is merged.

@ewbankkit
Copy link
Contributor

A PR to address this is forthcoming. The contributor is waiting on some formalities.

@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants