-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codeartifact resources tagging support #16006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_basic\|TestAccAWSCodeArtifactDomain_tags\|TestAccAWSCodeArtifactRepository_basic\|TestAccAWSCodeArtifactRepository_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_basic\|TestAccAWSCodeArtifactDomain_tags\|TestAccAWSCodeArtifactRepository_basic\|TestAccAWSCodeArtifactRepository_tags -timeout 120m
=== RUN TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN TestAccAWSCodeArtifactDomain_tags
=== PAUSE TestAccAWSCodeArtifactDomain_tags
=== RUN TestAccAWSCodeArtifactRepository_basic
=== PAUSE TestAccAWSCodeArtifactRepository_basic
=== RUN TestAccAWSCodeArtifactRepository_tags
=== PAUSE TestAccAWSCodeArtifactRepository_tags
=== CONT TestAccAWSCodeArtifactDomain_basic
=== CONT TestAccAWSCodeArtifactRepository_tags
=== CONT TestAccAWSCodeArtifactRepository_basic
=== CONT TestAccAWSCodeArtifactDomain_tags
--- PASS: TestAccAWSCodeArtifactDomain_basic (29.93s)
--- PASS: TestAccAWSCodeArtifactRepository_basic (32.68s)
--- PASS: TestAccAWSCodeArtifactDomain_tags (63.67s)
--- PASS: TestAccAWSCodeArtifactRepository_tags (70.49s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 70.552s
Co-authored-by: Kit Ewbank <[email protected]>
LGTM 🚀 Thanks @DrFaust92 Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_basic\|TestAccAWSCodeArtifactDomain_tags\|TestAccAWSCodeArtifactRepository_basic\|TestAccAWSCodeArtifactRepository_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_basic\|TestAccAWSCodeArtifactDomain_tags\|TestAccAWSCodeArtifactRepository_basic\|TestAccAWSCodeArtifactRepository_tags -timeout 120m
=== RUN TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN TestAccAWSCodeArtifactDomain_tags
=== PAUSE TestAccAWSCodeArtifactDomain_tags
=== RUN TestAccAWSCodeArtifactRepository_basic
=== PAUSE TestAccAWSCodeArtifactRepository_basic
=== RUN TestAccAWSCodeArtifactRepository_tags
=== PAUSE TestAccAWSCodeArtifactRepository_tags
=== CONT TestAccAWSCodeArtifactDomain_basic
=== CONT TestAccAWSCodeArtifactRepository_tags
=== CONT TestAccAWSCodeArtifactRepository_basic
=== CONT TestAccAWSCodeArtifactDomain_tags
2020/11/04 13:52:28 [DEBUG] Waiting for state to become: [success]
--- PASS: TestAccAWSCodeArtifactDomain_basic (20.36s)
--- PASS: TestAccAWSCodeArtifactRepository_basic (22.66s)
--- PASS: TestAccAWSCodeArtifactDomain_tags (53.24s)
--- PASS: TestAccAWSCodeArtifactRepository_tags (54.53s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 56.089s |
This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #15958
Release note for CHANGELOG:
Output from acceptance testing: