Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Stabilization of remaining data source id attributes and enable R015, R016, R017 linters #15896

Merged
merged 2 commits into from
Oct 29, 2020
Merged

provider: Stabilization of remaining data source id attributes and enable R015, R016, R017 linters #15896

merged 2 commits into from
Oct 29, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 28, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14579
Reference: #15399

Release note for CHANGELOG:

NOTES

* data-source/aws_autoscaling_groups: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_caller_identity: The `id` attribute has changed to the ID of the AWS Account. The first apply of this updated data source may show this difference.
* data-source/aws_ebs_snapshot_ids: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_ebs_volumes: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_ec2_coip_pools: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_ec2_instance_type_offerings: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_ec2_local_gateway_route_tables: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_ec2_local_gateway_virtual_interface_groups: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_ec2_local_gateways: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_ec2_spot_price: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_efs_access_points: The `id` attribute has changed to the EFS File System identifier. The first apply of this updated data source may show this difference.
* data-source/aws_glue_script: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_inspector_rules_packages: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_instances: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_kms_ciphertext: The `id` attribute has changed to the KMS Key. The first apply of this updated data source may show this difference.
* data-source/aws_network_acls: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_network_interfaces: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_organizations_organizational_units: The `id` attribute has changed to the parent identifier. The first apply of this updated data source may show this difference.
* data-source/aws_outposts_outposts: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_outposts_sites: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_route_tables: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_route53_resolver_rules: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_s3_bucket_objects: The `id` attribute has changed to the name of the S3 Bucket. The first apply of this updated data source may show this difference.
* data-source/aws_security_groups: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_vpc_peering_connections: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.
* data-source/aws_vpcs: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.

BUG FIXES

* data-source/aws_autoscaling_groups: Prevent plan differences with the `id` attribute
* data-source/aws_caller_identity: Prevent plan differences with the `id` attribute
* data-source/aws_ebs_snapshot_ids: Prevent plan differences with the `id` attribute
* data-source/aws_ebs_volumes: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_coip_pools: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_instance_type_offerings: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_local_gateway_route_tables: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_local_gateway_virtual_interface_groups: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_local_gateways: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_spot_price: Prevent plan differences with the `id` attribute
* data-source/aws_efs_access_points: Prevent plan differences with the `id` attribute
* data-source/aws_glue_script: Prevent plan differences with the `id` attribute
* data-source/aws_inspector_rules_packages: Prevent plan differences with the `id` attribute
* data-source/aws_instances: Prevent plan differences with the `id` attribute
* data-source/aws_kms_ciphertext: Prevent plan differences with the `id` attribute
* data-source/aws_network_acls: Prevent plan differences with the `id` attribute
* data-source/aws_network_interfaces: Prevent plan differences with the `id` attribute
* data-source/aws_organizations_organizational_units: Prevent plan differences with the `id` attribute
* data-source/aws_outposts_outposts: Prevent plan differences with the `id` attribute
* data-source/aws_outposts_sites: Prevent plan differences with the `id` attribute
* data-source/aws_route_tables: Prevent plan differences with the `id` attribute
* data-source/aws_route53_resolver_rules: Prevent plan differences with the `id` attribute
* data-source/aws_s3_bucket_objects: Prevent plan differences with the `id` attribute
* data-source/aws_security_groups: Prevent plan differences with the `id` attribute
* data-source/aws_vpc_peering_connections: Prevent plan differences with the `id` attribute
* data-source/aws_vpcs: Prevent plan differences with the `id` attribute

Output from acceptance testing:

--- PASS: TestAccAWSAutoscalingAttachment_albTargetGroup (111.36s)
--- PASS: TestAccAWSAutoscalingAttachment_elb (118.66s)

--- PASS: TestAccAWSAutoscalingGroups_basic (162.22s)

--- PASS: TestAccAWSCallerIdentity_basic (55.69s)

--- PASS: TestAccAWSEBSEncryptionByDefault_basic (52.71s)

--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (57.28s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (58.79s)

--- PASS: TestAccAwsEc2SpotPriceDataSource_basic (54.47s)
--- PASS: TestAccAwsEc2SpotPriceDataSource_Filter (59.40s)

--- PASS: TestAccAWSELBAttachment_basic (185.93s)
--- PASS: TestAccAWSELBAttachment_drift (113.04s)

--- PASS: TestAccAWSInspectorRulesPackages_basic (58.00s)

--- PASS: TestAccAWSInstancesDataSource_basic (137.19s)
--- PASS: TestAccAWSInstancesDataSource_instance_state_names (122.56s)
--- PASS: TestAccAWSInstancesDataSource_tags (120.98s)

--- PASS: TestAccDataSourceAwsEbsSnapshotIds_basic (92.82s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_empty (57.58s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_sorted (195.34s)

--- PASS: TestAccDataSourceAwsEbsVolumes_basic (178.56s)

--- PASS: TestAccDataSourceAWSEFSAccessPoints_basic (71.87s)

--- PASS: TestAccDataSourceAWSGlueScript_Language_Python (57.14s)
--- PASS: TestAccDataSourceAWSGlueScript_Language_Scala (57.67s)

--- PASS: TestAccDataSourceAwsKmsCiphertext_basic (61.22s)
--- PASS: TestAccDataSourceAwsKmsCiphertext_validate (60.99s)
--- PASS: TestAccDataSourceAwsKmsCiphertext_validate_withContext (60.77s)

--- PASS: TestAccDataSourceAwsNetworkAcls_basic (112.54s)
--- PASS: TestAccDataSourceAwsNetworkAcls_Filter (62.55s)
--- PASS: TestAccDataSourceAwsNetworkAcls_Tags (58.95s)
--- PASS: TestAccDataSourceAwsNetworkAcls_VpcID (60.22s)

--- PASS: TestAccDataSourceAwsNetworkInterfaces_Filter (95.49s)
--- PASS: TestAccDataSourceAwsNetworkInterfaces_Tags (97.05s)

--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (57.40s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (264.98s)

--- PASS: TestAccDataSourceAwsRouteTables_basic (120.92s)

--- PASS: TestAccDataSourceAWSS3BucketObjects_all (120.73s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_basic (122.61s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_basicViaAccessPoint (122.87s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_encoded (115.55s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_fetchOwner (102.52s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_maxKeys (100.50s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_prefixes (117.61s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_startAfter (102.55s)

--- PASS: TestAccDataSourceAwsSecurityGroups_filter (70.25s)
--- PASS: TestAccDataSourceAwsSecurityGroups_tag (68.53s)

--- PASS: TestAccDataSourceAwsVpcPeeringConnections_basic (70.67s)

--- PASS: TestAccDataSourceAwsVpcs_basic (65.12s)
--- PASS: TestAccDataSourceAwsVpcs_filters (56.35s)
--- PASS: TestAccDataSourceAwsVpcs_tags (58.15s)

--- SKIP: TestAccAWSOutpostsOutpostsDataSource_basic (2.12s)

--- SKIP: TestAccAWSOutpostsSitesDataSource_basic (1.42s)

--- SKIP: TestAccDataSourceAwsEc2CoipPools_basic (15.89s)
--- SKIP: TestAccDataSourceAwsEc2CoipPools_Filter (14.35s)

--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic (14.72s)
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter (2.24s)

--- SKIP: TestAccDataSourceAwsEc2LocalGateways_basic (2.51s)

--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic (3.57s)
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter (2.13s)
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags (1.99s)

@bflad bflad added bug Addresses a defect in current functionality. linter Pertains to changes to or issues with the various linters. labels Oct 28, 2020
@ghost ghost added size/M Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/elb Issues and PRs that pertain to the elb service. service/glue Issues and PRs that pertain to the glue service. service/inspector Issues and PRs that pertain to the inspector service. service/kms Issues and PRs that pertain to the kms service. service/organizations Issues and PRs that pertain to the organizations service. service/outposts Issues and PRs that pertain to the outposts service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. service/sts Issues and PRs that pertain to the sts service. labels Oct 28, 2020
@bflad
provider: Stabilization of remaining data source id attributes and en…
d5b4625 
…able R015, R016, R017 linters

Reference: #14579

Changes:

* data-source/aws_autoscaling_groups: Prevent plan differences with the `id` attribute
* data-source/aws_caller_identity: Prevent plan differences with the `id` attribute
* data-source/aws_ebs_snapshot_ids: Prevent plan differences with the `id` attribute
* data-source/aws_ebs_volumes: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_coip_pools: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_instance_type_offerings: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_local_gateway_route_tables: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_local_gateway_virtual_interface_groups: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_local_gateways: Prevent plan differences with the `id` attribute
* data-source/aws_ec2_spot_price: Prevent plan differences with the `id` attribute
* data-source/aws_efs_access_points: Prevent plan differences with the `id` attribute
* data-source/aws_glue_script: Prevent plan differences with the `id` attribute
* data-source/aws_inspector_rules_packages: Prevent plan differences with the `id` attribute
* data-source/aws_instances: Prevent plan differences with the `id` attribute
* data-source/aws_kms_ciphertext: Prevent plan differences with the `id` attribute
* data-source/aws_network_acls: Prevent plan differences with the `id` attribute
* data-source/aws_network_interfaces: Prevent plan differences with the `id` attribute
* data-source/aws_organizations_organizational_units: Prevent plan differences with the `id` attribute
* data-source/aws_outposts_outposts: Prevent plan differences with the `id` attribute
* data-source/aws_outposts_sites: Prevent plan differences with the `id` attribute
* data-source/aws_route_tables: Prevent plan differences with the `id` attribute
* data-source/aws_route53_resolver_rules: Prevent plan differences with the `id` attribute
* data-source/aws_s3_bucket_objects: Prevent plan differences with the `id` attribute
* data-source/aws_security_groups: Prevent plan differences with the `id` attribute
* data-source/aws_vpc_peering_connections: Prevent plan differences with the `id` attribute
* data-source/aws_vpcs: Prevent plan differences with the `id` attribute

Output from acceptance testing:

```
--- PASS: TestAccAWSAutoscalingAttachment_albTargetGroup (111.36s)
--- PASS: TestAccAWSAutoscalingAttachment_elb (118.66s)

--- PASS: TestAccAWSAutoscalingGroups_basic (162.22s)

--- PASS: TestAccAWSCallerIdentity_basic (55.69s)

--- PASS: TestAccAWSEBSEncryptionByDefault_basic (52.71s)

--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (57.28s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (58.79s)

--- PASS: TestAccAwsEc2SpotPriceDataSource_basic (54.47s)
--- PASS: TestAccAwsEc2SpotPriceDataSource_Filter (59.40s)

--- PASS: TestAccAWSELBAttachment_basic (185.93s)
--- PASS: TestAccAWSELBAttachment_drift (113.04s)

--- PASS: TestAccAWSInspectorRulesPackages_basic (58.00s)

--- PASS: TestAccAWSInstancesDataSource_basic (137.19s)
--- PASS: TestAccAWSInstancesDataSource_instance_state_names (122.56s)
--- PASS: TestAccAWSInstancesDataSource_tags (120.98s)

--- PASS: TestAccDataSourceAwsEbsSnapshotIds_basic (92.82s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_empty (57.58s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_sorted (195.34s)

--- PASS: TestAccDataSourceAwsEbsVolumes_basic (178.56s)

--- PASS: TestAccDataSourceAWSEFSAccessPoints_basic (71.87s)

--- PASS: TestAccDataSourceAWSGlueScript_Language_Python (57.14s)
--- PASS: TestAccDataSourceAWSGlueScript_Language_Scala (57.67s)

--- PASS: TestAccDataSourceAwsKmsCiphertext_basic (61.22s)
--- PASS: TestAccDataSourceAwsKmsCiphertext_validate (60.99s)
--- PASS: TestAccDataSourceAwsKmsCiphertext_validate_withContext (60.77s)

--- PASS: TestAccDataSourceAwsNetworkAcls_basic (112.54s)
--- PASS: TestAccDataSourceAwsNetworkAcls_Filter (62.55s)
--- PASS: TestAccDataSourceAwsNetworkAcls_Tags (58.95s)
--- PASS: TestAccDataSourceAwsNetworkAcls_VpcID (60.22s)

--- PASS: TestAccDataSourceAwsNetworkInterfaces_Filter (95.49s)
--- PASS: TestAccDataSourceAwsNetworkInterfaces_Tags (97.05s)

--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (57.40s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (264.98s)

--- PASS: TestAccDataSourceAwsRouteTables_basic (120.92s)

--- PASS: TestAccDataSourceAWSS3BucketObjects_all (120.73s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_basic (122.61s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_basicViaAccessPoint (122.87s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_encoded (115.55s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_fetchOwner (102.52s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_maxKeys (100.50s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_prefixes (117.61s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_startAfter (102.55s)

--- PASS: TestAccDataSourceAwsSecurityGroups_filter (70.25s)
--- PASS: TestAccDataSourceAwsSecurityGroups_tag (68.53s)

--- PASS: TestAccDataSourceAwsVpcPeeringConnections_basic (70.67s)

--- PASS: TestAccDataSourceAwsVpcs_basic (65.12s)
--- PASS: TestAccDataSourceAwsVpcs_filters (56.35s)
--- PASS: TestAccDataSourceAwsVpcs_tags (58.15s)

--- SKIP: TestAccAWSOutpostsOutpostsDataSource_basic (2.12s)

--- SKIP: TestAccAWSOutpostsSitesDataSource_basic (1.42s)

--- SKIP: TestAccDataSourceAwsEc2CoipPools_basic (15.89s)
--- SKIP: TestAccDataSourceAwsEc2CoipPools_Filter (14.35s)

--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic (14.72s)
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter (2.24s)

--- SKIP: TestAccDataSourceAwsEc2LocalGateways_basic (2.51s)

--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic (3.57s)
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter (2.13s)
--- SKIP: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags (1.99s)
```
@bflad bflad force-pushed the b-remaining-unstable-ids branch from e0af107 to d5b4625 Compare October 29, 2020 02:27
@bflad bflad marked this pull request as ready for review October 29, 2020 02:28
@bflad bflad requested a review from a team October 29, 2020 02:28
anGie44
anGie44 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌 just small comments re: the kms data source ID change

@bflad
Copy link
Contributor Author

bflad commented Oct 29, 2020

Verified acceptance testing after aws_kms_ciphertext data source update:

--- PASS: TestAccDataSourceAwsKmsCiphertext_validate (17.86s)
--- PASS: TestAccDataSourceAwsKmsCiphertext_basic (18.17s)
--- PASS: TestAccDataSourceAwsKmsCiphertext_validate_withContext (18.65s)

@bflad bflad added this to the v3.13.0 milestone Oct 29, 2020
@bflad bflad merged commit 6f4442a into master Oct 29, 2020
@bflad bflad deleted the b-remaining-unstable-ids branch October 29, 2020 18:33
bflad added a commit that referenced this pull request Oct 29, 2020
@bflad
Update CHANGELOG for #15896
b2cbbd5
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/elb Issues and PRs that pertain to the elb service. service/glue Issues and PRs that pertain to the glue service. service/inspector Issues and PRs that pertain to the inspector service. service/kms Issues and PRs that pertain to the kms service. service/organizations Issues and PRs that pertain to the organizations service. service/outposts Issues and PRs that pertain to the outposts service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. service/sts Issues and PRs that pertain to the sts service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.

Data sources with non-deterministic IDs show perpetual diff with Terraform 0.13 (R015, R016, R017 linters)
2 participants
@bflad @anGie44