resource/aws_lb_cookie_stickiness_policy: Do not return error from Delete when resource not found

[gdavison]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When trying to delete a resource, we should not treat it as an error if the resource has already been deleted. In Terraform 0.12 and 0.13, this is not a problem, since state is refreshed and the resource is removed from state by the Read function. Starting with Terraform 0.14, the Read function is not called for resources removed from the configuration.

Affected Resource

• aws_lb_cookie_stickiness_policy

[bflad]

While this should still get fixed from a code correctness standpoint, I've dropped the terraform-0.14 label since Terraform 0.14.0-beta2 still implements refresh before deletion. The out of band deletion and resource refresh without error testing is handled by disappears acceptance testing, so this only leaves this problem for race conditions where refresh doesn't occur automatically (may not be a thing after 0.14?) or due to an error in Terraform CLI ordering handling which should be filed as bug (e.g. if deposed instance handling doesn't refresh like it didn't previously as seen in #12900).

[bflad]

Created a meta-tracking issue: #15945

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.