Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS Support Service IPv4 range #15505

Closed
jwenz723 opened this issue Oct 5, 2020 · 5 comments · Fixed by #15518
Closed

EKS Support Service IPv4 range #15505

jwenz723 opened this issue Oct 5, 2020 · 5 comments · Fixed by #15518
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/eks Issues and PRs that pertain to the eks service.
Milestone

Comments

@jwenz723
Copy link

jwenz723 commented Oct 5, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add support in aws_eks_cluster for the new Service IPv4 range feature of EKS clusters: https://aws.amazon.com/about-aws/whats-new/2020/10/amazon-eks-supports-configurable-kubernetes-service-ip-address-range/

New or Affected Resource(s)

  • aws_eks_cluster

Potential Terraform Configuration

resource "aws_eks_cluster" "cluster" {
  name     = var.cluster-name
  serviceIpv4Cidr = "10.0.0.0/16" // something like this is what I would imagine
}

References

I'm not aware of any other open issues for this feature.

@jwenz723 jwenz723 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 5, 2020
@ghost ghost added the service/eks Issues and PRs that pertain to the eks service. label Oct 5, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 5, 2020
@anGie44 anGie44 added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 5, 2020
@anGie44
Copy link
Contributor

anGie44 commented Oct 5, 2020

hi @jwenz723, thank you for creating this issue! To follow along the AWS API, just noting here that this new argument service_ipv4_cidr should also appear w/in it's parent argument kubernetes_network_config, with an updated potential config:

resource "aws_eks_cluster" "cluster" {
  name     = var.cluster-name
  kubernetes_network_config {
    service_ipv4_cidr = "10.0.0.0/16" // something like this is what I would imagine
}

Reference: https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateCluster.html

@philnichol
Copy link
Contributor

@anGie44 Mind if I have a crack at that?

@anGie44
Copy link
Contributor

anGie44 commented Nov 30, 2020

This feature has been merged and will release with v3.19.0 of the terraform aws provider, likely out this Thursday.

@ghost
Copy link

ghost commented Dec 1, 2020

This has been released in version 3.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants