Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_s3_bucket_object: Remove "bucket" from resource name #15458

Closed
YakDriver opened this issue Oct 2, 2020 · 3 comments · Fixed by #22776
Closed

r/aws_s3_bucket_object: Remove "bucket" from resource name #15458

YakDriver opened this issue Oct 2, 2020 · 3 comments · Fixed by #22776
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@YakDriver
Copy link
Member

YakDriver commented Oct 2, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

aws_s3_bucket_object should be called aws_s3_object because:

  1. "bucket" does not add information since every S3 object exists in a bucket: "S3 bucket object" does not convey more information or improve clarity over "S3 object"
  2. Extraneous words are verbose
  3. Removing "bucket" aligns the AWS provider with the API which never uses "bucket object"

All AWS SDK Go "object" operations none of which has "bucket object":

CopyObject	
DeleteObject	
DeleteObjectTagging	
DeleteObjects	
GetObject	
GetObjectAcl	
GetObjectLegalHold	
GetObjectLockConfiguration	
GetObjectRetention	
GetObjectTagging	
GetObjectTorrent	
HeadObject	
ListObjects
ListObjectsV2
PutObject	
PutObjectAcl	
PutObjectLegalHold	
PutObjectLockConfiguration	
PutObjectRetention	
PutObjectTagging	
RestoreObject	
SelectObjectContent	

New or Affected Resource(s)

  • aws_s3_bucket_object

Potential Terraform Configuration

resource "aws_s3_object" "object" {
  bucket = aws_s3_bucket.test.bucket
  key    = "nyckeln"
}

References

@YakDriver YakDriver added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 2, 2020
@ghost ghost added the service/s3 Issues and PRs that pertain to the s3 service. label Oct 2, 2020
@YakDriver YakDriver added technical-debt Addresses areas of the codebase that need refactoring or redesign. breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. labels Oct 2, 2020
@ewbankkit
Copy link
Contributor

What about adding an aws_s3_object_version resource?
In a versioned S3 bucket aws_s3_object represents the latest version of the object and there are cases when it would be useful to manage a specific version.
One downside is that it will be confusing to have both aws_s3_object and aws_s3_object_version resources that potentially manage the same S3 object.

@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants