Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_db_cluster_snapshot: Add validation for db_cluster_snaps… #15132

Merged

Conversation

angelabad
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15096

Release note for CHANGELOG:

resource/aws_db_cluster_snapshot: Add validation for db_cluster_snapshot_identifier

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDBClusterSnapshot_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBClusterSnapshot_basic -timeout 120m
=== RUN   TestAccAWSDBClusterSnapshot_basic
=== PAUSE TestAccAWSDBClusterSnapshot_basic
=== CONT  TestAccAWSDBClusterSnapshot_basic
--- PASS: TestAccAWSDBClusterSnapshot_basic (231.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	231.635s

...

@angelabad angelabad requested a review from a team September 12, 2020 15:09
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. needs-triage Waiting for first response or review from a maintainer. labels Sep 12, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 14, 2020
@bflad bflad self-assigned this Sep 14, 2020
@bflad bflad added this to the v3.7.0 milestone Sep 14, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, @angelabad 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDBClusterSnapshot_basic (177.55s)
--- PASS: TestAccAWSDBClusterSnapshot_Tags (194.42s)

@bflad bflad merged commit 8e7ed4d into hashicorp:master Sep 14, 2020
bflad added a commit that referenced this pull request Sep 14, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 3.7.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@angelabad angelabad deleted the b-db_cluster_snapshot_identifier-validation branch September 25, 2020 07:07
@ghost
Copy link

ghost commented Oct 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_db_cluster_snapshot: Provider produced inconsistent result after apply
2 participants