Add cidrs attribute to aws_lightsail_instance_public_ports resource

[kurtmc]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Add cidrs attribute to aws_lightsail_instance_public_ports resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLightsailInstancePublicPorts'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLightsailInstancePublicPorts -timeout 180m
=== RUN   TestAccAWSLightsailInstancePublicPorts_basic
=== PAUSE TestAccAWSLightsailInstancePublicPorts_basic
=== RUN   TestAccAWSLightsailInstancePublicPorts_multiple
=== PAUSE TestAccAWSLightsailInstancePublicPorts_multiple
=== RUN   TestAccAWSLightsailInstancePublicPorts_cidrs
=== PAUSE TestAccAWSLightsailInstancePublicPorts_cidrs
=== CONT  TestAccAWSLightsailInstancePublicPorts_basic
=== CONT  TestAccAWSLightsailInstancePublicPorts_cidrs
=== CONT  TestAccAWSLightsailInstancePublicPorts_multiple
--- PASS: TestAccAWSLightsailInstancePublicPorts_cidrs (71.71s)
--- PASS: TestAccAWSLightsailInstancePublicPorts_multiple (74.38s)
--- PASS: TestAccAWSLightsailInstancePublicPorts_basic (93.91s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       93.955s

[YakDriver]

@kurtmc Thank you for this PR! Some of this functionality will be merged as part of #8611. However, please consider rebasing and adding the additional attributes after that merges. Thank you!

[kurtmc]

@YakDriver Awesome! Thanks for the heads up.

[kurtmc]

@YakDriver I have rebased now, and just added my cidrs attribute to the resource that exists in the main branch , but I am having trouble with the acceptance tests.

[YakDriver]

Looks great! @kurtmc Thank you! 🎉

Acceptance tests on commercial:

--- PASS: TestAccAWSLightsailInstancePublicPorts_basic (44.70s)
--- PASS: TestAccAWSLightsailInstancePublicPorts_cidrs (55.74s)
--- PASS: TestAccAWSLightsailInstancePublicPorts_multiple (58.41s)

Acceptance tests on GovCloud:

--- SKIP: TestAccAWSLightsailInstancePublicPorts_basic (1.29s)
--- SKIP: TestAccAWSLightsailInstancePublicPorts_cidrs (1.29s)
--- SKIP: TestAccAWSLightsailInstancePublicPorts_multiple (1.29s)

[YakDriver]

@kurtmc Rather than perform the sorts, I switched cidrs to type schema.TypeSet. It seems to work okay. I'm not 100% certain AWS will always provide the CIDRs in the same order so the acceptance test may flaky fail every now and then. I tried it many times in a row and always got the same order. The resource itself won't show diffs based on order since it is a set but since the test has a hardcoded index, there's the possibility of issues.

[ghost]

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!