r/aws_cloudwatch_log_group: Add validation for retention_in_days

[shuheiktgw]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

r/aws_cloudwatch_log_group: Add validation for retention_in_days

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchLogGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchLogGroup -timeout 120m
=== RUN   TestAccAWSCloudWatchLogGroup_basic
=== PAUSE TestAccAWSCloudWatchLogGroup_basic
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix
=== PAUSE TestAccAWSCloudWatchLogGroup_namePrefix
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix_retention
=== PAUSE TestAccAWSCloudWatchLogGroup_namePrefix_retention
=== RUN   TestAccAWSCloudWatchLogGroup_generatedName
=== PAUSE TestAccAWSCloudWatchLogGroup_generatedName
=== RUN   TestAccAWSCloudWatchLogGroup_retentionPolicy
=== PAUSE TestAccAWSCloudWatchLogGroup_retentionPolicy
=== RUN   TestAccAWSCloudWatchLogGroup_multiple
=== PAUSE TestAccAWSCloudWatchLogGroup_multiple
=== RUN   TestAccAWSCloudWatchLogGroup_disappears
=== PAUSE TestAccAWSCloudWatchLogGroup_disappears
=== RUN   TestAccAWSCloudWatchLogGroup_tagging
=== PAUSE TestAccAWSCloudWatchLogGroup_tagging
=== RUN   TestAccAWSCloudWatchLogGroup_kmsKey
=== PAUSE TestAccAWSCloudWatchLogGroup_kmsKey
=== CONT  TestAccAWSCloudWatchLogGroup_basic
=== CONT  TestAccAWSCloudWatchLogGroup_multiple
=== CONT  TestAccAWSCloudWatchLogGroup_tagging
=== CONT  TestAccAWSCloudWatchLogGroup_generatedName
=== CONT  TestAccAWSCloudWatchLogGroup_kmsKey
=== CONT  TestAccAWSCloudWatchLogGroup_namePrefix_retention
=== CONT  TestAccAWSCloudWatchLogGroup_retentionPolicy
=== CONT  TestAccAWSCloudWatchLogGroup_disappears
=== CONT  TestAccAWSCloudWatchLogGroup_namePrefix
    TestAccAWSCloudWatchLogGroup_disappears: resource_aws_cloudwatch_log_group_test.go:284: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCloudWatchLogGroup_disappears (42.38s)
--- PASS: TestAccAWSCloudWatchLogGroup_basic (54.09s)
--- PASS: TestAccAWSCloudWatchLogGroup_generatedName (55.71s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (56.98s)
--- PASS: TestAccAWSCloudWatchLogGroup_multiple (57.81s)
--- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (80.57s)
--- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (81.99s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (82.39s)
--- PASS: TestAccAWSCloudWatchLogGroup_tagging (125.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	127.777s
...

I noticed CloudWatch Log Group's retentionInDays has a list of possible values (ref) but its validation is missing. As a result, a user cannot tell if the value is valid or not until she applies the change. It would be nice if we have validation for it.

Thank you for your review! 👍

[bflad]

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSCloudWatchLogGroup_disappears (12.92s)
--- PASS: TestAccAWSCloudWatchLogGroup_basic (18.01s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (18.54s)
--- PASS: TestAccAWSCloudWatchLogGroup_generatedName (18.63s)
--- PASS: TestAccAWSCloudWatchLogGroup_multiple (19.47s)
--- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (28.45s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (29.61s)
--- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (33.05s)
--- PASS: TestAccAWSCloudWatchLogGroup_tagging (47.03s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSCloudWatchLogGroup_disappears (16.57s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (21.12s)
--- PASS: TestAccAWSCloudWatchLogGroup_basic (21.93s)
--- PASS: TestAccAWSCloudWatchLogGroup_generatedName (22.74s)
--- PASS: TestAccAWSCloudWatchLogGroup_multiple (25.08s)
--- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (34.93s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (35.11s)
--- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (38.85s)
--- PASS: TestAccAWSCloudWatchLogGroup_tagging (57.51s)

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!