Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CodeBuild BuildBatchConfig #14534

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Support CodeBuild BuildBatchConfig #14534

merged 2 commits into from
Apr 29, 2021

Conversation

shuheiktgw
Copy link
Collaborator

@shuheiktgw shuheiktgw commented Aug 10, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14472

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeBuildProject_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildProject_ -timeout 180m
=== RUN   TestAccAWSCodeBuildProject_basic
=== PAUSE TestAccAWSCodeBuildProject_basic
=== RUN   TestAccAWSCodeBuildProject_BadgeEnabled
=== PAUSE TestAccAWSCodeBuildProject_BadgeEnabled
=== RUN   TestAccAWSCodeBuildProject_BuildTimeout
=== PAUSE TestAccAWSCodeBuildProject_BuildTimeout
=== RUN   TestAccAWSCodeBuildProject_QueuedTimeout
=== PAUSE TestAccAWSCodeBuildProject_QueuedTimeout
=== RUN   TestAccAWSCodeBuildProject_Cache
=== PAUSE TestAccAWSCodeBuildProject_Cache
=== RUN   TestAccAWSCodeBuildProject_Description
=== PAUSE TestAccAWSCodeBuildProject_Description
=== RUN   TestAccAWSCodeBuildProject_SourceVersion
=== PAUSE TestAccAWSCodeBuildProject_SourceVersion
=== RUN   TestAccAWSCodeBuildProject_EncryptionKey
=== PAUSE TestAccAWSCodeBuildProject_EncryptionKey
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value
=== RUN   TestAccAWSCodeBuildProject_Environment_Certificate
=== PAUSE TestAccAWSCodeBuildProject_Environment_Certificate
=== RUN   TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
=== PAUSE TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
=== RUN   TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== PAUSE TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== RUN   TestAccAWSCodeBuildProject_BuildBatchConfig
=== PAUSE TestAccAWSCodeBuildProject_BuildBatchConfig
=== RUN   TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== PAUSE TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== RUN   TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub
=== PAUSE TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub
=== RUN   TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_InsecureSSL
=== PAUSE TestAccAWSCodeBuildProject_Source_InsecureSSL
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== RUN   TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_Type_S3
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_S3
=== RUN   TestAccAWSCodeBuildProject_Source_Type_NoSource
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_NoSource
=== RUN   TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== RUN   TestAccAWSCodeBuildProject_Tags
=== PAUSE TestAccAWSCodeBuildProject_Tags
=== RUN   TestAccAWSCodeBuildProject_VpcConfig
=== PAUSE TestAccAWSCodeBuildProject_VpcConfig
=== RUN   TestAccAWSCodeBuildProject_WindowsServer2019Container
=== PAUSE TestAccAWSCodeBuildProject_WindowsServer2019Container
=== RUN   TestAccAWSCodeBuildProject_ARMContainer
=== PAUSE TestAccAWSCodeBuildProject_ARMContainer
=== RUN   TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
=== RUN   TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Location
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Location
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Name
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Name
=== RUN   TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== RUN   TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Packaging
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Packaging
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Path
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Path
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Type
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Type
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Name
    provider_test.go:55: Currently no solution to allow updates on name attribute
--- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s)
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== PAUSE TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== CONT  TestAccAWSCodeBuildProject_basic
=== CONT  TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Packaging
=== CONT  TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== CONT  TestAccAWSCodeBuildProject_VpcConfig
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Path
=== CONT  TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Name
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Location
=== CONT  TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== CONT  TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== CONT  TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
=== CONT  TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== CONT  TestAccAWSCodeBuildProject_ARMContainer
=== CONT  TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== CONT  TestAccAWSCodeBuildProject_WindowsServer2019Container
=== CONT  TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== CONT  TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== CONT  TestAccAWSCodeBuildProject_WindowsServer2019Container
    resource_aws_codebuild_project_test.go:1326: Step 1/2 error: Error running apply: exit status 1

        Error: Error creating CodeBuild project: InvalidInputException: Region ap-northeast-1 is not supported for WINDOWS_SERVER_2019_CONTAINER

          on terraform_plugin_test.tf line 64, in resource "aws_codebuild_project" "test":
          64: resource "aws_codebuild_project" "test" {


--- FAIL: TestAccAWSCodeBuildProject_WindowsServer2019Container (69.43s)
=== CONT  TestAccAWSCodeBuildProject_Tags
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (155.49s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
--- PASS: TestAccAWSCodeBuildProject_ARMContainer (156.02s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_NoSource
--- PASS: TestAccAWSCodeBuildProject_basic (156.03s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_S3
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (156.53s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (156.53s)
=== CONT  TestAccAWSCodeBuildProject_BuildBatchConfig
=== CONT  TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (177.31s)
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (236.69s)
=== CONT  TestAccAWSCodeBuildProject_LogsConfig_S3Logs
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (104.18s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (273.23s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (273.24s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (273.28s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (274.43s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (274.74s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (275.41s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (275.42s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (275.42s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (275.57s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
=== CONT  TestAccAWSCodeBuildProject_Environment_Certificate
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (275.58s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (277.86s)
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Type
--- PASS: TestAccAWSCodeBuildProject_Tags (234.66s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (149.20s)
=== CONT  TestAccAWSCodeBuildProject_BuildTimeout
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (150.51s)
=== CONT  TestAccAWSCodeBuildProject_Cache
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (156.23s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (365.63s)
=== CONT  TestAccAWSCodeBuildProject_EncryptionKey
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (142.62s)
=== CONT  TestAccAWSCodeBuildProject_SourceVersion
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (157.95s)
=== CONT  TestAccAWSCodeBuildProject_Description
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (158.31s)
=== CONT  TestAccAWSCodeBuildProject_QueuedTimeout
--- PASS: TestAccAWSCodeBuildProject_BuildBatchConfig (286.34s)
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (321.73s)
=== CONT  TestAccAWSCodeBuildProject_Source_InsecureSSL
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (256.39s)
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (254.13s)
=== CONT  TestAccAWSCodeBuildProject_BadgeEnabled
--- PASS: TestAccAWSCodeBuildProject_SourceVersion (127.72s)
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (252.45s)
=== CONT  TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (257.22s)
=== CONT  TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (255.16s)
=== CONT  TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (174.37s)
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (265.46s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (270.65s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (275.56s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (245.06s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (337.40s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (290.72s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value (332.82s)
--- PASS: TestAccAWSCodeBuildProject_Description (218.17s)
--- PASS: TestAccAWSCodeBuildProject_QueuedTimeout (218.30s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub (209.70s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (390.40s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (137.75s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (189.19s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (180.57s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit (179.71s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise (179.99s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit (180.29s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub (180.45s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise (170.95s)
--- PASS: TestAccAWSCodeBuildProject_Cache (438.06s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	746.670s
FAIL
make: *** [testacc] Error 1

TestAccAWSCodeBuildProject_WindowsServer2019Container fails due to the environmental problem but except that all the tests passed. Thank you for your review! 👍

@shuheiktgw shuheiktgw requested a review from a team August 10, 2020 07:36
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 10, 2020
@shuheiktgw shuheiktgw force-pushed the support_code_build_batch_config branch from d271db1 to 6ffd60b Compare August 10, 2020 22:41
@jemccabe
Copy link

+1

@Fuuzetsu
Copy link

Hi guys, is there anything in particular blocking this from being merged? Without it, batch builds on CodeBuild are unusable if set up via Terraform:

An error occurred (InvalidInputException) when calling the StartBuildBatch operation: BatchConfig must be configured on the project to use the BuildBatch feature

The PR has been up since August seemingly without any movement.

@tocy1
Copy link

tocy1 commented Dec 11, 2020

Hello Guys, Wanted to raise another PR for this same issue and discovered this PR. Please can this PR be merged

Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@Luis-3M
Copy link

Luis-3M commented Jan 26, 2021

+1

@carlnegroatvoxy
Copy link

+1 please merge

@ebi-yade
Copy link
Contributor

Hello, could you please resolve the conflict and merge this PR? @shuheiktgw @lmdehaas

If both of you don't have enough time, is there anything that I can help?
Anyway, I am really desired this functionality!

@shuheiktgw shuheiktgw force-pushed the support_code_build_batch_config branch from 6ffd60b to a7effe1 Compare April 13, 2021 00:49
@shuheiktgw
Copy link
Collaborator Author

shuheiktgw commented Apr 13, 2021 •
edited
Loading

It seems I messed this PR up so I'll turn this PR into a draft and fix the problem

@shuheiktgw shuheiktgw closed this Apr 13, 2021
@shuheiktgw shuheiktgw deleted the support_code_build_batch_config branch April 13, 2021 00:53
@shuheiktgw shuheiktgw restored the support_code_build_batch_config branch April 13, 2021 00:54
@shuheiktgw shuheiktgw reopened this Apr 13, 2021
@shuheiktgw shuheiktgw marked this pull request as draft April 13, 2021 00:55
@shuheiktgw shuheiktgw force-pushed the support_code_build_batch_config branch from a7effe1 to 3040e02 Compare April 14, 2021 23:19
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Apr 14, 2021
@shuheiktgw shuheiktgw force-pushed the support_code_build_batch_config branch 2 times, most recently from 0fa68af to d23c8ca Compare April 14, 2021 23:30
@shuheiktgw shuheiktgw marked this pull request as ready for review April 14, 2021 23:38
@shuheiktgw shuheiktgw force-pushed the support_code_build_batch_config branch from d23c8ca to d681747 Compare April 14, 2021 23:40
@shuheiktgw
Copy link
Collaborator Author

shuheiktgw commented Apr 14, 2021 •
edited
Loading

This PR is ready for review again now (I almost ended up rewriting it from scratch...)!
Please note that the PR needs to be reviewed by one of the maintainers to be merged.

@ewbankkit ewbankkit mentioned this pull request Apr 29, 2021
Closed
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 29, 2021
@ewbankkit ewbankkit self-assigned this Apr 29, 2021
@ewbankkit ewbankkit force-pushed the support_code_build_batch_config branch from d681747 to 424d237 Compare April 29, 2021 15:00
ewbankkit
ewbankkit approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildProject_'               
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildProject_ -timeout 180m
=== RUN   TestAccAWSCodeBuildProject_basic
=== PAUSE TestAccAWSCodeBuildProject_basic
=== RUN   TestAccAWSCodeBuildProject_BadgeEnabled
=== PAUSE TestAccAWSCodeBuildProject_BadgeEnabled
=== RUN   TestAccAWSCodeBuildProject_BuildTimeout
=== PAUSE TestAccAWSCodeBuildProject_BuildTimeout
=== RUN   TestAccAWSCodeBuildProject_QueuedTimeout
=== PAUSE TestAccAWSCodeBuildProject_QueuedTimeout
=== RUN   TestAccAWSCodeBuildProject_Cache
=== PAUSE TestAccAWSCodeBuildProject_Cache
=== RUN   TestAccAWSCodeBuildProject_Description
=== PAUSE TestAccAWSCodeBuildProject_Description
=== RUN   TestAccAWSCodeBuildProject_SourceVersion
=== PAUSE TestAccAWSCodeBuildProject_SourceVersion
=== RUN   TestAccAWSCodeBuildProject_EncryptionKey
=== PAUSE TestAccAWSCodeBuildProject_EncryptionKey
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value
=== RUN   TestAccAWSCodeBuildProject_Environment_Certificate
=== PAUSE TestAccAWSCodeBuildProject_Environment_Certificate
=== RUN   TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
=== PAUSE TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
=== RUN   TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== PAUSE TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== RUN   TestAccAWSCodeBuildProject_BuildBatchConfig
=== PAUSE TestAccAWSCodeBuildProject_BuildBatchConfig
=== RUN   TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== PAUSE TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== RUN   TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub
=== PAUSE TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub
=== RUN   TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_BuildStatusConfig_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_BuildStatusConfig_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_InsecureSSL
=== PAUSE TestAccAWSCodeBuildProject_Source_InsecureSSL
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== RUN   TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_Type_S3
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_S3
=== RUN   TestAccAWSCodeBuildProject_Source_Type_NoSource
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_NoSource
=== RUN   TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== RUN   TestAccAWSCodeBuildProject_Tags
=== PAUSE TestAccAWSCodeBuildProject_Tags
=== RUN   TestAccAWSCodeBuildProject_VpcConfig
=== PAUSE TestAccAWSCodeBuildProject_VpcConfig
=== RUN   TestAccAWSCodeBuildProject_WindowsServer2019Container
=== PAUSE TestAccAWSCodeBuildProject_WindowsServer2019Container
=== RUN   TestAccAWSCodeBuildProject_ARMContainer
=== PAUSE TestAccAWSCodeBuildProject_ARMContainer
=== RUN   TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
=== RUN   TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Location
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Location
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Name
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Name
=== RUN   TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== RUN   TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Packaging
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Packaging
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Path
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Path
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Type
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Type
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Name
    provider_test.go:55: Currently no solution to allow updates on name attribute
--- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s)
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== PAUSE TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== CONT  TestAccAWSCodeBuildProject_basic
=== CONT  TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Path
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
=== CONT  TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Packaging
=== CONT  TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== CONT  TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Name
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Location
=== CONT  TestAccAWSCodeBuildProject_ARMContainer
=== CONT  TestAccAWSCodeBuildProject_WindowsServer2019Container
=== CONT  TestAccAWSCodeBuildProject_VpcConfig
=== CONT  TestAccAWSCodeBuildProject_Tags
=== CONT  TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== CONT  TestAccAWSCodeBuildProject_Source_Type_NoSource
=== CONT  TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== CONT  TestAccAWSCodeBuildProject_Source_Type_S3
=== CONT  TestAccAWSCodeBuildProject_Source_GitCloneDepth
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (19.67s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
--- PASS: TestAccAWSCodeBuildProject_basic (39.95s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
--- PASS: TestAccAWSCodeBuildProject_ARMContainer (43.13s)
=== CONT  TestAccAWSCodeBuildProject_Environment_RegistryCredential
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (47.13s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (48.35s)
=== CONT  TestAccAWSCodeBuildProject_BuildBatchConfig
--- PASS: TestAccAWSCodeBuildProject_WindowsServer2019Container (61.49s)
=== CONT  TestAccAWSCodeBuildProject_LogsConfig_S3Logs
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (66.10s)
=== CONT  TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (78.53s)
=== CONT  TestAccAWSCodeBuildProject_Environment_Certificate
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (78.87s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (39.98s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (91.53s)
=== CONT  TestAccAWSCodeBuildProject_Cache
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (97.91s)
=== CONT  TestAccAWSCodeBuildProject_EncryptionKey
--- PASS: TestAccAWSCodeBuildProject_Tags (99.62s)
=== CONT  TestAccAWSCodeBuildProject_SourceVersion
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (102.80s)
=== CONT  TestAccAWSCodeBuildProject_Description
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (104.88s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (72.05s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (117.78s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (119.43s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
--- PASS: TestAccAWSCodeBuildProject_BuildBatchConfig (72.02s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (67.76s)
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Type
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (137.19s)
--- PASS: TestAccAWSCodeBuildProject_SourceVersion (58.66s)
=== CONT  TestAccAWSCodeBuildProject_BuildTimeout
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (66.24s)
=== CONT  TestAccAWSCodeBuildProject_QueuedTimeout
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (120.91s)
=== CONT  TestAccAWSCodeBuildProject_Source_InsecureSSL
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (171.77s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_CodePipeline
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (175.48s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_CodeCommit
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (188.85s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_Bitbucket
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (83.10s)
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (149.44s)
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (216.41s)
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
--- PASS: TestAccAWSCodeBuildProject_Description (120.78s)
=== CONT  TestAccAWSCodeBuildProject_BadgeEnabled
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (171.88s)
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value (173.20s)
=== CONT  TestAccAWSCodeBuildProject_Source_BuildStatusConfig_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (80.47s)
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (84.50s)
=== CONT  TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (158.59s)
=== CONT  TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (76.59s)
=== CONT  TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (152.65s)
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (157.78s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (164.31s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (126.99s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (224.67s)
--- PASS: TestAccAWSCodeBuildProject_QueuedTimeout (126.80s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (125.52s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (71.78s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (149.37s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (142.93s)
--- PASS: TestAccAWSCodeBuildProject_Source_BuildStatusConfig_GitHubEnterprise (63.16s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (112.36s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (107.02s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (108.29s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise (86.67s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub (86.38s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise (77.92s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub (81.68s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit (76.33s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit (74.41s)
--- PASS: TestAccAWSCodeBuildProject_Cache (254.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	349.387s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildProject_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildProject_ -timeout 180m
=== RUN   TestAccAWSCodeBuildProject_basic
=== PAUSE TestAccAWSCodeBuildProject_basic
=== RUN   TestAccAWSCodeBuildProject_BadgeEnabled
=== PAUSE TestAccAWSCodeBuildProject_BadgeEnabled
=== RUN   TestAccAWSCodeBuildProject_BuildTimeout
=== PAUSE TestAccAWSCodeBuildProject_BuildTimeout
=== RUN   TestAccAWSCodeBuildProject_QueuedTimeout
=== PAUSE TestAccAWSCodeBuildProject_QueuedTimeout
=== RUN   TestAccAWSCodeBuildProject_Cache
=== PAUSE TestAccAWSCodeBuildProject_Cache
=== RUN   TestAccAWSCodeBuildProject_Description
=== PAUSE TestAccAWSCodeBuildProject_Description
=== RUN   TestAccAWSCodeBuildProject_SourceVersion
=== PAUSE TestAccAWSCodeBuildProject_SourceVersion
=== RUN   TestAccAWSCodeBuildProject_EncryptionKey
=== PAUSE TestAccAWSCodeBuildProject_EncryptionKey
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value
=== RUN   TestAccAWSCodeBuildProject_Environment_Certificate
=== PAUSE TestAccAWSCodeBuildProject_Environment_Certificate
=== RUN   TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
=== PAUSE TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
=== RUN   TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== PAUSE TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== RUN   TestAccAWSCodeBuildProject_BuildBatchConfig
    resource_aws_codebuild_project_test.go:627: CodeBuild Project build batch config is not supported in GovCloud partition
--- SKIP: TestAccAWSCodeBuildProject_BuildBatchConfig (0.00s)
=== RUN   TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== PAUSE TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== RUN   TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub
=== PAUSE TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub
=== RUN   TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_BuildStatusConfig_GitHubEnterprise
    resource_aws_codebuild_project_test.go:925: CodeBuild Project build status config is not supported in GovCloud partition
--- SKIP: TestAccAWSCodeBuildProject_Source_BuildStatusConfig_GitHubEnterprise (0.00s)
=== RUN   TestAccAWSCodeBuildProject_Source_InsecureSSL
=== PAUSE TestAccAWSCodeBuildProject_Source_InsecureSSL
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== RUN   TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_Type_S3
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_S3
=== RUN   TestAccAWSCodeBuildProject_Source_Type_NoSource
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_NoSource
=== RUN   TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== RUN   TestAccAWSCodeBuildProject_Tags
=== PAUSE TestAccAWSCodeBuildProject_Tags
=== RUN   TestAccAWSCodeBuildProject_VpcConfig
=== PAUSE TestAccAWSCodeBuildProject_VpcConfig
=== RUN   TestAccAWSCodeBuildProject_WindowsServer2019Container
=== PAUSE TestAccAWSCodeBuildProject_WindowsServer2019Container
=== RUN   TestAccAWSCodeBuildProject_ARMContainer
=== PAUSE TestAccAWSCodeBuildProject_ARMContainer
=== RUN   TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
=== RUN   TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Location
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Location
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Name
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Name
=== RUN   TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== RUN   TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Packaging
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Packaging
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Path
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Path
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Type
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Type
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Name
    provider_test.go:55: Currently no solution to allow updates on name attribute
--- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s)
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== PAUSE TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== CONT  TestAccAWSCodeBuildProject_basic
=== CONT  TestAccAWSCodeBuildProject_Source_Type_S3
=== CONT  TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== CONT  TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit
=== CONT  TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== CONT  TestAccAWSCodeBuildProject_WindowsServer2019Container
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Type
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Path
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Packaging
=== CONT  TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== CONT  TestAccAWSCodeBuildProject_WindowsServer2019Container
    provider_test.go:1072: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/04/29 10:53:15 [DEBUG] Using modified User-Agent: Terraform/0.12.30 HashiCorp-terraform-exec/0.13.3
        
        Error: Error creating CodeBuild project: InvalidInputException: Region us-gov-west-1 is not supported for WINDOWS_SERVER_2019_CONTAINER
        
          on terraform_plugin_test.tf line 64, in resource "aws_codebuild_project" "test":
          64: resource "aws_codebuild_project" "test" {
        
        
--- SKIP: TestAccAWSCodeBuildProject_WindowsServer2019Container (24.03s)
=== CONT  TestAccAWSCodeBuildProject_ARMContainer
    provider_test.go:1072: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/04/29 10:53:28 [DEBUG] Using modified User-Agent: Terraform/0.12.30 HashiCorp-terraform-exec/0.13.3
        
        Error: Error creating CodeBuild project: InvalidInputException: Region us-gov-west-1 is not supported for ARM_CONTAINER
        
          on terraform_plugin_test.tf line 64, in resource "aws_codebuild_project" "test":
          64: resource "aws_codebuild_project" "test" {
        
        
--- SKIP: TestAccAWSCodeBuildProject_ARMContainer (11.35s)
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Name
--- PASS: TestAccAWSCodeBuildProject_basic (48.56s)
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Location
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (51.01s)
=== CONT  TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (61.28s)
=== CONT  TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit (66.43s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (68.22s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_NoSource
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (71.79s)
=== CONT  TestAccAWSCodeBuildProject_Cache
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (79.78s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (82.90s)
=== CONT  TestAccAWSCodeBuildProject_Tags
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (83.54s)
=== CONT  TestAccAWSCodeBuildProject_VpcConfig
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (84.51s)
=== CONT  TestAccAWSCodeBuildProject_EncryptionKey
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (85.91s)
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (26.83s)
=== CONT  TestAccAWSCodeBuildProject_Source_GitCloneDepth
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (97.50s)
=== CONT  TestAccAWSCodeBuildProject_SourceVersion
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (101.28s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (104.33s)
=== CONT  TestAccAWSCodeBuildProject_Description
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (76.63s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_CodePipeline
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (44.30s)
=== CONT  TestAccAWSCodeBuildProject_Environment_Certificate
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (35.36s)
=== CONT  TestAccAWSCodeBuildProject_LogsConfig_S3Logs
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (128.04s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (133.22s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (135.15s)
=== CONT  TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
--- PASS: TestAccAWSCodeBuildProject_SourceVersion (37.72s)
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (137.78s)
=== CONT  TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (43.05s)
=== CONT  TestAccAWSCodeBuildProject_Source_InsecureSSL
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (34.59s)
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit
--- PASS: TestAccAWSCodeBuildProject_Tags (69.37s)
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise
=== CONT  TestAccAWSCodeBuildProject_Cache
    resource_aws_codebuild_project_test.go:207: Step 6/8 error: Error running apply: exit status 1
        2021/04/29 10:55:32 [DEBUG] Using modified User-Agent: Terraform/0.12.30 HashiCorp-terraform-exec/0.13.3
        
        Error: [ERROR] Error updating CodeBuild project (arn:aws-us-gov:codebuild:us-gov-west-1:357342307427:project/tf-acc-test-1362578455985657395): InvalidInputException: Bucket some-new-bucket does not exist
        
          on terraform_plugin_test.tf line 64, in resource "aws_codebuild_project" "test":
          64: resource "aws_codebuild_project" "test" {
        
        
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (157.55s)
=== CONT  TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (64.41s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_CodeCommit
--- FAIL: TestAccAWSCodeBuildProject_Cache (86.06s)
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
--- PASS: TestAccAWSCodeBuildProject_Description (57.39s)
=== CONT  TestAccAWSCodeBuildProject_BuildTimeout
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (87.43s)
=== CONT  TestAccAWSCodeBuildProject_QueuedTimeout
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (117.90s)
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (64.07s)
=== CONT  TestAccAWSCodeBuildProject_BadgeEnabled
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (122.17s)
=== CONT  TestAccAWSCodeBuildProject_Source_Type_Bitbucket
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub (56.56s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (38.28s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit (54.66s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (60.52s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (58.91s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (35.10s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (41.97s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub (61.19s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (58.38s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise (70.85s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (106.28s)
--- PASS: TestAccAWSCodeBuildProject_QueuedTimeout (61.77s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (62.13s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (97.88s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (100.18s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise (102.61s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (157.41s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value (116.43s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (161.66s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (296.34s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	348.013s
FAIL
make: *** [testacc] Error 1

The failure is not new and is unrelated to this change.

@ewbankkit ewbankkit merged commit 207aca5 into hashicorp:main Apr 29, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lmdehaas lmdehaas lmdehaas approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.

Codebuild Batch Processing
9 participants
@shuheiktgw @jemccabe @Fuuzetsu @tocy1 @Luis-3M @carlnegroatvoxy @ebi-yade @ewbankkit @lmdehaas