Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNS-HTTPS subscription with delivery policy always shows up in plan #14041

Closed
aaleksandrov opened this issue Jul 3, 2020 · 3 comments · Fixed by #14255
Closed

SNS-HTTPS subscription with delivery policy always shows up in plan #14041

aaleksandrov opened this issue Jul 3, 2020 · 3 comments · Fixed by #14255
Labels
bug Addresses a defect in current functionality. service/sns Issues and PRs that pertain to the sns service.

Comments

@aaleksandrov
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.12.8
+ provider.aws v2.51.0

But this issue is here for 1+ years

Affected Resource(s)

  • aws_sns_topic_subscription

Terraform Configuration Files

terraform {
  required_version = "0.12.8"
}

provider "aws" {
  region  = "eu-west-1"
  version = "~> 2.51.0"
}

resource "aws_sns_topic" "test_sns_topic" {
  name   = "test_sns_topic"
}

resource "aws_sns_topic_subscription" "test_sns_sub" {
  topic_arn              = aws_sns_topic.test_sns_topic.arn
  protocol               = "https"
  endpoint               = "https://some-valid.url"
  endpoint_auto_confirms = true

  delivery_policy = file("${path.module}/delivery_policy.json")
}

delivery_policy.json:

{
  "healthyRetryPolicy": {
    "minDelayTarget": 20,
    "maxDelayTarget": 300,
    "numRetries": 60,
    "numMaxDelayRetries": 0,
    "numNoDelayRetries": 2,
    "numMinDelayRetries": 5,
    "backoffFunction": "exponential"
  },
  "throttlePolicy": {}
}

Debug Output

1st plan https://gist.github.com/aaleksandrov/07f9bcd6f11734d9b163d4be066fd04d
2nd plan https://gist.github.com/aaleksandrov/3d6fba42cd08b96a27ac342e0f8f564c

Expected Behavior

The 2nd plan should have no changes

Actual Behavior

The 2nd plan shows changes

Steps to Reproduce

terraform plan
terraform apply
terraform plan

@ghost ghost added the service/sns Issues and PRs that pertain to the sns service. label Jul 3, 2020
@aaleksandrov aaleksandrov changed the title SHS-HTTPS subscription with delivery policy always shows up in plan SNS-HTTPS subscription with delivery policy always shows up in plan Jul 3, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 3, 2020
@breathingdust breathingdust added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 3, 2020
@mwarkentin
Copy link
Contributor

@aaleksandrov I'm seeing the same. I noticed that if I flattened the JSON in the file to a single line, the changes no longer showed up on the plan. Do you see the same?

@aaleksandrov
Copy link
Author

aaleksandrov commented Jul 16, 2020

Hi @mwarkentin they don't show up in plan indeed. But if I do some meaningful change in such json (for instance "numMinDelayRetries" : 7) this change doesn't show up either.
So this is not a solution

@ghost
Copy link

ghost commented Mar 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/sns Issues and PRs that pertain to the sns service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants