Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rd/ami resources - add attributes #13971

Merged
merged 12 commits into from
Feb 18, 2021
Merged

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

data_source_aws_ami: added attributes `usage_operation`, `platform_details`, `ena_support`.
resource_aws_ami: added attributes `usage_operation`, `platform_details`, `image_owner_alias`, `image_type`, `hypervisor`, `owner_id`, `platform`, `public`
resource_aws_am_copyi: added attributes `usage_operation`, `platform_details`, `image_owner_alias`, `image_type`, `hypervisor`, `owner_id`, `platform`, `public`
resource_aws_ami_from_instance: added attributes `usage_operation`, `platform_details`, `image_owner_alias`, `image_type`, `hypervisor`, `owner_id`, `platform`, `public`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSAmiDataSource_natInstance (40.80s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (80.46s)
--- PASS: TestAccAWSAmiDataSource_instanceStore (40.44s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (81.81s)

--- PASS: TestAccAWSAMI_basic (91.17s)
--- PASS: TestAccAWSAMI_description (136.40s)
--- PASS: TestAccAWSAMI_disappears (87.76s)
--- PASS: TestAccAWSAMI_tags (204.51s)
--- PASS: TestAccAWSAMI_snapshotSize (92.36s)

--- PASS: TestAccAWSAMICopy_basic (417.54s)
--- PASS: TestAccAWSAMICopy_Description (427.44s)
--- PASS: TestAccAWSAMICopy_EnaSupport (407.25s)
--- PASS: TestAccAWSAMICopy_tags (508.06s)

--- PASS: TestAccAWSAMIFromInstance_tags (508.59s)
--- PASS: TestAccAWSAMIFromInstance_basic (446.45s)

@DrFaust92 DrFaust92 requested a review from a team June 27, 2020 18:19
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 27, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 18, 2020
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@bflad
Copy link
Contributor

bflad commented Feb 16, 2021

Hey @DrFaust92 👋 We would love to pick this up on Thursday as part of some gardening work. If you could rebase this and add a changelog file that would be awesome. Thank you!

@bflad bflad self-assigned this Feb 18, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor items, otherwise looking good. 👍

.changelog/13971.txt Outdated Show resolved Hide resolved
aws/resource_aws_ami.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSAMI_basic (59.57s)
--- PASS: TestAccAWSAMI_description (98.58s)
--- PASS: TestAccAWSAMI_disappears (40.00s)
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (78.81s)
--- PASS: TestAccAWSAMI_Gp3BlockDevice (79.07s)
--- PASS: TestAccAWSAMI_tags (109.41s)
--- PASS: TestAccAWSAMICopy_basic (395.93s)
--- PASS: TestAccAWSAMICopy_Description (409.59s)
--- PASS: TestAccAWSAMICopy_EnaSupport (372.63s)
--- PASS: TestAccAWSAMICopy_tags (428.85s)
--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (59.12s)
--- PASS: TestAccAWSAmiDataSource_instanceStore (41.68s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (43.45s)
--- PASS: TestAccAWSAmiDataSource_natInstance (42.13s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (18.87s)
--- PASS: TestAccAWSAMIFromInstance_basic (413.45s)
--- PASS: TestAccAWSAMIFromInstance_tags (374.88s)
--- PASS: TestAccAWSAMILaunchPermission_basic (353.55s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_AMI (384.69s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission (366.18s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public (368.99s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSAMI_basic (65.04s)
--- PASS: TestAccAWSAMI_description (100.16s)
--- PASS: TestAccAWSAMI_disappears (59.64s)
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (61.96s)
--- PASS: TestAccAWSAMI_Gp3BlockDevice (84.59s)
--- PASS: TestAccAWSAMI_tags (101.42s)
--- PASS: TestAccAWSAMICopy_basic (374.60s)
--- PASS: TestAccAWSAMICopy_Description (414.45s)
--- PASS: TestAccAWSAMICopy_EnaSupport (400.09s)
--- PASS: TestAccAWSAMICopy_tags (432.88s)
--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (60.01s)
--- PASS: TestAccAWSAmiDataSource_instanceStore (40.56s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (45.57s)
--- PASS: TestAccAWSAmiDataSource_natInstance (43.64s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (43.92s)
--- PASS: TestAccAWSAMIFromInstance_basic (297.34s)
--- PASS: TestAccAWSAMIFromInstance_tags (355.68s)
--- PASS: TestAccAWSAMILaunchPermission_basic (357.39s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_AMI (366.95s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission (354.88s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public (356.13s)

@bflad bflad merged commit 466c08e into hashicorp:main Feb 18, 2021
@github-actions github-actions bot added this to the v3.29.0 milestone Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2021
@DrFaust92 DrFaust92 deleted the r/ami_add_fields branch April 15, 2021 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants