EKS Node Group Resource Tag Inheritance

[jornj-lululemon]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently EKS Node Group resources create autoscaling groups that do not inherit or pass down any configuration defined tags except the default EKS service association tags. AWS EKS clusters (both on the cluster itself and created node groups) currently do not support tag propagation, and terraform only appears to track the autoscaling group name(s) created by the EKS node group resource. Since the AWS terraform provisioner does not have functionality to define supplemental tags on untracked resources, the current workaround seems to be creating a local_exec provisioner calling the AWS autoscaling CreateOrUpdateTags API call.

New or Affected Resource(s)

eks_node_group

Potential Terraform Configuration

autoscaling_group_tags = {
    "my.eksnodegroup.asg.key" = "value"
}

or

propagate_tags = true/false

References

https://docs.aws.amazon.com/eks/latest/userguide/eks-using-tags.html
https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_CreateOrUpdateTags.html

[ewbankkit]

@jornj-lululemon Thanks for raising this issue.
As similar thought has been noted in #9061.
Let's keep this issue open until that is addressed.

[jornj-lululemon]

@ewbankkit Thanks for the triage, one thing to note is that the eks_node_group resources expose the autoscaling group name attribute list under aws_eks_node_group.my_resource_name.resources[*].autoscaling_groups[*].name so all the information necessary to passdown tags is available.

[DrFaust92]

FYI, Ive asked AWS SA that i work with to ask the EKS service team to address this, its seems to be in their roadmap.

[bflad]

Please note I'm dual labeling this issue -- if the upstream EKS API implements tag propagation support, great! Otherwise, we can consider the following new resource type for managing Autoscaling tags in the meantime:

resource "aws_autoscaling_tag" "example" {
  key                 = "key1"
  propagate_at_launch = true
  resource_id         = aws_eks_node_group.my_resource_name.resources[*].autoscaling_groups[*].name
  value               = "value1"
}

[github-actions]

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.