data-source/aws_eks_node_group

[zot24]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13442

Release note for CHANGELOG:

New Data Source: aws_eks_node_group
New Data Source: aws_eks_node_group_names

Output from acceptance testing:

$make testacc TEST=./aws TESTARGS='-run=TestAccAWSEksNodegroupDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSEksNodegroupDataSource_basic -timeout 120m
=== RUN   TestAccAWSEksNodegroupDataSource_basic
--- PASS: TestAccAWSEksNodegroupDataSource_basic (1631.74s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1632.629s

$make testacc TEST=./aws TESTARGS='-run=TestAccAWSEksNodegroupNamesDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSEksNodegroupNamesDataSource_basic -timeout 120m
=== RUN   TestAccAWSEksNodegroupNamesDataSource_basic
--- PASS: TestAccAWSEksNodegroupNamesDataSource_basic (1614.61s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1615.495s

[zot24]

Hey folks! this is my first PR I'm excited waiting for feedback 😄 let me know if there is anything you want me to work on and change, I have certain doubts naming of things mainly as well as some doubts around the acceptance tests

Feedback is welcome thanks!

[zot24]

@bflad I'm sorry, hate to do this but I'm uncertain how to get some feedback on this PR

It's most likely that I would have to change things and would love to dedicate the time to it now that I can, would be great to get some help if possible. I'm pinging you Brian as I can see you are involve in pretty much every PR

Hope this is not to intrusive I just don't want this PR to get lost in time as I think it could be a good addition to the provider

[teamterraform]

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Action Required: Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

[sgran]

Minor cleanup in docs requested.

[DonBower]

Is there an ETA on this feature?

[ghost]

Hello, and thank you for your contribution!

This project recently upgraded to V2 of the Terraform Plugin SDK

This pull request appears to include at least one V1 import path of the SDK ("github.com/hashicorp/terraform-plugin-sdk/helper/schema"). Please import the V2 path github.com/hashicorp/terraform-plugin-sdk/v2/helper/PACKAGE

To resolve this situation without losing any existing work, you may be able to Git rebase your branch against the current default (main) branch (example below); replacing any remaining old import paths with the newer ones.

$ git fetch --all
$ git rebase origin/main

Another option is to create a new branch from the current default (main) with the same code changes (replacing the import paths), submit a new pull request, and close this existing pull request.

We apologize for this inconvenience and appreciate your effort. Thank you for contributing and helping make the Terraform AWS Provider better for everyone.

[DonBower]

can this be merged? I could really use this data source.

[DonBower]

@teamterraform Can this PR be merged? I could really use the ability the retrive the ASG from an existing node group

[sgran]

@teamterraform what's blocking getting this merged? I could really use this functionality for some work I'm doing.

[DonBower]

Still waiting....
Review requested
Review has been requested on this pull request. It is not required to merge.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSEksNodegroupDataSource_\|TestAccAWSEksNodegroupsDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksNodegroupDataSource_\|TestAccAWSEksNodegroupsDataSource_ -timeout 180m
=== RUN   TestAccAWSEksNodegroupDataSource_basic
--- PASS: TestAccAWSEksNodegroupDataSource_basic (1281.02s)
=== RUN   TestAccAWSEksNodegroupsDataSource_basic
--- PASS: TestAccAWSEksNodegroupsDataSource_basic (1185.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2469.764s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSEksNodegroupDataSource_\|TestAccAWSEksNodegroupsDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksNodegroupDataSource_\|TestAccAWSEksNodegroupsDataSource_ -timeout 180m
=== RUN   TestAccAWSEksNodegroupDataSource_basic
--- PASS: TestAccAWSEksNodegroupDataSource_basic (993.60s)
=== RUN   TestAccAWSEksNodegroupsDataSource_basic
--- PASS: TestAccAWSEksNodegroupsDataSource_basic (977.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1974.608s

[ewbankkit]

@zot24 Thanks for the contribution 🎉 👏.
I renamed the aws_eks_node_group_names data source to aws_eks_node_groups to match other plural data sources.

[DonBower]

Thank you @zot24 and @ewbankkit !

[github-actions]

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[zot24]

Thanks guys! 👏🏽 @ewbankkit great work 😄 glad to see this merged!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.